From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 898B2C4338F for ; Tue, 3 Aug 2021 23:55:10 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EE42061040 for ; Tue, 3 Aug 2021 23:55:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org EE42061040 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:55666 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mB4FY-0002rN-R5 for qemu-devel@archiver.kernel.org; Tue, 03 Aug 2021 19:55:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46592) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mB4Es-000280-W7 for qemu-devel@nongnu.org; Tue, 03 Aug 2021 19:54:27 -0400 Received: from mail-pl1-x636.google.com ([2607:f8b0:4864:20::636]:37512) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mB4Er-0006Jq-Cx for qemu-devel@nongnu.org; Tue, 03 Aug 2021 19:54:26 -0400 Received: by mail-pl1-x636.google.com with SMTP id j3so1015907plx.4 for ; Tue, 03 Aug 2021 16:54:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=0UMhOzG7Sj5C78mmKAMJQjH2EWSri0mjZwbKwW3xuVc=; b=U5kLH0vsWlKwWVCA64wCL0RJOjIwRujQK7wzw8VA7hGj6zFwH9KtmzvDGunvvTOOv7 XjbuHLzOW6zXeasIABfBU+CtR5q0cvwkGcSIyThOyKbjY0RabzfgobppzIWlRmJ60zHR A7STKLKsWkVcpbZMHkqX4m29iVBjhh374pwylGAYfeMzedEGGPIb6mCIAYSZzBotb9qM /1gnQyAQEytvstrbkwZCnyqttOImTvcGUCb/oWjD9WaoyJ52rgiTh9SWvxlADshit9Wf AkCj/0F6/UbnZjhB/ZEI2m2FObyijyaclDaXoKkNvXahzEuNrazALDg+fB4Y6mQfOZwn Qb5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=0UMhOzG7Sj5C78mmKAMJQjH2EWSri0mjZwbKwW3xuVc=; b=QIAY8y4dbMurtm8np2eSlEJzVoTiK49t8ICX4NY/nUhiLdajG2Ym3d9J3KfnHbDcHw NgRG/KgEqymUXTyDOT9/MUgDiot9IDRwcXvGuEVwq0QdIcx9m+vRQROUUkl50cnD+2Tt p3BHOyBQ3lS73FcyxFNMXZB0pKKT6HuTorrm7vFMY5LHkZfxRCfZ7nJUdDJ5C7JO8b3Y g8m3yVaQBeMl7+ONDmZyOkElm+KIfrM4yJK+UKPBPYaxh1clGnaGs9JrJ/v6JnCql5wX RHpx50kYgj292di9UXlFxWUnhmmR5nZC3ZwJME78sMuI8qRlWlEPrnXP/47I9r9ZFlTC kEEQ== X-Gm-Message-State: AOAM532jCeLduZuOGJJTOgnw4ee6GyY8TQUKBa6q1vyi1gB+VbQ4b3+b L0d4XJVMwDPKIYLNTzS2s/GAag== X-Google-Smtp-Source: ABdhPJypc2p9BhHxhm7chBCxq//gJOmy5Lu8QNytMI4jDP+dIz1CzwEZZc0+gMPtlUtjdnaDwgKsxg== X-Received: by 2002:a17:902:8506:b029:12c:76a8:d1b8 with SMTP id bj6-20020a1709028506b029012c76a8d1b8mr8399012plb.14.1628034863712; Tue, 03 Aug 2021 16:54:23 -0700 (PDT) Received: from [192.168.6.169] (rrcs-173-198-77-218.west.biz.rr.com. [173.198.77.218]) by smtp.gmail.com with ESMTPSA id h21sm322161pfq.130.2021.08.03.16.54.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 03 Aug 2021 16:54:23 -0700 (PDT) Subject: Re: [PATCH v2] accel/tcg/user-exec: Fix read-modify-write of code on s390 hosts To: Ilya Leoshkevich , Riku Voipio , Paolo Bonzini References: <20210803221606.150103-1-iii@linux.ibm.com> From: Richard Henderson Message-ID: Date: Tue, 3 Aug 2021 13:54:19 -1000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210803221606.150103-1-iii@linux.ibm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2607:f8b0:4864:20::636; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x636.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Christian Borntraeger , qemu-devel@nongnu.org, Andreas Krebbel Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 8/3/21 12:16 PM, Ilya Leoshkevich wrote: > x86_64 dotnet/runtime uses cmpxchg for code patching. When running it > under s390x qemu-linux user, cpu_signal_handler() does not recognize > this as a write and does not restore PAGE_WRITE cleared by > tb_page_add(), incorrectly forwarding the signal to the guest code. > > Signed-off-by: Ilya Leoshkevich > --- > > v1:https://lists.nongnu.org/archive/html/qemu-devel/2021-08/msg00464.html > v1 -> v2: Fix comment style, fix CSST detection (Richard). > > accel/tcg/user-exec.c | 48 ++++++++++++++++++++++++++++++++++++------- > 1 file changed, 41 insertions(+), 7 deletions(-) Reviewed-by: Richard Henderson r~