From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C75ADC433ED for ; Tue, 18 May 2021 19:05:53 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F1C4A610E9 for ; Tue, 18 May 2021 19:05:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F1C4A610E9 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=eldorado.org.br Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:54952 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lj52O-0005nn-0U for qemu-devel@archiver.kernel.org; Tue, 18 May 2021 15:05:52 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51540) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lj4ie-0005nn-Vu; Tue, 18 May 2021 14:45:29 -0400 Received: from [201.28.113.2] (port=52130 helo=outlook.eldorado.org.br) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lj4ic-0003fL-H7; Tue, 18 May 2021 14:45:28 -0400 Received: from power9a ([10.10.71.235]) by outlook.eldorado.org.br with Microsoft SMTPSVC(8.5.9600.16384); Tue, 18 May 2021 15:45:22 -0300 Received: from [127.0.0.1] (unknown [10.10.71.235]) by power9a (Postfix) with ESMTPS id C7E36801362; Tue, 18 May 2021 15:45:21 -0300 (-03) Subject: Re: [PATCH 09/11] include/exec: added functions to the stubs in exec-all.h To: Richard Henderson , Lucas Mateus Martins Araujo e Castro , David Gibson References: <20210512140813.112884-1-bruno.larsen@eldorado.org.br> <20210512140813.112884-10-bruno.larsen@eldorado.org.br> <06d4250b-4d4a-42a6-47fa-f5b75ea6c499@eldorado.org.br> <88f58334-8bae-a9bd-aac0-aa20d432595f@linaro.org> From: Bruno Piazera Larsen Message-ID: Date: Tue, 18 May 2021 15:45:21 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <88f58334-8bae-a9bd-aac0-aa20d432595f@linaro.org> Content-Type: multipart/alternative; boundary="------------123AC5409CE653A9BFCF3F61" Content-Language: en-US X-OriginalArrivalTime: 18 May 2021 18:45:22.0235 (UTC) FILETIME=[F530A8B0:01D74C15] X-Host-Lookup-Failed: Reverse DNS lookup failed for 201.28.113.2 (failed) Received-SPF: pass client-ip=201.28.113.2; envelope-from=bruno.larsen@eldorado.org.br; helo=outlook.eldorado.org.br X-Spam_score_int: -10 X-Spam_score: -1.1 X-Spam_bar: - X-Spam_report: (-1.1 / 5.0 requ) BAYES_00=-1.9, HTML_MESSAGE=0.001, NICE_REPLY_A=-0.001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: farosas@linux.ibm.com, qemu-devel@nongnu.org, luis.pires@eldorado.org.br, fernando.valle@eldorado.org.br, qemu-ppc@nongnu.org, matheus.ferst@eldorado.org.br Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" This is a multi-part message in MIME format. --------------123AC5409CE653A9BFCF3F61 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit On 17/05/2021 15:02, Richard Henderson wrote: > On 5/17/21 11:59 AM, Lucas Mateus Martins Araujo e Castro wrote: >> I'm not completely sure how this should be handled, there's a >> get_physical_address in mmu_helper.c but it's a static function and >> divided by processor families instead of MMU types, so >> get_physical_address_* should be a new function? >> >> The new get_physical_address_* function would be a mmu-hash(32|64) >> that do something like ppc_radix64_xlate and add a function to >> mmu-book3s-v3 that call either the radix64 or the hash64 function and >> also handle real mode access. > > The entry points that we are concerned about are: >   ppc_cpu_get_phys_page_debug >   ppc_cpu_tlb_fill > > Currently there is a hook, pcc->handle_mmu_fault, which is used by > ppc_cpu_tlb_fill, but is insufficiently general.  We're going to > remove that hook. > > We're going to add a new hook with the same interface as > ppc_radix64_xlate that will be used by both > ppc_cpu_get_phys_page_debug and ppc_cpu_tlb_fill. > So, just to make sure we understand, what we want to do is: * take all the common code from *_handle_mmu_fault and put it in ppc_cpu_tlb_fill * take whatever is not common and hide it in an equivalent of ppc_radix64_xlate * make the 2 entry points only use these new functions, so we can compile ppc_cpu_get_phys_page_debug * move get_physical_address and all functions called by it somewhere that will compile when we disable tcg (again, to compile get_phys_page_debug) Is that it? Sorry if this is very obvious, we never dealt with hardware and mmu stuff before... -- Bruno Piazera Larsen Instituto de Pesquisas ELDORADO Departamento Computação Embarcada Analista de Software Trainee Aviso Legal - Disclaimer --------------123AC5409CE653A9BFCF3F61 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: 8bit


On 17/05/2021 15:02, Richard Henderson wrote:
On 5/17/21 11:59 AM, Lucas Mateus Martins Araujo e Castro wrote:
I'm not completely sure how this should be handled, there's a get_physical_address in mmu_helper.c but it's a static function and divided by processor families instead of MMU types, so get_physical_address_* should be a new function?

The new get_physical_address_* function would be a mmu-hash(32|64) that do something like ppc_radix64_xlate and add a function to mmu-book3s-v3 that call either the radix64 or the hash64 function and also handle real mode access.

The entry points that we are concerned about are:
  ppc_cpu_get_phys_page_debug
  ppc_cpu_tlb_fill

Currently there is a hook, pcc->handle_mmu_fault, which is used by ppc_cpu_tlb_fill, but is insufficiently general.  We're going to remove that hook.

We're going to add a new hook with the same interface as ppc_radix64_xlate that will be used by both ppc_cpu_get_phys_page_debug and ppc_cpu_tlb_fill.

So, just to make sure we understand, what we want to do is:

* take all the common code from *_handle_mmu_fault and put it in ppc_cpu_tlb_fill

* take whatever is not common and hide it in an equivalent of ppc_radix64_xlate

* make the 2 entry points only use these new functions, so we can compile ppc_cpu_get_phys_page_debug

* move get_physical_address and all functions called by it somewhere that will compile when we disable tcg (again, to compile get_phys_page_debug)

Is that it? Sorry if this is very obvious, we never dealt with hardware and mmu stuff before...

--
Bruno Piazera Larsen
Instituto de Pesquisas ELDORADO
Departamento Computação Embarcada
Analista de Software Trainee
Aviso Legal - Disclaimer
--------------123AC5409CE653A9BFCF3F61--