From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: Titus Rwantare <titusr@google.com>, Corey Minyard <cminyard@mvista.com>
Cc: Hao Wu <wuhaotsh@google.com>, qemu-arm@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [PATCH 1/3] hw/i2c: add support for PMBus
Date: Tue, 4 May 2021 22:49:32 +0200 [thread overview]
Message-ID: <b0e4ed67-d8fd-3902-6a71-144203b9a9da@amsat.org> (raw)
In-Reply-To: <20210504162841.2884846-2-titusr@google.com>
Hi Titus,
On 5/4/21 6:28 PM, Titus Rwantare wrote:
> QEMU has support for SMBus devices, and PMBus is a more specific
> implementation of SMBus. The additions made in this commit makes it easier to
> add new PMBus devices to QEMU.
>
> https://pmbus.org/specification-archives/
>
> Reviewed-by: Hao Wu <wuhaotsh@google.com>
> Signed-off-by: Titus Rwantare <titusr@google.com>
> ---
> hw/arm/Kconfig | 1 +
> hw/i2c/Kconfig | 4 +
> hw/i2c/meson.build | 1 +
> hw/i2c/pmbus_device.c | 1611 +++++++++++++++++++++++++++++++++
> include/hw/i2c/pmbus_device.h | 520 +++++++++++
> 5 files changed, 2137 insertions(+)
TBH this is quite a big patch to digest.
Any chance you could split it?
Thanks,
Phil.
next prev parent reply other threads:[~2021-05-04 20:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-04 16:28 [PATCH 0/3] Add support for PMBus in QEMU Titus Rwantare
2021-05-04 16:28 ` [PATCH 1/3] hw/i2c: add support for PMBus Titus Rwantare
2021-05-04 20:49 ` Philippe Mathieu-Daudé [this message]
2021-05-04 21:45 ` Titus Rwantare
2021-05-05 1:41 ` Joel Stanley
2021-05-04 16:28 ` [PATCH 2/3] hw/misc: add ADM1272 device Titus Rwantare
2021-05-04 16:28 ` [PATCH 3/3] hw/misc: add MAX34451 device Titus Rwantare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b0e4ed67-d8fd-3902-6a71-144203b9a9da@amsat.org \
--to=f4bug@amsat.org \
--cc=cminyard@mvista.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=titusr@google.com \
--cc=wuhaotsh@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).