From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F981C433E2 for ; Wed, 15 Jul 2020 12:27:43 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6B72C206E9 for ; Wed, 15 Jul 2020 12:27:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="RxcFhRdz" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6B72C206E9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:53200 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jvgVi-0001y5-PD for qemu-devel@archiver.kernel.org; Wed, 15 Jul 2020 08:27:42 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34592) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jvgV8-0001SL-MW for qemu-devel@nongnu.org; Wed, 15 Jul 2020 08:27:06 -0400 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:54863 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jvgV5-00035z-HD for qemu-devel@nongnu.org; Wed, 15 Jul 2020 08:27:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1594816022; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MI3ApuPmV+XnwADtK+8OS+Kl4ftWFCRfk0d8a15DsVw=; b=RxcFhRdzSGxfvbXG0LybWW8egplGAe8L+oedVEMMCen3uNNn0v06QMa3ap/rmhgfGkkeHS PfGUV4j4BjlXGJj0IkckDgJm15/ezYx119f21PLrBraeOJ5gU3XhK+9uib9qlWaih3mHGE GI/I5MtUlbwlwwTtfnzOMyVEa10HmUw= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-152-twX49xd-PrGHN5IKo_0uuA-1; Wed, 15 Jul 2020 08:26:29 -0400 X-MC-Unique: twX49xd-PrGHN5IKo_0uuA-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 4D46B8027EC; Wed, 15 Jul 2020 12:26:28 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-114-3.ams2.redhat.com [10.36.114.3]) by smtp.corp.redhat.com (Postfix) with ESMTP id BAAD972E7A; Wed, 15 Jul 2020 12:26:20 +0000 (UTC) Subject: Re: [PATCH 3/4] hw/arm/virt-acpi-build: Only expose flash on older machine types To: Andrew Jones , Igor Mammedov References: <20200629140938.17566-1-drjones@redhat.com> <20200629140938.17566-4-drjones@redhat.com> <20200713104907.335bf762@redhat.com> <20200714055109.owrlob6m53notzh3@kamzik.brq.redhat.com> <20200714045537-mutt-send-email-mst@kernel.org> <20200714092325.5klaeqelu46mhg76@kamzik.brq.redhat.com> <20200714164141.1ce6b122@redhat.com> <20200715063648.rigcdnaxveened6u@kamzik.brq.redhat.com> From: Laszlo Ersek Message-ID: Date: Wed, 15 Jul 2020 14:26:19 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Firefox/52.0 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20200715063648.rigcdnaxveened6u@kamzik.brq.redhat.com> Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=205.139.110.120; envelope-from=lersek@redhat.com; helo=us-smtp-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/07/15 02:37:05 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -40 X-Spam_score: -4.1 X-Spam_bar: ---- X-Spam_report: (-4.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, ard.biesheuvel@arm.com, "Michael S. Tsirkin" , qemu-devel@nongnu.org, shannon.zhaosl@gmail.com, qemu-arm@nongnu.org, eric.auger@redhat.com, philmd@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Hi Drew, On 07/15/20 08:36, Andrew Jones wrote: > So it sounds to me like we have some flexibility in our versioned machine > maintenance. We can choose to forgo the usual compat code when the risk is > deemed low enough. And, if somebody screams, we can always fix it later. > I can live with that. I'll go ahead and respin without the versioning. In that case, please don't simply remove the acpi_dsdt_add_flash() call from build_dsdt(), because then "git blame" won't be able to help later. Can you please replace the call with a comment instead, similar to the RTC comment from commit 67736a25f865 ("ARM: virt: Don't generate RTC ACPI device when using UEFI", 2016-01-15)? Thanks! Laszlo