From: Thomas Huth <thuth@redhat.com>
To: Cornelia Huck <cohuck@redhat.com>, qemu-devel@nongnu.org
Cc: "Wainer dos Santos Moschetta" <wainersm@redhat.com>,
"Halil Pasic" <pasic@linux.ibm.com>,
"Christian Borntraeger" <borntraeger@de.ibm.com>,
qemu-s390x@nongnu.org, "Cleber Rosa" <crosa@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>
Subject: Re: [PATCH 3/3] tests/acceptance: test s390x zpci fid propagation
Date: Tue, 1 Dec 2020 11:52:31 +0100 [thread overview]
Message-ID: <b2c24c76-7a1f-9414-de62-46241a708c37@redhat.com> (raw)
In-Reply-To: <20201130180216.15366-4-cohuck@redhat.com>
On 30/11/2020 19.02, Cornelia Huck wrote:
> Verify that a fid specified on the command line shows up correctly
> as the function_id in the guest.
>
> Signed-off-by: Cornelia Huck <cohuck@redhat.com>
> ---
> tests/acceptance/machine_s390_ccw_virtio.py | 12 +++++++++---
> 1 file changed, 9 insertions(+), 3 deletions(-)
>
> diff --git a/tests/acceptance/machine_s390_ccw_virtio.py b/tests/acceptance/machine_s390_ccw_virtio.py
> index e203ee304264..53b8484f8f9c 100644
> --- a/tests/acceptance/machine_s390_ccw_virtio.py
> +++ b/tests/acceptance/machine_s390_ccw_virtio.py
> @@ -56,7 +56,9 @@ class S390CCWVirtioMachine(Test):
> '-device',
> 'virtio-rng-ccw,devno=fe.3.1234,max_revision=2',
> '-device', 'zpci,uid=5,target=zzz',
> - '-device', 'virtio-net-pci,id=zzz')
> + '-device', 'virtio-net-pci,id=zzz',
> + '-device', 'zpci,uid=0xa,fid=12,target=serial',
> + '-device', 'virtio-serial-pci,id=serial')
> self.vm.launch()
>
> shell_ready = "sh: can't access tty; job control turned off"
> @@ -65,11 +67,11 @@ class S390CCWVirtioMachine(Test):
> exec_command_and_wait_for_pattern(self, 'exit', shell_ready)
>
> ccw_bus_ids="0.1.1111 0.2.0000 0.3.1234"
> - pci_bus_id="0005:00:00.0"
> + pci_bus_ids="0005:00:00.0 000a:00:00.0"
> exec_command_and_wait_for_pattern(self, 'ls /sys/bus/ccw/devices/',
> ccw_bus_ids)
> exec_command_and_wait_for_pattern(self, 'ls /sys/bus/pci/devices/',
> - pci_bus_id)
> + pci_bus_ids)
> # check that the device at 0.2.0000 is in legacy mode, while the
> # device at 0.3.1234 has the virtio-1 feature bit set
> virtio_rng_features="0000000000000000000000000000110010000000000000000000000000000000"
> @@ -91,3 +93,7 @@ class S390CCWVirtioMachine(Test):
> exec_command_and_wait_for_pattern(self,
> 'cat /sys/bus/pci/devices/0005\:00\:00.0/subsystem_device',
> '0x0001')
> + # check fid propagation
> + exec_command_and_wait_for_pattern(self,
> + 'cat /sys/bus/pci/devices/000a\:00\:00.0/function_id',
> + '0x0000000c')
>
Reviewed-by: Thomas Huth <thuth@redhat.com>
next prev parent reply other threads:[~2020-12-01 10:57 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-30 18:02 [PATCH 0/3] tests/acceptance: enhance s390x devices test Cornelia Huck
2020-11-30 18:02 ` [PATCH 1/3] tests/acceptance: test virtio-ccw revision handling Cornelia Huck
2020-12-01 10:43 ` Thomas Huth
2020-12-04 13:36 ` Wainer dos Santos Moschetta
2020-12-07 11:09 ` Cornelia Huck
2020-11-30 18:02 ` [PATCH 2/3] tests/acceptance: verify s390x device detection Cornelia Huck
2020-12-01 10:49 ` Thomas Huth
2020-12-04 13:47 ` Wainer dos Santos Moschetta
2020-12-07 11:10 ` Cornelia Huck
2020-11-30 18:02 ` [PATCH 3/3] tests/acceptance: test s390x zpci fid propagation Cornelia Huck
2020-12-01 10:52 ` Thomas Huth [this message]
2020-12-04 13:50 ` Wainer dos Santos Moschetta
2020-12-07 13:38 ` [PATCH 0/3] tests/acceptance: enhance s390x devices test Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b2c24c76-7a1f-9414-de62-46241a708c37@redhat.com \
--to=thuth@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=crosa@redhat.com \
--cc=pasic@linux.ibm.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=wainersm@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).