From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E86EDC433ED for ; Mon, 26 Apr 2021 09:25:15 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 46C3E6052B for ; Mon, 26 Apr 2021 09:25:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 46C3E6052B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=amsat.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:33900 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1laxUP-0001Le-SA for qemu-devel@archiver.kernel.org; Mon, 26 Apr 2021 05:25:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38872) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1laxSz-0000FS-QQ for qemu-devel@nongnu.org; Mon, 26 Apr 2021 05:23:45 -0400 Received: from mail-wr1-x431.google.com ([2a00:1450:4864:20::431]:36785) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1laxSs-0003Vo-88 for qemu-devel@nongnu.org; Mon, 26 Apr 2021 05:23:43 -0400 Received: by mail-wr1-x431.google.com with SMTP id m9so42310974wrx.3 for ; Mon, 26 Apr 2021 02:23:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=ypTCcpGDOH8f7Vsihr5Sivrmq3VqK7cNiUPIWaGl0bU=; b=uVhrKTo5+jE6X5ccgMS2V0pG8iNZrYzqtWcDmZ/PT+ydm0ZCFqn68n4akfdWRUr14I ovS9cnkcAyUKEe/HAq5/W67gVnNOH2SxgE/UMwWMjmG1HkHgQ1HsBsT3iJlFmRtm/MFF EOUDVXnR0B/7ipSQO3l+VIUBBD7g40SUyj8UzaMXLKsjbqDMGjV5Osrms2sTdvhzi7YB Isr5OabCc6/j4bdR4e0hD1gVBCxFtkAp4HEqjabRMPtNcERaPBo854IDN3ipNRi7Yk0P WnRKWsvgmoB7X4ERDF0YAtt+MO0l7A/HK/pu8APGuc6wt9AGSxZeyVqN0vMIcMNw/fN2 ehRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ypTCcpGDOH8f7Vsihr5Sivrmq3VqK7cNiUPIWaGl0bU=; b=iO+2zk6K90qwOWkDDkXCfDCUCvJ1iVeRVAGy5JxAGD8df7V0oMWVZlvGI15TM9X/eP hhcNzRiR1gdr6ATYrTxz68s6s0F8w3vZTtBXfdyM2KJ3ZJa10Dzdo07A7LuRhsiao4Nm VkGpGCd91i9uw6a/qyLgYAUA0piP+0U3Ves5r3lPpPqE2nsCe+EaYRe5oLvaOyBwekb6 bJdLWO68oDiBg+0JXSQ+/t+xQlxlurQ71/7OpJRjWg1MwelHLsa00weZaAgV2uOyxYu7 UdZE5MXitqJDYXfqTG/ZNLnRG9wlw5XoW9Nd899aRhxGFc217Xsx9ng1C8YZ5nLXIpWy lFBA== X-Gm-Message-State: AOAM532Vx624OOH6OWpg/TkS2Jk3tQBN69Z31FAn2dH6uywegW8W/UZN DXJUxVmq+kcY+g6yPXlycXI= X-Google-Smtp-Source: ABdhPJzs4eCX090dLmmD/96GFk+M+Oe12/Kj9mA3JzYkAgEkgPjduZK8dEcBIqkxtLu3/FGQTE6vmw== X-Received: by 2002:adf:ce90:: with SMTP id r16mr21644270wrn.354.1619429015331; Mon, 26 Apr 2021 02:23:35 -0700 (PDT) Received: from [192.168.1.36] (39.red-81-40-121.staticip.rima-tde.net. [81.40.121.39]) by smtp.gmail.com with ESMTPSA id f1sm19721811wru.60.2021.04.26.02.23.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 26 Apr 2021 02:23:34 -0700 (PDT) Subject: Re: Resetting non-qdev children in a 3-phase reset device To: Peter Maydell References: <87y2datpyw.fsf@dusky.pond.sub.org> <5570bf5a-3cab-c30c-2c21-0ab02543199e@amsat.org> <2f4155ca-ee84-75f0-8b35-aac6b18ee4f0@amsat.org> <3dcb8efa-8f6b-0f45-a753-cc58d3bf9855@amsat.org> <87im4cb6ag.fsf@dusky.pond.sub.org> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Message-ID: Date: Mon, 26 Apr 2021 11:23:33 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::431; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-x431.google.com X-Spam_score_int: -14 X-Spam_score: -1.5 X-Spam_bar: - X-Spam_report: (-1.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Damien Hedde , Eduardo Habkost , "Michael S. Tsirkin" , Markus Armbruster , QEMU Developers , Paolo Bonzini Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 4/25/21 8:33 PM, Peter Maydell wrote: > On Sat, 24 Apr 2021 at 14:04, Philippe Mathieu-Daudé wrote: >> I now understand better the diag288 case, but I still don't understand >> the TYPE_APIC one. It has no DeviceClass::reset(), its abstract parent >> TYPE_APIC_COMMON register apic_reset_common() but being TYPE_DEVICE it >> is not on a qbus. It is somehow connected to the X86CPU object, but the >> single call to apic_init_reset() is from do_cpu_init() - not a reset >> method -. > > pc_machine_reset() calls device_legacy_reset(cpu->apic_state) > which is to say it invokes the DeviceState::reset method, > which is either kvm_apic_reset or apic_reset_common. Oh, thanks! I guess "convoluted" is the proper adjective to describe this reset logic. I suppose APIC is a very old device, part of the Frankenstein PC, so hard to rework (because we are scared of the implications of changing old & heavily used devices).