From: Richard Henderson <richard.henderson@linaro.org>
To: "Alex Bennée" <alex.bennee@linaro.org>, qemu-devel@nongnu.org
Cc: f4bug@amsat.org, mads@ynddal.dk,
Paolo Bonzini <pbonzini@redhat.com>,
"open list:Overall KVM CPUs" <kvm@vger.kernel.org>
Subject: Re: [PATCH v1 8/9] gdbstub: move breakpoint logic to accel ops
Date: Sun, 25 Sep 2022 10:18:36 +0000 [thread overview]
Message-ID: <b4066f96-8cf1-e301-5167-f256d4a3a35e@linaro.org> (raw)
In-Reply-To: <20220922145832.1934429-9-alex.bennee@linaro.org>
On 9/22/22 14:58, Alex Bennée wrote:
> As HW virtualization requires specific support to handle breakpoints
> lets push out special casing out of the core gdbstub code and into
> AccelOpsClass. This will make it easier to add other accelerator
> support and reduces some of the stub shenanigans.
>
> Signed-off-by: Alex Bennée<alex.bennee@linaro.org>
> Cc: Mads Ynddal<mads@ynddal.dk>
> ---
> accel/kvm/kvm-cpus.h | 3 +
> gdbstub/internals.h | 16 +++++
> include/sysemu/accel-ops.h | 6 ++
> include/sysemu/cpus.h | 3 +
> include/sysemu/kvm.h | 5 --
> accel/kvm/kvm-accel-ops.c | 8 +++
> accel/kvm/kvm-all.c | 24 +------
> accel/stubs/kvm-stub.c | 16 -----
> accel/tcg/tcg-accel-ops.c | 92 +++++++++++++++++++++++++++
> gdbstub/gdbstub.c | 127 +++----------------------------------
> gdbstub/softmmu.c | 42 ++++++++++++
> gdbstub/user.c | 62 ++++++++++++++++++
> softmmu/cpus.c | 7 ++
> gdbstub/meson.build | 8 +++
> 14 files changed, 259 insertions(+), 160 deletions(-)
> create mode 100644 gdbstub/internals.h
> create mode 100644 gdbstub/softmmu.c
> create mode 100644 gdbstub/user.c
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
next prev parent reply other threads:[~2022-09-25 10:23 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-22 14:58 [PATCH v1 0/9] MemTxAttrs cpu_index and gdbstub/next Alex Bennée
2022-09-22 14:58 ` [PATCH v1 1/9] hw: encode accessing CPU index in MemTxAttrs Alex Bennée
2022-09-25 10:08 ` Richard Henderson
2022-09-25 13:02 ` Alex Bennée
2022-09-26 7:33 ` Richard Henderson
2022-09-22 14:58 ` [PATCH v1 2/9] qtest: make read/write operation appear to be from CPU Alex Bennée
2022-09-22 14:58 ` [PATCH v1 3/9] hw/intc/gic: use MxTxAttrs to divine accessing CPU Alex Bennée
2022-09-25 10:11 ` Richard Henderson
2022-09-26 10:56 ` mads
2022-09-26 11:01 ` Alex Bennée
2022-09-26 11:20 ` mads
2022-09-22 14:58 ` [PATCH v1 4/9] hw/timer: convert mptimer access to attrs to derive cpu index Alex Bennée
2022-09-25 10:11 ` Richard Henderson
2022-09-22 14:58 ` [PATCH v1 5/9] configure: move detected gdb to TCG's config-host.mak Alex Bennée
2022-09-25 10:11 ` Richard Henderson
2022-09-22 14:58 ` [PATCH v1 6/9] gdbstub: move into its own sub directory Alex Bennée
2022-09-25 10:13 ` Richard Henderson
2022-09-22 14:58 ` [PATCH v1 7/9] gdbstub: move sstep flags probing into AccelClass Alex Bennée
2022-09-22 21:49 ` Philippe Mathieu-Daudé via
2022-09-25 10:14 ` Richard Henderson
2022-09-22 14:58 ` [PATCH v1 8/9] gdbstub: move breakpoint logic to accel ops Alex Bennée
2022-09-25 10:18 ` Richard Henderson [this message]
2022-09-22 14:58 ` [PATCH v1 9/9] gdbstub: move guest debug support check to ops Alex Bennée
2022-09-22 21:51 ` Philippe Mathieu-Daudé via
2022-09-25 10:18 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b4066f96-8cf1-e301-5167-f256d4a3a35e@linaro.org \
--to=richard.henderson@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=f4bug@amsat.org \
--cc=kvm@vger.kernel.org \
--cc=mads@ynddal.dk \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).