qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Richard Henderson <richard.henderson@linaro.org>
To: "Emilio Cota" <cota@braap.org>,
	"Alex Bennée" <alex.bennee@linaro.org>,
	"Daniel P. Berrangé" <berrange@redhat.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [PATCH v2 0/2] fix for #285
Date: Tue, 21 Mar 2023 10:55:41 -0700	[thread overview]
Message-ID: <b4b65760-c967-0fff-bb51-8e7173faec2f@linaro.org> (raw)
In-Reply-To: <ZBcY+WL+65D7Zi5F@cota-l14>

On 3/19/23 07:15, Emilio Cota wrote:
> Ping. Any feedback on these two patches?
> 
> https://patchew.org/QEMU/20230205163758.416992-1-cota@braap.org/
> https://lore.kernel.org/qemu-devel/20230205163758.416992-1-cota@braap.org/

Queued to tcg-next.


r~

> 
> Happy to resend if needed.
> 
> Thanks,
> 		Emilio
> 
> 
> On Fri, Feb 17, 2023 at 07:44:38 -0500, Emilio Cota wrote:
>> Ping.
>>
>> This fixes a bug (admittedly with a big hammer) that affects
>> users with heavily multi-threaded user-mode workloads.
>>
>> Thanks,
>> 		Emilio
>>
>> On Sun, Feb 05, 2023 at 11:37:56 -0500, Emilio Cota wrote:
>>> Changes since v1:
>>>
>>> - Add configure check to only use QTree if Glib still implements gslice.
>>>    If Glib doesn't, then we call Glib directly with inline functions.
>>> - Add TODO's so that in the future (i.e. when the minimum version of
>>>    Glib that we use doesn't implement gslice) we remove QTree.
>>> - Add comment to the top of qtree.h.
>>> - Make qtree-bench results more robust by running longer or more times.
>>> - Drop deprecated API calls (they're unused in QEMU).
>>> - Drop API calls that are too recent (they're unused in QEMU).
>>> - Drop macro benchmark results from the TCG patch since they're too noisy.
>>> - Add test program to the commit log so that we don't lose it in the future
>>>    even if the bug tracker goes away.
>>>
>>> Thanks,
>>> 		Emilio
>>>
>>>



      parent reply	other threads:[~2023-03-21 17:56 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-05 16:37 [PATCH v2 0/2] fix for #285 Emilio Cota
2023-02-05 16:37 ` [PATCH v2 1/2] util: import GTree as QTree Emilio Cota
2023-02-05 16:37 ` [PATCH v2 2/2] tcg: use QTree instead of GTree Emilio Cota
2023-03-21 16:23   ` Philippe Mathieu-Daudé
2023-02-17 12:44 ` [PATCH v2 0/2] fix for #285 Emilio Cota
2023-03-19 14:15   ` Emilio Cota
2023-03-20 15:05     ` Philippe Mathieu-Daudé
2023-03-20 15:35       ` Daniel P. Berrangé
2023-03-21 17:55     ` Richard Henderson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b4b65760-c967-0fff-bb51-8e7173faec2f@linaro.org \
    --to=richard.henderson@linaro.org \
    --cc=alex.bennee@linaro.org \
    --cc=berrange@redhat.com \
    --cc=cota@braap.org \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).