From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3AA43C433F5 for ; Thu, 11 Nov 2021 14:26:34 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E01466117A for ; Thu, 11 Nov 2021 14:26:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org E01466117A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:42766 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mlB28-0003as-U5 for qemu-devel@archiver.kernel.org; Thu, 11 Nov 2021 09:26:32 -0500 Received: from eggs.gnu.org ([209.51.188.92]:40960) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mlAsl-0003Sc-SC for qemu-devel@nongnu.org; Thu, 11 Nov 2021 09:16:51 -0500 Received: from [2a00:1450:4864:20::42a] (port=45967 helo=mail-wr1-x42a.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mlAsj-0006kx-9M for qemu-devel@nongnu.org; Thu, 11 Nov 2021 09:16:50 -0500 Received: by mail-wr1-x42a.google.com with SMTP id w29so10020946wra.12 for ; Thu, 11 Nov 2021 06:16:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=YfHVyEB68vNscGi6JjU9NGgL1Ud9paGUEUfcsooGgTI=; b=lIwJscutmuBFvjpbv8EpGZAzOBHfqLouIr5SFHkH3E54VQNVF48c+heTwzC/6I5hdz GtsMI4CsTmZ2JkrIxRYD5pfM1g0REV4XOfoMA/neza4IDaTUeKcNqEwr7vlupkD8EI6r Az8Xc1txg08f9a1p5odw7iv/aj50XZXwsxmO5TIhPeIY2lT6qjpekVXrYrJOvltlqaMv o/SU1LgekUg9WF99DDPik9WAkOdu1pbMX/ICMToBYrVif+ckVHUVyJWsbGWGbYob7s+T a9c38NQUmjTYIrQwsj4KvlAITBQvty4uCRIB/7Jm6gyJRUx13NJbNEPnTDIYnKeyRcy9 GRJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=YfHVyEB68vNscGi6JjU9NGgL1Ud9paGUEUfcsooGgTI=; b=7H+wAizIy7g8sVWh7CzaMgtH9txliRv/SnJm+hB8t9H/ueYiEuWBcLHKPTsYpmy26L d3moys6bJIo9cm5Wp4NlAj4JNhso5JWSWi7Vg6Gb7oYtqDzbCjwKIzZF+ge4eBVdT2K2 iVv3YGCZ6kuv1nteTPWu2LYxBb+hLqL7DGhBWiKudXNG5EMIwmv7xRSA356jzjJXjFFU bxacYP4UQrk//ZTExiD3ZESpOn/2svsBGY0iE1JilS7TRtygDXe57zAq2rp3spjeK/fk Lrir3m4kgn3+adkZuswZCvkAyg5ZmWoLSwbH57E7G4WkdGpDBm3V6JjAqZAHUQzDvazc tgsA== X-Gm-Message-State: AOAM5311jBM+JqGuG6Czw6vZIMOlro53/Jq8LY2OVQlr93RVas+RUT4s 42cAOcnvgIzHdHZWN+WbjQqKXw== X-Google-Smtp-Source: ABdhPJxYCs7dAk9f+xFPYwVl2JxA6aUdaXrCBHAujhsouBpk2QsWBswK0XfMTy7VWlNDJj5ZWW3QXA== X-Received: by 2002:a5d:4e52:: with SMTP id r18mr8609309wrt.224.1636640207485; Thu, 11 Nov 2021 06:16:47 -0800 (PST) Received: from [192.168.8.106] (10.red-95-125-227.dynamicip.rima-tde.net. [95.125.227.10]) by smtp.gmail.com with ESMTPSA id o4sm3866852wry.80.2021.11.11.06.16.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 11 Nov 2021 06:16:46 -0800 (PST) Subject: Re: [PATCH-for-6.2 v3 1/6] tests/unit/test-smp-parse: Restore MachineClass fields after modifying To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-devel@nongnu.org References: <20211111100351.2153662-1-philmd@redhat.com> <20211111100351.2153662-2-philmd@redhat.com> From: Richard Henderson Message-ID: Date: Thu, 11 Nov 2021 15:16:40 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20211111100351.2153662-2-philmd@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a00:1450:4864:20::42a (failed) Received-SPF: pass client-ip=2a00:1450:4864:20::42a; envelope-from=richard.henderson@linaro.org; helo=mail-wr1-x42a.google.com X-Spam_score_int: -52 X-Spam_score: -5.3 X-Spam_bar: ----- X-Spam_report: (-5.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-3.999, PDS_HP_HELO_NORDNS=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Yanan Wang , Markus Armbruster , Thomas Huth , Andrew Jones , Eduardo Habkost Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 11/11/21 11:03 AM, Philippe Mathieu-Daudé wrote: > There is a single MachineClass object, registered with > type_register_static(&smp_machine_info). Since the same > object is used multiple times (an MachineState object > is instantiated in both test_generic and test_with_dies), > we should restore its internal state after modifying for > the test purpose. > > Signed-off-by: Philippe Mathieu-Daudé > --- > tests/unit/test-smp-parse.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) Reviewed-by: Richard Henderson r~