[PATCH 0/7] hw/sparc/leon3: Few fixes and disable HelenOS test

[PATCH 0/7] hw/sparc/leon3: Few fixes and disable HelenOS test

[Philippe Mathieu-Daudé]

The Leon3Machine.test_leon3_helenos_uimage has been running
erratically since some time now. Time to disable it (at least
until we make it reliable).
Few other patches added while tracking the issue.

Philippe Mathieu-Daudé (7):
  tests/acceptance/machine_sparc_leon3: Disable HelenOS test
  hw/misc/grlib_ahb_apb_pnp: Avoid crash when writing to AHB PnP
    registers
  hw/misc/grlib_ahb_apb_pnp: Fix AHB PnP 8-bit accesses
  hw/misc/grlib_ahb_apb_pnp: Add trace events on read accesses
  hw/timer/grlib_gptimer: Display frequency in decimal
  target/sparc/int32_helper: Remove DEBUG_PCALL definition
  target/sparc/int32_helper: Extract and use excp_name_str()

 hw/misc/grlib_ahb_apb_pnp.c             | 24 ++++++++++++++++++++++--
 target/sparc/int32_helper.c             | 23 ++++++++++++-----------
 hw/misc/trace-events                    |  4 ++++
 hw/timer/trace-events                   |  2 +-
 tests/acceptance/machine_sparc_leon3.py |  4 ++++
 5 files changed, 43 insertions(+), 14 deletions(-)

-- 
2.21.1

[PATCH-for-5.0 1/7] tests/acceptance/machine_sparc_leon3: Disable HelenOS test

[Philippe Mathieu-Daudé]

This test was written/tested around beginning of 2019, but was
extracted from a bigger series and posted end of June 2019 [*].
Unfortunately I did not notice commit 162abf1a8 was merged by
then, which implements the AHB and APB plug and play devices.

HelenOS 0.6 is expecting the PnP registers to be not implemented
by QEMU, then forces the discovered AMBA devices (see [2]).

Before 162abf1a8, the console was displaying:

  HelenOS bootloader, release 0.6.0 (Elastic Horse)
  Built on 2014-12-21 20:17:42 for sparc32
  Copyright (c) 2001-2014 HelenOS project
   0x4000bf20|0x4000bf20: kernel image (496640/128466 bytes)
   0x4002b4f2|0x4002b4f2: ns image (154195/66444 bytes)
   0x4003b87e|0x4003b87e: loader image (153182/66437 bytes)
   0x4004bc03|0x4004bc03: init image (155339/66834 bytes)
   0x4005c115|0x4005c115: locsrv image (162063/70267 bytes)
   0x4006d390|0x4006d390: rd image (152678/65889 bytes)
   0x4007d4f1|0x4007d4f1: vfs image (168480/73394 bytes)
   0x4008f3a3|0x4008f3a3: logger image (158034/68368 bytes)
   0x4009feb3|0x4009feb3: ext4fs image (234510/100301 bytes)
   0x400b8680|0x400b8680: initrd image (8388608/1668901 bytes)
  ABMA devices:
  <1:00c> at 0x80000100 irq 3
  <1:00d> at 0x80000200
  <1:011> at 0x80000300 irq 8
  Memory size: 64 MB

As of this commit, it is now confused:

  ABMA devices:
  <1:3000> at 0x00000000 irq 0
  <1:3000> at 0x00000000 irq 0
  <1:3000> at 0x00000000 irq 0
  <1:3000> at 0x00000000 irq 0
  <1:3000> at 0x00000000 irq 0
  <1:3000> at 0x00000000 irq 0
  <1:3000> at 0x00000000 irq 0
  ...

As this test is not working as expected, simply disable it (by
skipping it) for now.

[1] https://www.mail-archive.com/qemu-devel@nongnu.org/msg627094.html
[2] https://github.com/HelenOS/helenos/blob/0.6.0/boot/arch/sparc32/src/ambapp.c#L75

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
 tests/acceptance/machine_sparc_leon3.py | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/tests/acceptance/machine_sparc_leon3.py b/tests/acceptance/machine_sparc_leon3.py
index f77e210ccb..2405cd7a0d 100644
--- a/tests/acceptance/machine_sparc_leon3.py
+++ b/tests/acceptance/machine_sparc_leon3.py
@@ -7,12 +7,16 @@
 
 from avocado_qemu import Test
 from avocado_qemu import wait_for_console_pattern
+from avocado import skip
 
 
 class Leon3Machine(Test):
 
     timeout = 60
 
+    @skip("Test currently broken")
+    # A Window Underflow exception occurs before booting the kernel,
+    # and QEMU exit calling cpu_abort(), which makes this test to fail.
     def test_leon3_helenos_uimage(self):
         """
         :avocado: tags=arch:sparc
-- 
2.21.1

Re: [PATCH-for-5.0 1/7] tests/acceptance/machine_sparc_leon3: Disable HelenOS test

[Richard Henderson]

On 3/31/20 3:50 AM, Philippe Mathieu-Daudé wrote:
> This test was written/tested around beginning of 2019, but was
> extracted from a bigger series and posted end of June 2019 [*].
> Unfortunately I did not notice commit 162abf1a8 was merged by
> then, which implements the AHB and APB plug and play devices.
> 
> HelenOS 0.6 is expecting the PnP registers to be not implemented
> by QEMU, then forces the discovered AMBA devices (see [2]).
> 
> Before 162abf1a8, the console was displaying:
> 
>   HelenOS bootloader, release 0.6.0 (Elastic Horse)
>   Built on 2014-12-21 20:17:42 for sparc32
>   Copyright (c) 2001-2014 HelenOS project
>    0x4000bf20|0x4000bf20: kernel image (496640/128466 bytes)
>    0x4002b4f2|0x4002b4f2: ns image (154195/66444 bytes)
>    0x4003b87e|0x4003b87e: loader image (153182/66437 bytes)
>    0x4004bc03|0x4004bc03: init image (155339/66834 bytes)
>    0x4005c115|0x4005c115: locsrv image (162063/70267 bytes)
>    0x4006d390|0x4006d390: rd image (152678/65889 bytes)
>    0x4007d4f1|0x4007d4f1: vfs image (168480/73394 bytes)
>    0x4008f3a3|0x4008f3a3: logger image (158034/68368 bytes)
>    0x4009feb3|0x4009feb3: ext4fs image (234510/100301 bytes)
>    0x400b8680|0x400b8680: initrd image (8388608/1668901 bytes)
>   ABMA devices:
>   <1:00c> at 0x80000100 irq 3
>   <1:00d> at 0x80000200
>   <1:011> at 0x80000300 irq 8
>   Memory size: 64 MB
> 
> As of this commit, it is now confused:
> 
>   ABMA devices:
>   <1:3000> at 0x00000000 irq 0
>   <1:3000> at 0x00000000 irq 0
>   <1:3000> at 0x00000000 irq 0
>   <1:3000> at 0x00000000 irq 0
>   <1:3000> at 0x00000000 irq 0
>   <1:3000> at 0x00000000 irq 0
>   <1:3000> at 0x00000000 irq 0
>   ...
> 
> As this test is not working as expected, simply disable it (by
> skipping it) for now.
> 
> [1] https://www.mail-archive.com/qemu-devel@nongnu.org/msg627094.html
> [2] https://github.com/HelenOS/helenos/blob/0.6.0/boot/arch/sparc32/src/ambapp.c#L75
> 
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
>  tests/acceptance/machine_sparc_leon3.py | 4 ++++
>  1 file changed, 4 insertions(+)

Thanks!

Reviewed-by: Richard Henderson <richard.hendersion@linaro.org>
Tested-by: Richard Henderson <richard.hendersion@linaro.org>


r~

Re: [PATCH-for-5.0 1/7] tests/acceptance/machine_sparc_leon3: Disable HelenOS test

[Philippe Mathieu-Daudé]

Cc'ing Avocado team

On 3/31/20 6:18 PM, Richard Henderson wrote:
> On 3/31/20 3:50 AM, Philippe Mathieu-Daudé wrote:
>> This test was written/tested around beginning of 2019, but was
>> extracted from a bigger series and posted end of June 2019 [*].
>> Unfortunately I did not notice commit 162abf1a8 was merged by
>> then, which implements the AHB and APB plug and play devices.
>>
>> HelenOS 0.6 is expecting the PnP registers to be not implemented
>> by QEMU, then forces the discovered AMBA devices (see [2]).
>>
>> Before 162abf1a8, the console was displaying:
>>
>>    HelenOS bootloader, release 0.6.0 (Elastic Horse)
>>    Built on 2014-12-21 20:17:42 for sparc32
>>    Copyright (c) 2001-2014 HelenOS project
>>     0x4000bf20|0x4000bf20: kernel image (496640/128466 bytes)
>>     0x4002b4f2|0x4002b4f2: ns image (154195/66444 bytes)
>>     0x4003b87e|0x4003b87e: loader image (153182/66437 bytes)
>>     0x4004bc03|0x4004bc03: init image (155339/66834 bytes)
>>     0x4005c115|0x4005c115: locsrv image (162063/70267 bytes)
>>     0x4006d390|0x4006d390: rd image (152678/65889 bytes)
>>     0x4007d4f1|0x4007d4f1: vfs image (168480/73394 bytes)
>>     0x4008f3a3|0x4008f3a3: logger image (158034/68368 bytes)
>>     0x4009feb3|0x4009feb3: ext4fs image (234510/100301 bytes)
>>     0x400b8680|0x400b8680: initrd image (8388608/1668901 bytes)
>>    ABMA devices:
>>    <1:00c> at 0x80000100 irq 3
>>    <1:00d> at 0x80000200
>>    <1:011> at 0x80000300 irq 8
>>    Memory size: 64 MB
>>
>> As of this commit, it is now confused:
>>
>>    ABMA devices:
>>    <1:3000> at 0x00000000 irq 0
>>    <1:3000> at 0x00000000 irq 0
>>    <1:3000> at 0x00000000 irq 0
>>    <1:3000> at 0x00000000 irq 0
>>    <1:3000> at 0x00000000 irq 0
>>    <1:3000> at 0x00000000 irq 0
>>    <1:3000> at 0x00000000 irq 0
>>    ...
>>
>> As this test is not working as expected, simply disable it (by
>> skipping it) for now.
>>
>> [1] https://www.mail-archive.com/qemu-devel@nongnu.org/msg627094.html
>> [2] https://github.com/HelenOS/helenos/blob/0.6.0/boot/arch/sparc32/src/ambapp.c#L75
>>
>> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>> ---
>>   tests/acceptance/machine_sparc_leon3.py | 4 ++++
>>   1 file changed, 4 insertions(+)
> 
> Thanks!
> 
> Reviewed-by: Richard Henderson <richard.hendersion@linaro.org>
> Tested-by: Richard Henderson <richard.hendersion@linaro.org>

Thanks!

First job failed by timeout, 2nd succeeded:
https://travis-ci.org/github/philmd/qemu/jobs/669265466

However "Ran for 46 min 48 sec"

 From the log:

Fetching asset from 
tests/acceptance/boot_linux_console.py:BootLinuxConsole.test_mips64el_malta_5KEc_cpio
Fetching asset from 
tests/acceptance/boot_linux_console.py:BootLinuxConsole.test_mips64el_malta_5KEc_cpio
Fetching asset from 
tests/acceptance/boot_linux_console.py:BootLinuxConsole.test_arm_orangepi
Fetching asset from 
tests/acceptance/boot_linux_console.py:BootLinuxConsole.test_arm_orangepi_initrd
Fetching asset from 
tests/acceptance/boot_linux_console.py:BootLinuxConsole.test_arm_orangepi_initrd
Fetching asset from 
tests/acceptance/boot_linux_console.py:BootLinuxConsole.test_arm_orangepi_sd
Fetching asset from 
tests/acceptance/boot_linux_console.py:BootLinuxConsole.test_arm_orangepi_sd
Fetching asset from 
tests/acceptance/boot_linux_console.py:BootLinuxConsole.test_arm_orangepi_bionic
Fetching asset from 
tests/acceptance/boot_linux_console.py:BootLinuxConsole.test_arm_orangepi_uboot_netbsd9
Fetching asset from 
tests/acceptance/boot_linux_console.py:BootLinuxConsole.test_arm_orangepi_uboot_netbsd9
Fetching asset from 
tests/acceptance/ppc_prep_40p.py:IbmPrep40pMachine.test_openbios_and_netbsd
...
  (13/82) 
tests/acceptance/boot_linux_console.py:BootLinuxConsole.test_mips64el_malta_5KEc_cpio: 
  SKIP: untrusted code
  (24/82) 
tests/acceptance/boot_linux_console.py:BootLinuxConsole.test_arm_orangepi_bionic: 
  SKIP: storage limited
...
  (25/82) 
tests/acceptance/boot_linux_console.py:BootLinuxConsole.test_arm_orangepi_uboot_netbsd9: 
  SKIP: storage limited
...
  (63/82) 
tests/acceptance/ppc_prep_40p.py:IbmPrep40pMachine.test_openbios_and_netbsd: 
  SKIP: Running on Travis-CI

Is it possible that we are now fetching assets for tests we are not 
running? In particular the one marked @skip because the downloading time 
was too long on Travis?

RESULTS    : PASS 65 | ERROR 0 | FAIL 0 | SKIP 14 | WARN 0 | INTERRUPT 0 
| CANCEL 3
JOB TIME   : 1480.72 s

Does this "JOB TIME" sums the 'Fetching asset' part?

Thanks,

Phil.

Re: [PATCH-for-5.0 1/7] tests/acceptance/machine_sparc_leon3: Disable HelenOS test

[Willian Rampazzo]

On Tue, Mar 31, 2020 at 5:07 PM Philippe Mathieu-Daudé
<philmd@redhat.com> wrote:
<snip>
>
> First job failed by timeout, 2nd succeeded:
> https://travis-ci.org/github/philmd/qemu/jobs/669265466
>
> However "Ran for 46 min 48 sec"
>
>  From the log:
>
> Fetching asset from
> tests/acceptance/boot_linux_console.py:BootLinuxConsole.test_mips64el_malta_5KEc_cpio
> Fetching asset from
> tests/acceptance/boot_linux_console.py:BootLinuxConsole.test_mips64el_malta_5KEc_cpio
> Fetching asset from
> tests/acceptance/boot_linux_console.py:BootLinuxConsole.test_arm_orangepi
> Fetching asset from
> tests/acceptance/boot_linux_console.py:BootLinuxConsole.test_arm_orangepi_initrd
> Fetching asset from
> tests/acceptance/boot_linux_console.py:BootLinuxConsole.test_arm_orangepi_initrd
> Fetching asset from
> tests/acceptance/boot_linux_console.py:BootLinuxConsole.test_arm_orangepi_sd
> Fetching asset from
> tests/acceptance/boot_linux_console.py:BootLinuxConsole.test_arm_orangepi_sd
> Fetching asset from
> tests/acceptance/boot_linux_console.py:BootLinuxConsole.test_arm_orangepi_bionic
> Fetching asset from
> tests/acceptance/boot_linux_console.py:BootLinuxConsole.test_arm_orangepi_uboot_netbsd9
> Fetching asset from
> tests/acceptance/boot_linux_console.py:BootLinuxConsole.test_arm_orangepi_uboot_netbsd9
> Fetching asset from
> tests/acceptance/ppc_prep_40p.py:IbmPrep40pMachine.test_openbios_and_netbsd
> ...
>   (13/82)
> tests/acceptance/boot_linux_console.py:BootLinuxConsole.test_mips64el_malta_5KEc_cpio:
>   SKIP: untrusted code
>   (24/82)
> tests/acceptance/boot_linux_console.py:BootLinuxConsole.test_arm_orangepi_bionic:
>   SKIP: storage limited
> ...
>   (25/82)
> tests/acceptance/boot_linux_console.py:BootLinuxConsole.test_arm_orangepi_uboot_netbsd9:
>   SKIP: storage limited
> ...
>   (63/82)
> tests/acceptance/ppc_prep_40p.py:IbmPrep40pMachine.test_openbios_and_netbsd:
>   SKIP: Running on Travis-CI
>
> Is it possible that we are now fetching assets for tests we are not
> running? In particular the one marked @skip because the downloading time
> was too long on Travis?

Yes, your assumption is correct, this execution of Avocado downloaded
assets for tests that were skipped. Let me try to explain how the
asset feature works today on Avocado.

Avocado has two basic ways to work with assets:

1. Parse limited use cases of `fetch_asset` call in the test file and
execute them. This operation can happen in two different scenarios.
First, when using the command line `avocado assets fetch <test_file>`.
In this case, it is a standalone execution of each fetch call and the
test is not executed at all. Second, by running the test. The, enabled
by default, plugin FetchAssetJob will do the same operation of parsing
the test file and executing occurrences of `fetch_asset` call before
the tests start to run. Again, the fetch time is not computed in the
job time.

2. Execute the `fetch_asset` call from each test during the test
execution. In this case, the FetchAssetJob plugin should be disabled.
The fetch time is added to the job time as the asset download occurs
during the test execution.

The acceptance tests which make use of `fetch_asset` are all using the
first method with FetchAssetJob plugin enabled. As Avocado is parsing
the test file before it starts to run the tests, it is not aware of
possible skips that may occur during a test execution due to possible
dynamic dependency.

This is not the desired behavior, as you mentioned, Avocado is
downloading an asset that will not be used because its test will be
skipped. To minimize the damage on the download side, the Travis job
is holding the avocado cache. It means the download should happen just
once. This does not minimize the damage to space usage.

One possible workaround here is to temporarily disable the
FetchAssetJob plugin, now that the needed assets are on Travis Avocado
cache. The downside is that when an asset is not available in the
cache, it will be downloaded during the test execution and the
download time will be added to the job time. I don't know if it is
possible to manually remove an asset from Travis Avocado cache. If so,
this can be done for the tests that should be skipped because of space
usage.

We have been trying to make the Asset feature as flexible as possible
to accommodate the use cases we have been identifying. Thanks for
reporting this!

>
> RESULTS    : PASS 65 | ERROR 0 | FAIL 0 | SKIP 14 | WARN 0 | INTERRUPT 0
> | CANCEL 3
> JOB TIME   : 1480.72 s
>
> Does this "JOB TIME" sums the 'Fetching asset' part?

Answered in the comments above.

>
> Thanks,
>
> Phil.
>

Willian

Re: [PATCH-for-5.0 1/7] tests/acceptance/machine_sparc_leon3: Disable HelenOS test

[Philippe Mathieu-Daudé]

On 4/1/20 7:43 PM, Willian Rampazzo wrote:
> On Tue, Mar 31, 2020 at 5:07 PM Philippe Mathieu-Daudé
> <philmd@redhat.com> wrote:
> <snip>
>>
>> First job failed by timeout, 2nd succeeded:
>> https://travis-ci.org/github/philmd/qemu/jobs/669265466
>>
>> However "Ran for 46 min 48 sec"
>>
>>   From the log:
>>
>> Fetching asset from
>> tests/acceptance/boot_linux_console.py:BootLinuxConsole.test_mips64el_malta_5KEc_cpio
>> Fetching asset from
>> tests/acceptance/boot_linux_console.py:BootLinuxConsole.test_mips64el_malta_5KEc_cpio
>> Fetching asset from
>> tests/acceptance/boot_linux_console.py:BootLinuxConsole.test_arm_orangepi
>> Fetching asset from
>> tests/acceptance/boot_linux_console.py:BootLinuxConsole.test_arm_orangepi_initrd
>> Fetching asset from
>> tests/acceptance/boot_linux_console.py:BootLinuxConsole.test_arm_orangepi_initrd
>> Fetching asset from
>> tests/acceptance/boot_linux_console.py:BootLinuxConsole.test_arm_orangepi_sd
>> Fetching asset from
>> tests/acceptance/boot_linux_console.py:BootLinuxConsole.test_arm_orangepi_sd
>> Fetching asset from
>> tests/acceptance/boot_linux_console.py:BootLinuxConsole.test_arm_orangepi_bionic
>> Fetching asset from
>> tests/acceptance/boot_linux_console.py:BootLinuxConsole.test_arm_orangepi_uboot_netbsd9
>> Fetching asset from
>> tests/acceptance/boot_linux_console.py:BootLinuxConsole.test_arm_orangepi_uboot_netbsd9
>> Fetching asset from
>> tests/acceptance/ppc_prep_40p.py:IbmPrep40pMachine.test_openbios_and_netbsd
>> ...
>>    (13/82)
>> tests/acceptance/boot_linux_console.py:BootLinuxConsole.test_mips64el_malta_5KEc_cpio:
>>    SKIP: untrusted code
>>    (24/82)
>> tests/acceptance/boot_linux_console.py:BootLinuxConsole.test_arm_orangepi_bionic:
>>    SKIP: storage limited
>> ...
>>    (25/82)
>> tests/acceptance/boot_linux_console.py:BootLinuxConsole.test_arm_orangepi_uboot_netbsd9:
>>    SKIP: storage limited
>> ...
>>    (63/82)
>> tests/acceptance/ppc_prep_40p.py:IbmPrep40pMachine.test_openbios_and_netbsd:
>>    SKIP: Running on Travis-CI
>>
>> Is it possible that we are now fetching assets for tests we are not
>> running? In particular the one marked @skip because the downloading time
>> was too long on Travis?
> 
> Yes, your assumption is correct, this execution of Avocado downloaded
> assets for tests that were skipped. Let me try to explain how the
> asset feature works today on Avocado.
> 
> Avocado has two basic ways to work with assets:
> 
> 1. Parse limited use cases of `fetch_asset` call in the test file and
> execute them. This operation can happen in two different scenarios.
> First, when using the command line `avocado assets fetch <test_file>`.

Odd, with avocado-framework==76.0 I get:

https://travis-ci.org/github/philmd/qemu/jobs/669851870#L4908

Traceback (most recent call last):
   File "/usr/lib/python3.6/runpy.py", line 193, in _run_module_as_main
     "__main__", mod_spec)
   File "/usr/lib/python3.6/runpy.py", line 85, in _run_code
     exec(code, run_globals)
   File 
"/home/travis/build/philmd/qemu/build/tests/venv/lib/python3.6zsite-packages/avocado/__main__.py", 
line 11, in <module>
     sys.exit(main.run())
   File 
"/home/travis/build/philmd/qemu/build/tests/venv/lib/python3.6/site-packages/avocado/core/app.py", 
line 91, in run
     return method(self.parser.config)
   File 
"/home/travis/build/philmd/qemu/build/tests/venv/lib/python3.6/site-packages/avocado/plugins/assets.py", 
line 291, in run
     success, fail = fetch_assets(test_file)
   File 
"/home/travis/build/philmd/qemu/build/tests/venv/lib/python3.6/site-packages/avocado/plugins/assets.py", 
line 200, in fetch_assets
     handler = FetchAssetHandler(test_file, klass, method)
   File 
"/home/travis/build/philmd/qemu/build/tests/venv/lib/python3.6/site-packages/avocado/plugins/assets.py", 
line 65, in __init__
     self.visit(self.tree)
   File "/usr/lib/python3.6/ast.py", line 253, in visit
     return visitor(node)
   File "/usr/lib/python3.6/ast.py", line 261, in generic_visit
     self.visit(item)
   File "/usr/lib/python3.6/ast.py", line 253, in visit
     return visitor(node)
   File 
"/home/travis/build/philmd/qemu/build/tests/venv/lib/python3.6/site-packages/avocado/plugins/assets.py", 
line 139, in visit_ClassDef
     self.generic_visit(node)
   File "/usr/lib/python3.6/ast.py", line 261, in generic_visit
     self.visit(item)
   File "/usr/lib/python3.6/ast.py", line 253, in visit
     return visitor(node)
   File 
"/home/travis/build/philmd/qemu/build/tests/venv/lib/python3.6/site-packages/avocado/plugins/assets.py", 
line 171, in visit_Assign
     self.asgmts[cur_klass][cur_method][name] = node.value.s
KeyError: 'launch_and_wait'
/home/travis/build/philmd/qemu/tests/Makefile.include:910: recipe for 
target 'fetch-acceptance-assets' failed

This launch_and_wait comes from:

tests/acceptance/boot_linux.py:88:    def launch_and_wait(self):

> In this case, it is a standalone execution of each fetch call and the
> test is not executed at all. Second, by running the test. The, enabled
> by default, plugin FetchAssetJob will do the same operation of parsing
> the test file and executing occurrences of `fetch_asset` call before
> the tests start to run. Again, the fetch time is not computed in the
> job time.
> 
> 2. Execute the `fetch_asset` call from each test during the test
> execution. In this case, the FetchAssetJob plugin should be disabled.
> The fetch time is added to the job time as the asset download occurs
> during the test execution.
> 
> The acceptance tests which make use of `fetch_asset` are all using the
> first method with FetchAssetJob plugin enabled. As Avocado is parsing
> the test file before it starts to run the tests, it is not aware of
> possible skips that may occur during a test execution due to possible
> dynamic dependency.
> 
> This is not the desired behavior, as you mentioned, Avocado is
> downloading an asset that will not be used because its test will be
> skipped. To minimize the damage on the download side, the Travis job
> is holding the avocado cache. It means the download should happen just
> once. This does not minimize the damage to space usage.
> 
> One possible workaround here is to temporarily disable the
> FetchAssetJob plugin, now that the needed assets are on Travis Avocado
> cache. The downside is that when an asset is not available in the
> cache, it will be downloaded during the test execution and the
> download time will be added to the job time. I don't know if it is
> possible to manually remove an asset from Travis Avocado cache. If so,
> this can be done for the tests that should be skipped because of space
> usage.
> 
> We have been trying to make the Asset feature as flexible as possible
> to accommodate the use cases we have been identifying. Thanks for
> reporting this!
> 
>>
>> RESULTS    : PASS 65 | ERROR 0 | FAIL 0 | SKIP 14 | WARN 0 | INTERRUPT 0
>> | CANCEL 3
>> JOB TIME   : 1480.72 s
>>
>> Does this "JOB TIME" sums the 'Fetching asset' part?
> 
> Answered in the comments above.

Thanks for the big clear explanation :)

Phil.

Re: [PATCH-for-5.0 1/7] tests/acceptance/machine_sparc_leon3: Disable HelenOS test

[Willian Rampazzo]

On Wed, Apr 1, 2020 at 5:21 PM Philippe Mathieu-Daudé <philmd@redhat.com> wrote:
 <snip>
> Odd, with avocado-framework==76.0 I get:
>
> https://travis-ci.org/github/philmd/qemu/jobs/669851870#L4908
>
> Traceback (most recent call last):
>    File "/usr/lib/python3.6/runpy.py", line 193, in _run_module_as_main
>      "__main__", mod_spec)
>    File "/usr/lib/python3.6/runpy.py", line 85, in _run_code
>      exec(code, run_globals)
>    File
> "/home/travis/build/philmd/qemu/build/tests/venv/lib/python3.6zsite-packages/avocado/__main__.py",
> line 11, in <module>
>      sys.exit(main.run())
>    File
> "/home/travis/build/philmd/qemu/build/tests/venv/lib/python3.6/site-packages/avocado/core/app.py",
> line 91, in run
>      return method(self.parser.config)
>    File
> "/home/travis/build/philmd/qemu/build/tests/venv/lib/python3.6/site-packages/avocado/plugins/assets.py",
> line 291, in run
>      success, fail = fetch_assets(test_file)
>    File
> "/home/travis/build/philmd/qemu/build/tests/venv/lib/python3.6/site-packages/avocado/plugins/assets.py",
> line 200, in fetch_assets
>      handler = FetchAssetHandler(test_file, klass, method)
>    File
> "/home/travis/build/philmd/qemu/build/tests/venv/lib/python3.6/site-packages/avocado/plugins/assets.py",
> line 65, in __init__
>      self.visit(self.tree)
>    File "/usr/lib/python3.6/ast.py", line 253, in visit
>      return visitor(node)
>    File "/usr/lib/python3.6/ast.py", line 261, in generic_visit
>      self.visit(item)
>    File "/usr/lib/python3.6/ast.py", line 253, in visit
>      return visitor(node)
>    File
> "/home/travis/build/philmd/qemu/build/tests/venv/lib/python3.6/site-packages/avocado/plugins/assets.py",
> line 139, in visit_ClassDef
>      self.generic_visit(node)
>    File "/usr/lib/python3.6/ast.py", line 261, in generic_visit
>      self.visit(item)
>    File "/usr/lib/python3.6/ast.py", line 253, in visit
>      return visitor(node)
>    File
> "/home/travis/build/philmd/qemu/build/tests/venv/lib/python3.6/site-packages/avocado/plugins/assets.py",
> line 171, in visit_Assign
>      self.asgmts[cur_klass][cur_method][name] = node.value.s
> KeyError: 'launch_and_wait'
> /home/travis/build/philmd/qemu/tests/Makefile.include:910: recipe for
> target 'fetch-acceptance-assets' failed
>
> This launch_and_wait comes from:
>
> tests/acceptance/boot_linux.py:88:    def launch_and_wait(self):

Sorry about that. This is a known bug, see
https://github.com/avocado-framework/avocado/issues/3661. It is fixed
upstream and will be available in the next release of Avocado.

Willian

Re: [PATCH-for-5.0 1/7] tests/acceptance/machine_sparc_leon3: Disable HelenOS test

[Philippe Mathieu-Daudé]

On 4/1/20 10:30 PM, Willian Rampazzo wrote:
> On Wed, Apr 1, 2020 at 5:21 PM Philippe Mathieu-Daudé <philmd@redhat.com> wrote:
>   <snip>
>> Odd, with avocado-framework==76.0 I get:
>>
>> https://travis-ci.org/github/philmd/qemu/jobs/669851870#L4908
>>
>> Traceback (most recent call last):
>>     File "/usr/lib/python3.6/runpy.py", line 193, in _run_module_as_main
>>       "__main__", mod_spec)
>>     File "/usr/lib/python3.6/runpy.py", line 85, in _run_code
>>       exec(code, run_globals)
>>     File
>> "/home/travis/build/philmd/qemu/build/tests/venv/lib/python3.6zsite-packages/avocado/__main__.py",
>> line 11, in <module>
>>       sys.exit(main.run())
>>     File
>> "/home/travis/build/philmd/qemu/build/tests/venv/lib/python3.6/site-packages/avocado/core/app.py",
>> line 91, in run
>>       return method(self.parser.config)
>>     File
>> "/home/travis/build/philmd/qemu/build/tests/venv/lib/python3.6/site-packages/avocado/plugins/assets.py",
>> line 291, in run
>>       success, fail = fetch_assets(test_file)
>>     File
>> "/home/travis/build/philmd/qemu/build/tests/venv/lib/python3.6/site-packages/avocado/plugins/assets.py",
>> line 200, in fetch_assets
>>       handler = FetchAssetHandler(test_file, klass, method)
>>     File
>> "/home/travis/build/philmd/qemu/build/tests/venv/lib/python3.6/site-packages/avocado/plugins/assets.py",
>> line 65, in __init__
>>       self.visit(self.tree)
>>     File "/usr/lib/python3.6/ast.py", line 253, in visit
>>       return visitor(node)
>>     File "/usr/lib/python3.6/ast.py", line 261, in generic_visit
>>       self.visit(item)
>>     File "/usr/lib/python3.6/ast.py", line 253, in visit
>>       return visitor(node)
>>     File
>> "/home/travis/build/philmd/qemu/build/tests/venv/lib/python3.6/site-packages/avocado/plugins/assets.py",
>> line 139, in visit_ClassDef
>>       self.generic_visit(node)
>>     File "/usr/lib/python3.6/ast.py", line 261, in generic_visit
>>       self.visit(item)
>>     File "/usr/lib/python3.6/ast.py", line 253, in visit
>>       return visitor(node)
>>     File
>> "/home/travis/build/philmd/qemu/build/tests/venv/lib/python3.6/site-packages/avocado/plugins/assets.py",
>> line 171, in visit_Assign
>>       self.asgmts[cur_klass][cur_method][name] = node.value.s
>> KeyError: 'launch_and_wait'
>> /home/travis/build/philmd/qemu/tests/Makefile.include:910: recipe for
>> target 'fetch-acceptance-assets' failed
>>
>> This launch_and_wait comes from:
>>
>> tests/acceptance/boot_linux.py:88:    def launch_and_wait(self):
> 
> Sorry about that. This is a known bug, see
> https://github.com/avocado-framework/avocado/issues/3661. It is fixed
> upstream and will be available in the next release of Avocado.

Thanks for the quick reply :)

I'm now using this kludge to include your bugfix:

-- >8 --
diff --git a/tests/requirements.txt b/tests/requirements.txt
index f9c84b4ba1..d625b32dbb 100644
--- a/tests/requirements.txt
+++ b/tests/requirements.txt
@@ -1,5 +1,5 @@
  # Add Python module requirements, one per line, to be installed
  # in the tests/venv Python virtual environment. For more info,
  # refer to: https://pip.pypa.io/en/stable/user_guide/#id1
-avocado-framework==76.0
+-e 
git+https://github.com/avocado-framework/avocado.git@f9b4dc7c58a6424eb8d0ed6781a1d76ae3a5ab06#egg=avocado-framework
  pycdlib==1.9.0
---

But I'm getting another error:

https://travis-ci.org/github/philmd/qemu/builds/669898682#L1702

...
avocado.test: Asset not in cache, fetching it.
avocado.test: Fetching 
ftp://ftp.boulder.ibm.com/rs6000/firmware/7020-40p/P12H0456.IMG -> 
/home/travis/avocado/data/cache/by_location/9234e55550fdde347e2a4604c133fa2c8d9e9291/P12H0456.IMG.dp3lw27q
avocado.test: FileNotFoundError: [Errno 2] No such file or directory: 
'/home/travis/avocado/data/cache/by_location/9234e55550fdde347e2a4604c133fa2c8d9e9291/P12H0456.IMG.dp3lw27q'
Failed to fetch P12H0456.IMG.
/home/travis/build/philmd/qemu/tests/Makefile.include:910: recipe for 
target 'fetch-acceptance-assets' failed
make: *** [fetch-acceptance-assets] Error 4

I don't understand because all the other directories are created, I'm 
not sure what is missing here, any idea?

(test branch is https://github.com/philmd/qemu/commits/travis_fetch_avocado)

Thanks,

Phil.

Re: [PATCH-for-5.0 1/7] tests/acceptance/machine_sparc_leon3: Disable HelenOS test

[Philippe Mathieu-Daudé]

On 4/2/20 12:01 AM, Philippe Mathieu-Daudé wrote:
> 
> I'm now using this kludge to include your bugfix:
> 
> -- >8 --
> diff --git a/tests/requirements.txt b/tests/requirements.txt
> index f9c84b4ba1..d625b32dbb 100644
> --- a/tests/requirements.txt
> +++ b/tests/requirements.txt
> @@ -1,5 +1,5 @@
>   # Add Python module requirements, one per line, to be installed
>   # in the tests/venv Python virtual environment. For more info,
>   # refer to: https://pip.pypa.io/en/stable/user_guide/#id1
> -avocado-framework==76.0
> +-e 
> git+https://github.com/avocado-framework/avocado.git@f9b4dc7c58a6424eb8d0ed6781a1d76ae3a5ab06#egg=avocado-framework 
> 
>   pycdlib==1.9.0
> ---
> 
> But I'm getting another error:
> 
> https://travis-ci.org/github/philmd/qemu/builds/669898682#L1702
> 
> ...
> avocado.test: Asset not in cache, fetching it.
> avocado.test: Fetching 
> ftp://ftp.boulder.ibm.com/rs6000/firmware/7020-40p/P12H0456.IMG -> 
> /home/travis/avocado/data/cache/by_location/9234e55550fdde347e2a4604c133fa2c8d9e9291/P12H0456.IMG.dp3lw27q 
> 
> avocado.test: FileNotFoundError: [Errno 2] No such file or directory: 
> '/home/travis/avocado/data/cache/by_location/9234e55550fdde347e2a4604c133fa2c8d9e9291/P12H0456.IMG.dp3lw27q' 
> 
> Failed to fetch P12H0456.IMG.
> /home/travis/build/philmd/qemu/tests/Makefile.include:910: recipe for 
> target 'fetch-acceptance-assets' failed
> make: *** [fetch-acceptance-assets] Error 4
> 
> I don't understand because all the other directories are created, I'm 
> not sure what is missing here, any idea?
> 
> (test branch is 
> https://github.com/philmd/qemu/commits/travis_fetch_avocado)

This issue persists, OTOH the good news is caching is working:

https://travis-ci.org/github/philmd/qemu/builds/670078763#L1626

Re: [PATCH-for-5.0 1/7] tests/acceptance/machine_sparc_leon3: Disable HelenOS test

[Willian Rampazzo]

On Thu, Apr 2, 2020 at 8:08 AM Philippe Mathieu-Daudé <philmd@redhat.com> wrote:
>
> This issue persists, OTOH the good news is caching is working:
>
> https://travis-ci.org/github/philmd/qemu/builds/670078763#L1626
>

Philippe, do you have a way to clean up the Travis cache and try it
again? Last week, when I was investigating the previous problem you
reported, I had the same issue as you are having now. The problem just
disappeared without any action. I could not reproduce the problem now
on an empty cache using the same command you used. I suspect the
previous bug left some inconsistencies in the cache.

[wrampazz@wrampazz qemu.philippe]$ avocado --config ../avocado.conf
assets fetch tests/acceptance/*.py
Fetching assets from tests/acceptance/boot_linux_console.py.
  File https://archives.fedoraproject.org/pub/archive/fedora/linux/releases/29/Everything/x86_64/os/images/pxeboot/vmlinuz
fetched or already on cache.
  File http://snapshot.debian.org/archive/debian/20130217T032700Z/pool/main/l/linux-2.6/linux-image-2.6.32-5-4kc-malta_2.6.32-48_mips.deb
fetched or already on cache.
  File http://snapshot.debian.org/archive/debian/20130217T032700Z/pool/main/l/linux-2.6/linux-image-2.6.32-5-5kc-malta_2.6.32-48_mipsel.deb
fetched or already on cache.
  File http://snapshot.debian.org/archive/debian/20160601T041800Z/pool/main/l/linux/linux-image-4.5.0-2-4kc-malta_4.5.5-1_mips.deb
fetched or already on cache.
  File https://github.com/groeck/linux-build-test/raw/8584a59ed9e5eb5ee7ca91f6d74bbb06619205b8/rootfs/mips/rootfs.cpio.gz
fetched or already on cache.
  File https://github.com/philmd/qemu-testing-blob/raw/9ad2df38/mips/malta/mips64el/vmlinux-3.19.3.mtoman.20150408
fetched or already on cache.
  File https://github.com/groeck/linux-build-test/raw/8584a59e/rootfs/mipsel64/rootfs.mipsel64r1.cpio.gz
fetched or already on cache.
  File https://archives.fedoraproject.org/pub/archive/fedora/linux/releases/29/Everything/aarch64/os/images/pxeboot/vmlinuz
fetched or already on cache.
  File https://archives.fedoraproject.org/pub/archive/fedora/linux/releases/29/Everything/armhfp/os/images/pxeboot/vmlinuz
fetched or already on cache.
  File https://raw.githubusercontent.com/Subbaraya-Sundeep/qemu-test-binaries/fa030bd77a014a0b8e360d3b7011df89283a2f0b/u-boot
fetched or already on cache.
  File https://raw.githubusercontent.com/Subbaraya-Sundeep/qemu-test-binaries/fa030bd77a014a0b8e360d3b7011df89283a2f0b/spi.bin
fetched or already on cache.
  File http://archive.raspberrypi.org/debian/pool/main/r/raspberrypi-firmware/raspberrypi-kernel_1.20190215-1_armhf.deb
fetched or already on cache.
  File https://snapshot.debian.org/archive/debian/20190928T224601Z/pool/main/l/linux/linux-image-4.19.0-6-armmp_4.19.67-2+deb10u1_armhf.deb
fetched or already on cache.
  File https://github.com/groeck/linux-build-test/raw/2eb0a73b5d5a28df3170c546ddaaa9757e1e0848/rootfs/arm/rootfs-armv5.cpio.gz
fetched or already on cache.
  File https://apt.armbian.com/pool/main/l/linux-4.20.7-sunxi/linux-image-dev-sunxi_5.75_armhf.deb
fetched or already on cache.
  File https://github.com/groeck/linux-build-test/raw/2eb0a73b5d5a28df3170c546ddaaa9757e1e0848/rootfs/arm/rootfs-armv5.cpio.gz
fetched or already on cache.
  File https://apt.armbian.com/pool/main/l/linux-4.20.7-sunxi/linux-image-dev-sunxi_5.75_armhf.deb
fetched or already on cache.
  File https://github.com/groeck/linux-build-test/raw/2eb0a73b5d5a28df3170c546ddaaa9757e1e0848/rootfs/arm/rootfs-armv5.ext2.gz
fetched or already on cache.
  File https://apt.armbian.com/pool/main/l/linux-4.20.7-sunxi/linux-image-dev-sunxi_5.75_armhf.deb
fetched or already on cache.
  File https://apt.armbian.com/pool/main/l/linux-4.20.7-sunxi/linux-image-dev-sunxi_5.75_armhf.deb
fetched or already on cache.
  File https://github.com/groeck/linux-build-test/raw/2eb0a73b5d5a28df3170c546ddaaa9757e1e0848/rootfs/arm/rootfs-armv7a.cpio.gz
fetched or already on cache.
  File https://apt.armbian.com/pool/main/l/linux-4.20.7-sunxi/linux-image-dev-sunxi_5.75_armhf.deb
fetched or already on cache.
  File http://storage.kernelci.org/images/rootfs/buildroot/kci-2019.02/armel/base/rootfs.ext2.xz
fetched or already on cache.
  File https://dl.armbian.com/orangepipc/archive/Armbian_19.11.3_Orangepipc_bionic_current_5.3.9.7z
fetched or already on cache.
  File http://snapshot.debian.org/archive/debian/20200108T145233Z/pool/main/u/u-boot/u-boot-sunxi_2020.01%2Bdfsg-1_armhf.deb
fetched or already on cache.
  File https://cdn.netbsd.org/pub/NetBSD/NetBSD-9.0/evbarm-earmv7hf/binary/gzimg/armv7.img.gz
fetched or already on cache.
  File https://archives.fedoraproject.org/pub/archive/fedora-secondary/releases/29/Everything/s390x/os/images/kernel.img
fetched or already on cache.
  File http://archive.debian.org/debian/dists/lenny/main/installer-alpha/current/images/cdrom/vmlinuz
fetched or already on cache.
  File https://archives.fedoraproject.org/pub/archive/fedora-secondary/releases/29/Everything/ppc64le/os/ppc/ppc64/vmlinuz
fetched or already on cache.
  File https://snapshot.debian.org/archive/debian-ports/20191021T083923Z/pool-m68k/main/l/linux/kernel-image-5.3.0-1-m68k-di_5.3.7-1_m68k.udeb
fetched or already on cache.
Fetching assets from tests/acceptance/boot_linux.py.
Fetching assets from tests/acceptance/cpu_queries.py.
Fetching assets from tests/acceptance/empty_cpu_model.py.
Fetching assets from tests/acceptance/linux_initrd.py.
  File https://archives.fedoraproject.org/pub/archive/fedora/linux/releases/18/Fedora/x86_64/os/images/pxeboot/vmlinuz
fetched or already on cache.
  File https://archives.fedoraproject.org/pub/archive/fedora/linux/releases/28/Everything/x86_64/os/images/pxeboot/vmlinuz
fetched or already on cache.
Fetching assets from tests/acceptance/linux_ssh_mips_malta.py.
Fetching assets from tests/acceptance/machine_arm_integratorcp.py.
  File https://github.com/zayac/qemu-arm/raw/master/arm-test/kernel/zImage.integrator
fetched or already on cache.
  File https://github.com/zayac/qemu-arm/raw/master/arm-test/kernel/arm_root.img
fetched or already on cache.
  File https://github.com/torvalds/linux/raw/v2.6.12/drivers/video/logo/logo_linux_vga16.ppm
fetched or already on cache.
Fetching assets from tests/acceptance/machine_arm_n8x0.py.
  File http://stskeeps.subnetmask.net/meego-n8x0/meego-arm-n8x0-1.0.80.20100712.1431-vmlinuz-2.6.35~rc4-129.1-n8x0
fetched or already on cache.
Fetching assets from tests/acceptance/machine_m68k_nextcube.py.
  File http://www.nextcomputers.org/NeXTfiles/Software/ROM_Files/68040_Non-Turbo_Chipset/Rev_2.5_v66.BIN
fetched or already on cache.
Fetching assets from tests/acceptance/machine_mips_malta.py.
  File https://github.com/philmd/qemu-testing-blob/raw/a5966ca4b5/mips/malta/mips64el/vmlinux-4.7.0-rc1.I6400.gz
fetched or already on cache.
  File https://github.com/torvalds/linux/raw/v2.6.12/drivers/video/logo/logo_linux_vga16.ppm
fetched or already on cache.
Fetching assets from tests/acceptance/machine_sparc_leon3.py.
  File http://www.helenos.org/releases/HelenOS-0.6.0-sparc32-leon3.bin
fetched or already on cache.
Fetching assets from tests/acceptance/migration.py.
Fetching assets from tests/acceptance/pc_cpu_hotplug_props.py.
Fetching assets from tests/acceptance/ppc_prep_40p.py.
  File ftp://ftp.boulder.ibm.com/rs6000/firmware/7020-40p/P12H0456.IMG
fetched or already on cache.
  File https://ftp.netbsd.org/pub/NetBSD/NetBSD-archive/NetBSD-4.0/prep/installation/floppy/generic_com0.fs
fetched or already on cache.
  File https://ftp.netbsd.org/pub/NetBSD/iso/7.1.2/NetBSD-7.1.2-prep.iso
fetched or already on cache.
Fetching assets from tests/acceptance/version.py.
Fetching assets from tests/acceptance/virtio_check_params.py.
Fetching assets from tests/acceptance/virtio_version.py.
Fetching assets from tests/acceptance/vnc.py.
Fetching assets from tests/acceptance/x86_cpu_model_versions.py.
[wrampazz@wrampazz qemu.philippe]$

Re: [PATCH-for-5.0 1/7] tests/acceptance/machine_sparc_leon3: Disable HelenOS test

[Philippe Mathieu-Daudé]

On 4/2/20 3:25 PM, Willian Rampazzo wrote:
> On Thu, Apr 2, 2020 at 8:08 AM Philippe Mathieu-Daudé <philmd@redhat.com> wrote:
>>
>> This issue persists, OTOH the good news is caching is working:
>>
>> https://travis-ci.org/github/philmd/qemu/builds/670078763#L1626
>>
> 
> Philippe, do you have a way to clean up the Travis cache and try it
> again? Last week, when I was investigating the previous problem you
> reported, I had the same issue as you are having now. The problem just
> disappeared without any action. I could not reproduce the problem now
> on an empty cache using the same command you used. I suspect the
> previous bug left some inconsistencies in the cache.

I dropped the cache but it still failed, then I used travis_retry which 
succeeded:

https://travis-ci.org/github/philmd/qemu/jobs/670166259#L1711

avocado.test: Fetching 
https://ftp.netbsd.org/pub/NetBSD/iso/7.1.2/NetBSD-7.1.2-prep.iso -> 
/home/travis/avocado/data/cache/by_location/5fb821f368ac26c2d9eb044aef3eb70f5a956e92/NetBSD-7.1.2-prep.iso.hfxinpfu
Failed to fetch P12H0456.IMG.
/home/travis/build/philmd/qemu/tests/Makefile.include:910: recipe for 
target 'fetch-acceptance-assets' failed
make: *** [fetch-acceptance-assets] Error 4

The command "make fetch-acceptance-assets DEBUG=1" failed. Retrying, 2 of 3.

   AVOCADO tests/acceptance
avocado.test: Asset not in cache, fetching it.
avocado.test: Fetching 
ftp://ftp.boulder.ibm.com/rs6000/firmware/7020-40p/P12H0456.IMG -> 
/home/travis/avocado/data/cache/by_location/9234e55550fdde347e2a4604c133fa2c8d9e9291/P12H0456.IMG.4_uenut0
The command "${TEST_CMD}" exited with 0.

FYI as of v5.0.0-rc1 Avocado cache takes 1985.15MB.

> 
> [wrampazz@wrampazz qemu.philippe]$ avocado --config ../avocado.conf
> assets fetch tests/acceptance/*.py
> Fetching assets from tests/acceptance/boot_linux_console.py.
>    File https://archives.fedoraproject.org/pub/archive/fedora/linux/releases/29/Everything/x86_64/os/images/pxeboot/vmlinuz
> fetched or already on cache.
>    File http://snapshot.debian.org/archive/debian/20130217T032700Z/pool/main/l/linux-2.6/linux-image-2.6.32-5-4kc-malta_2.6.32-48_mips.deb
> fetched or already on cache.
>    File http://snapshot.debian.org/archive/debian/20130217T032700Z/pool/main/l/linux-2.6/linux-image-2.6.32-5-5kc-malta_2.6.32-48_mipsel.deb
> fetched or already on cache.
>    File http://snapshot.debian.org/archive/debian/20160601T041800Z/pool/main/l/linux/linux-image-4.5.0-2-4kc-malta_4.5.5-1_mips.deb
> fetched or already on cache.
>    File https://github.com/groeck/linux-build-test/raw/8584a59ed9e5eb5ee7ca91f6d74bbb06619205b8/rootfs/mips/rootfs.cpio.gz
> fetched or already on cache.
>    File https://github.com/philmd/qemu-testing-blob/raw/9ad2df38/mips/malta/mips64el/vmlinux-3.19.3.mtoman.20150408
> fetched or already on cache.
>    File https://github.com/groeck/linux-build-test/raw/8584a59e/rootfs/mipsel64/rootfs.mipsel64r1.cpio.gz
> fetched or already on cache.
>    File https://archives.fedoraproject.org/pub/archive/fedora/linux/releases/29/Everything/aarch64/os/images/pxeboot/vmlinuz
> fetched or already on cache.
>    File https://archives.fedoraproject.org/pub/archive/fedora/linux/releases/29/Everything/armhfp/os/images/pxeboot/vmlinuz
> fetched or already on cache.
>    File https://raw.githubusercontent.com/Subbaraya-Sundeep/qemu-test-binaries/fa030bd77a014a0b8e360d3b7011df89283a2f0b/u-boot
> fetched or already on cache.
>    File https://raw.githubusercontent.com/Subbaraya-Sundeep/qemu-test-binaries/fa030bd77a014a0b8e360d3b7011df89283a2f0b/spi.bin
> fetched or already on cache.
>    File http://archive.raspberrypi.org/debian/pool/main/r/raspberrypi-firmware/raspberrypi-kernel_1.20190215-1_armhf.deb
> fetched or already on cache.
>    File https://snapshot.debian.org/archive/debian/20190928T224601Z/pool/main/l/linux/linux-image-4.19.0-6-armmp_4.19.67-2+deb10u1_armhf.deb
> fetched or already on cache.
>    File https://github.com/groeck/linux-build-test/raw/2eb0a73b5d5a28df3170c546ddaaa9757e1e0848/rootfs/arm/rootfs-armv5.cpio.gz
> fetched or already on cache.
>    File https://apt.armbian.com/pool/main/l/linux-4.20.7-sunxi/linux-image-dev-sunxi_5.75_armhf.deb
> fetched or already on cache.
>    File https://github.com/groeck/linux-build-test/raw/2eb0a73b5d5a28df3170c546ddaaa9757e1e0848/rootfs/arm/rootfs-armv5.cpio.gz
> fetched or already on cache.
>    File https://apt.armbian.com/pool/main/l/linux-4.20.7-sunxi/linux-image-dev-sunxi_5.75_armhf.deb
> fetched or already on cache.
>    File https://github.com/groeck/linux-build-test/raw/2eb0a73b5d5a28df3170c546ddaaa9757e1e0848/rootfs/arm/rootfs-armv5.ext2.gz
> fetched or already on cache.
>    File https://apt.armbian.com/pool/main/l/linux-4.20.7-sunxi/linux-image-dev-sunxi_5.75_armhf.deb
> fetched or already on cache.
>    File https://apt.armbian.com/pool/main/l/linux-4.20.7-sunxi/linux-image-dev-sunxi_5.75_armhf.deb
> fetched or already on cache.
>    File https://github.com/groeck/linux-build-test/raw/2eb0a73b5d5a28df3170c546ddaaa9757e1e0848/rootfs/arm/rootfs-armv7a.cpio.gz
> fetched or already on cache.
>    File https://apt.armbian.com/pool/main/l/linux-4.20.7-sunxi/linux-image-dev-sunxi_5.75_armhf.deb
> fetched or already on cache.
>    File http://storage.kernelci.org/images/rootfs/buildroot/kci-2019.02/armel/base/rootfs.ext2.xz
> fetched or already on cache.
>    File https://dl.armbian.com/orangepipc/archive/Armbian_19.11.3_Orangepipc_bionic_current_5.3.9.7z
> fetched or already on cache.
>    File http://snapshot.debian.org/archive/debian/20200108T145233Z/pool/main/u/u-boot/u-boot-sunxi_2020.01%2Bdfsg-1_armhf.deb
> fetched or already on cache.
>    File https://cdn.netbsd.org/pub/NetBSD/NetBSD-9.0/evbarm-earmv7hf/binary/gzimg/armv7.img.gz
> fetched or already on cache.
>    File https://archives.fedoraproject.org/pub/archive/fedora-secondary/releases/29/Everything/s390x/os/images/kernel.img
> fetched or already on cache.
>    File http://archive.debian.org/debian/dists/lenny/main/installer-alpha/current/images/cdrom/vmlinuz
> fetched or already on cache.
>    File https://archives.fedoraproject.org/pub/archive/fedora-secondary/releases/29/Everything/ppc64le/os/ppc/ppc64/vmlinuz
> fetched or already on cache.
>    File https://snapshot.debian.org/archive/debian-ports/20191021T083923Z/pool-m68k/main/l/linux/kernel-image-5.3.0-1-m68k-di_5.3.7-1_m68k.udeb
> fetched or already on cache.
> Fetching assets from tests/acceptance/boot_linux.py.
> Fetching assets from tests/acceptance/cpu_queries.py.
> Fetching assets from tests/acceptance/empty_cpu_model.py.
> Fetching assets from tests/acceptance/linux_initrd.py.
>    File https://archives.fedoraproject.org/pub/archive/fedora/linux/releases/18/Fedora/x86_64/os/images/pxeboot/vmlinuz
> fetched or already on cache.
>    File https://archives.fedoraproject.org/pub/archive/fedora/linux/releases/28/Everything/x86_64/os/images/pxeboot/vmlinuz
> fetched or already on cache.
> Fetching assets from tests/acceptance/linux_ssh_mips_malta.py.
> Fetching assets from tests/acceptance/machine_arm_integratorcp.py.
>    File https://github.com/zayac/qemu-arm/raw/master/arm-test/kernel/zImage.integrator
> fetched or already on cache.
>    File https://github.com/zayac/qemu-arm/raw/master/arm-test/kernel/arm_root.img
> fetched or already on cache.
>    File https://github.com/torvalds/linux/raw/v2.6.12/drivers/video/logo/logo_linux_vga16.ppm
> fetched or already on cache.
> Fetching assets from tests/acceptance/machine_arm_n8x0.py.
>    File http://stskeeps.subnetmask.net/meego-n8x0/meego-arm-n8x0-1.0.80.20100712.1431-vmlinuz-2.6.35~rc4-129.1-n8x0
> fetched or already on cache.
> Fetching assets from tests/acceptance/machine_m68k_nextcube.py.
>    File http://www.nextcomputers.org/NeXTfiles/Software/ROM_Files/68040_Non-Turbo_Chipset/Rev_2.5_v66.BIN
> fetched or already on cache.
> Fetching assets from tests/acceptance/machine_mips_malta.py.
>    File https://github.com/philmd/qemu-testing-blob/raw/a5966ca4b5/mips/malta/mips64el/vmlinux-4.7.0-rc1.I6400.gz
> fetched or already on cache.
>    File https://github.com/torvalds/linux/raw/v2.6.12/drivers/video/logo/logo_linux_vga16.ppm
> fetched or already on cache.
> Fetching assets from tests/acceptance/machine_sparc_leon3.py.
>    File http://www.helenos.org/releases/HelenOS-0.6.0-sparc32-leon3.bin
> fetched or already on cache.
> Fetching assets from tests/acceptance/migration.py.
> Fetching assets from tests/acceptance/pc_cpu_hotplug_props.py.
> Fetching assets from tests/acceptance/ppc_prep_40p.py.
>    File ftp://ftp.boulder.ibm.com/rs6000/firmware/7020-40p/P12H0456.IMG
> fetched or already on cache.
>    File https://ftp.netbsd.org/pub/NetBSD/NetBSD-archive/NetBSD-4.0/prep/installation/floppy/generic_com0.fs
> fetched or already on cache.
>    File https://ftp.netbsd.org/pub/NetBSD/iso/7.1.2/NetBSD-7.1.2-prep.iso
> fetched or already on cache.
> Fetching assets from tests/acceptance/version.py.
> Fetching assets from tests/acceptance/virtio_check_params.py.
> Fetching assets from tests/acceptance/virtio_version.py.
> Fetching assets from tests/acceptance/vnc.py.
> Fetching assets from tests/acceptance/x86_cpu_model_versions.py.
> [wrampazz@wrampazz qemu.philippe]$
> 

Re: [PATCH-for-5.0 1/7] tests/acceptance/machine_sparc_leon3: Disable HelenOS test

[Philippe Mathieu-Daudé]

Hi Richard,

On 3/31/20 6:18 PM, Richard Henderson wrote:
> On 3/31/20 3:50 AM, Philippe Mathieu-Daudé wrote:
>> This test was written/tested around beginning of 2019, but was
>> extracted from a bigger series and posted end of June 2019 [*].
>> Unfortunately I did not notice commit 162abf1a8 was merged by
>> then, which implements the AHB and APB plug and play devices.
>>
[...]
> 
> Thanks!
> 
> Reviewed-by: Richard Henderson <richard.hendersion@linaro.org>
> Tested-by: Richard Henderson <richard.hendersion@linaro.org>

While queuing this I noticed a change in your email.

Since you replied to Alex patch later [*] with your usual email:
Richard Henderson <richard.henderson@linaro.org>
I think it was a typo, so I fixed it.

[*] https://www.mail-archive.com/qemu-devel@nongnu.org/msg694068.html

Regards,

Phil.

[PATCH-for-5.0 2/7] hw/misc/grlib_ahb_apb_pnp: Avoid crash when writing to AHB PnP registers

[Philippe Mathieu-Daudé]

Similarly to commit 158b659451 with the APB PnP registers, guests
can crash QEMU when writting to the AHB PnP registers:

  $ echo 'writeb 0xfffff042 69' | qemu-system-sparc -M leon3_generic -S -bios /etc/magic -qtest stdio
  [I 1571938309.932255] OPENED
  [R +0.063474] writeb 0xfffff042 69
  Segmentation fault (core dumped)

  (gdb) bt
  #0  0x0000000000000000 in  ()
  #1  0x0000562999110df4 in memory_region_write_with_attrs_accessor
      (mr=mr@entry=0x56299aa28ea0, addr=66, value=value@entry=0x7fff6abe13b8, size=size@entry=1, shift=<optimized out>, mask=mask@entry=255, attrs=...) at memory.c:503
  #2  0x000056299911095e in access_with_adjusted_size
      (addr=addr@entry=66, value=value@entry=0x7fff6abe13b8, size=size@entry=1, access_size_min=<optimized out>, access_size_max=<optimized out>, access_fn=access_fn@entry=
      0x562999110d70 <memory_region_write_with_attrs_accessor>, mr=0x56299aa28ea0, attrs=...) at memory.c:539
  #3  0x0000562999114fba in memory_region_dispatch_write (mr=mr@entry=0x56299aa28ea0, addr=66, data=<optimized out>, op=<optimized out>, attrs=attrs@entry=...) at memory.c:1482
  #4  0x00005629990c0860 in flatview_write_continue
      (fv=fv@entry=0x56299aa7d8a0, addr=addr@entry=4294963266, attrs=..., ptr=ptr@entry=0x7fff6abe1540, len=len@entry=1, addr1=<optimized out>, l=<optimized out>, mr=0x56299aa28ea0)
      at include/qemu/host-utils.h:164
  #5  0x00005629990c0a76 in flatview_write (fv=0x56299aa7d8a0, addr=4294963266, attrs=..., buf=0x7fff6abe1540, len=1) at exec.c:3165
  #6  0x00005629990c4c1b in address_space_write (as=<optimized out>, addr=<optimized out>, attrs=..., attrs@entry=..., buf=buf@entry=0x7fff6abe1540, len=len@entry=1) at exec.c:3256
  #7  0x000056299910f807 in qtest_process_command (chr=chr@entry=0x5629995ee920 <qtest_chr>, words=words@entry=0x56299acfcfa0) at qtest.c:437

Instead of crashing, log the access as unimplemented.

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
 hw/misc/grlib_ahb_apb_pnp.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/hw/misc/grlib_ahb_apb_pnp.c b/hw/misc/grlib_ahb_apb_pnp.c
index e230e25363..72a8764776 100644
--- a/hw/misc/grlib_ahb_apb_pnp.c
+++ b/hw/misc/grlib_ahb_apb_pnp.c
@@ -136,8 +136,15 @@ static uint64_t grlib_ahb_pnp_read(void *opaque, hwaddr offset, unsigned size)
     return ahb_pnp->regs[offset >> 2];
 }
 
+static void grlib_ahb_pnp_write(void *opaque, hwaddr addr,
+                                uint64_t val, unsigned size)
+{
+    qemu_log_mask(LOG_UNIMP, "%s not implemented\n", __func__);
+}
+
 static const MemoryRegionOps grlib_ahb_pnp_ops = {
     .read       = grlib_ahb_pnp_read,
+    .write      = grlib_ahb_pnp_write,
     .endianness = DEVICE_BIG_ENDIAN,
 };
 
-- 
2.21.1

Re: [PATCH-for-5.0 2/7] hw/misc/grlib_ahb_apb_pnp: Avoid crash when writing to AHB PnP registers

[KONRAD Frederic]

Le 3/31/20 à 12:50 PM, Philippe Mathieu-Daudé a écrit :
> Similarly to commit 158b659451 with the APB PnP registers, guests
> can crash QEMU when writting to the AHB PnP registers:
> 
>    $ echo 'writeb 0xfffff042 69' | qemu-system-sparc -M leon3_generic -S -bios /etc/magic -qtest stdio
>    [I 1571938309.932255] OPENED
>    [R +0.063474] writeb 0xfffff042 69
>    Segmentation fault (core dumped)
> 
>    (gdb) bt
>    #0  0x0000000000000000 in  ()
>    #1  0x0000562999110df4 in memory_region_write_with_attrs_accessor
>        (mr=mr@entry=0x56299aa28ea0, addr=66, value=value@entry=0x7fff6abe13b8, size=size@entry=1, shift=<optimized out>, mask=mask@entry=255, attrs=...) at memory.c:503
>    #2  0x000056299911095e in access_with_adjusted_size
>        (addr=addr@entry=66, value=value@entry=0x7fff6abe13b8, size=size@entry=1, access_size_min=<optimized out>, access_size_max=<optimized out>, access_fn=access_fn@entry=
>        0x562999110d70 <memory_region_write_with_attrs_accessor>, mr=0x56299aa28ea0, attrs=...) at memory.c:539
>    #3  0x0000562999114fba in memory_region_dispatch_write (mr=mr@entry=0x56299aa28ea0, addr=66, data=<optimized out>, op=<optimized out>, attrs=attrs@entry=...) at memory.c:1482
>    #4  0x00005629990c0860 in flatview_write_continue
>        (fv=fv@entry=0x56299aa7d8a0, addr=addr@entry=4294963266, attrs=..., ptr=ptr@entry=0x7fff6abe1540, len=len@entry=1, addr1=<optimized out>, l=<optimized out>, mr=0x56299aa28ea0)
>        at include/qemu/host-utils.h:164
>    #5  0x00005629990c0a76 in flatview_write (fv=0x56299aa7d8a0, addr=4294963266, attrs=..., buf=0x7fff6abe1540, len=1) at exec.c:3165
>    #6  0x00005629990c4c1b in address_space_write (as=<optimized out>, addr=<optimized out>, attrs=..., attrs@entry=..., buf=buf@entry=0x7fff6abe1540, len=len@entry=1) at exec.c:3256
>    #7  0x000056299910f807 in qtest_process_command (chr=chr@entry=0x5629995ee920 <qtest_chr>, words=words@entry=0x56299acfcfa0) at qtest.c:437
> 
> Instead of crashing, log the access as unimplemented.
> 
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
>   hw/misc/grlib_ahb_apb_pnp.c | 7 +++++++
>   1 file changed, 7 insertions(+)
> 
> diff --git a/hw/misc/grlib_ahb_apb_pnp.c b/hw/misc/grlib_ahb_apb_pnp.c
> index e230e25363..72a8764776 100644
> --- a/hw/misc/grlib_ahb_apb_pnp.c
> +++ b/hw/misc/grlib_ahb_apb_pnp.c
> @@ -136,8 +136,15 @@ static uint64_t grlib_ahb_pnp_read(void *opaque, hwaddr offset, unsigned size)
>       return ahb_pnp->regs[offset >> 2];
>   }
>   
> +static void grlib_ahb_pnp_write(void *opaque, hwaddr addr,
> +                                uint64_t val, unsigned size)
> +{
> +    qemu_log_mask(LOG_UNIMP, "%s not implemented\n", __func__);
> +}
> +
>   static const MemoryRegionOps grlib_ahb_pnp_ops = {
>       .read       = grlib_ahb_pnp_read,
> +    .write      = grlib_ahb_pnp_write,
>       .endianness = DEVICE_BIG_ENDIAN,
>   };
>   
> 

Reviewed-by: KONRAD Frederic <frederic.konrad@adacore.com>

[PATCH-for-5.0 3/7] hw/misc/grlib_ahb_apb_pnp: Fix AHB PnP 8-bit accesses

[Philippe Mathieu-Daudé]

The Plug & Play region of the AHB/APB bridge can be accessed
by various word size, however the implementation is clearly
restricted to 32-bit:

  static uint64_t grlib_ahb_pnp_read(void *opaque, hwaddr offset, unsigned size)
  {
      AHBPnp *ahb_pnp = GRLIB_AHB_PNP(opaque);

      return ahb_pnp->regs[offset >> 2];
  }

Similarly to commit 0fbe394a64 with the APB PnP registers,
set the MemoryRegionOps::impl min/max fields to 32-bit, so
memory.c::access_with_adjusted_size() can adjust when the
access is not 32-bit.

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
 hw/misc/grlib_ahb_apb_pnp.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/hw/misc/grlib_ahb_apb_pnp.c b/hw/misc/grlib_ahb_apb_pnp.c
index 72a8764776..d22ed00206 100644
--- a/hw/misc/grlib_ahb_apb_pnp.c
+++ b/hw/misc/grlib_ahb_apb_pnp.c
@@ -146,6 +146,10 @@ static const MemoryRegionOps grlib_ahb_pnp_ops = {
     .read       = grlib_ahb_pnp_read,
     .write      = grlib_ahb_pnp_write,
     .endianness = DEVICE_BIG_ENDIAN,
+    .impl = {
+        .min_access_size = 4,
+        .max_access_size = 4,
+    },
 };
 
 static void grlib_ahb_pnp_realize(DeviceState *dev, Error **errp)
-- 
2.21.1

Re: [PATCH-for-5.0 3/7] hw/misc/grlib_ahb_apb_pnp: Fix AHB PnP 8-bit accesses

[KONRAD Frederic]

Le 3/31/20 à 12:50 PM, Philippe Mathieu-Daudé a écrit :
> The Plug & Play region of the AHB/APB bridge can be accessed
> by various word size, however the implementation is clearly
> restricted to 32-bit:
> 
>    static uint64_t grlib_ahb_pnp_read(void *opaque, hwaddr offset, unsigned size)
>    {
>        AHBPnp *ahb_pnp = GRLIB_AHB_PNP(opaque);
> 
>        return ahb_pnp->regs[offset >> 2];
>    }
> 
> Similarly to commit 0fbe394a64 with the APB PnP registers,
> set the MemoryRegionOps::impl min/max fields to 32-bit, so
> memory.c::access_with_adjusted_size() can adjust when the
> access is not 32-bit.
> 
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
>   hw/misc/grlib_ahb_apb_pnp.c | 4 ++++
>   1 file changed, 4 insertions(+)
> 
> diff --git a/hw/misc/grlib_ahb_apb_pnp.c b/hw/misc/grlib_ahb_apb_pnp.c
> index 72a8764776..d22ed00206 100644
> --- a/hw/misc/grlib_ahb_apb_pnp.c
> +++ b/hw/misc/grlib_ahb_apb_pnp.c
> @@ -146,6 +146,10 @@ static const MemoryRegionOps grlib_ahb_pnp_ops = {
>       .read       = grlib_ahb_pnp_read,
>       .write      = grlib_ahb_pnp_write,
>       .endianness = DEVICE_BIG_ENDIAN,
> +    .impl = {
> +        .min_access_size = 4,
> +        .max_access_size = 4,
> +    },
>   };
>   
>   static void grlib_ahb_pnp_realize(DeviceState *dev, Error **errp)
> 

Reviewed-by: KONRAD Frederic <frederic.konrad@adacore.com>

[PATCH-for-5.1 4/7] hw/misc/grlib_ahb_apb_pnp: Add trace events on read accesses

[Philippe Mathieu-Daudé]

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
 hw/misc/grlib_ahb_apb_pnp.c | 13 +++++++++++--
 hw/misc/trace-events        |  4 ++++
 2 files changed, 15 insertions(+), 2 deletions(-)

diff --git a/hw/misc/grlib_ahb_apb_pnp.c b/hw/misc/grlib_ahb_apb_pnp.c
index d22ed00206..43e001c3c7 100644
--- a/hw/misc/grlib_ahb_apb_pnp.c
+++ b/hw/misc/grlib_ahb_apb_pnp.c
@@ -25,6 +25,7 @@
 #include "qemu/log.h"
 #include "hw/sysbus.h"
 #include "hw/misc/grlib_ahb_apb_pnp.h"
+#include "trace.h"
 
 #define GRLIB_PNP_VENDOR_SHIFT (24)
 #define GRLIB_PNP_VENDOR_SIZE   (8)
@@ -132,8 +133,12 @@ void grlib_ahb_pnp_add_entry(AHBPnp *dev, uint32_t address, uint32_t mask,
 static uint64_t grlib_ahb_pnp_read(void *opaque, hwaddr offset, unsigned size)
 {
     AHBPnp *ahb_pnp = GRLIB_AHB_PNP(opaque);
+    uint32_t val;
 
-    return ahb_pnp->regs[offset >> 2];
+    val = ahb_pnp->regs[offset >> 2];
+    trace_grlib_ahb_pnp_read(offset, val);
+
+    return val;
 }
 
 static void grlib_ahb_pnp_write(void *opaque, hwaddr addr,
@@ -239,8 +244,12 @@ void grlib_apb_pnp_add_entry(APBPnp *dev, uint32_t address, uint32_t mask,
 static uint64_t grlib_apb_pnp_read(void *opaque, hwaddr offset, unsigned size)
 {
     APBPnp *apb_pnp = GRLIB_APB_PNP(opaque);
+    uint32_t val;
 
-    return apb_pnp->regs[offset >> 2];
+    val = apb_pnp->regs[offset >> 2];
+    trace_grlib_apb_pnp_read(offset, val);
+
+    return val;
 }
 
 static void grlib_apb_pnp_write(void *opaque, hwaddr addr,
diff --git a/hw/misc/trace-events b/hw/misc/trace-events
index a5862b2bed..9387664823 100644
--- a/hw/misc/trace-events
+++ b/hw/misc/trace-events
@@ -198,3 +198,7 @@ via1_rtc_cmd_pram_read(int addr, int value) "addr=%u value=0x%02x"
 via1_rtc_cmd_pram_write(int addr, int value) "addr=%u value=0x%02x"
 via1_rtc_cmd_pram_sect_read(int sector, int offset, int addr, int value) "sector=%u offset=%u addr=%d value=0x%02x"
 via1_rtc_cmd_pram_sect_write(int sector, int offset, int addr, int value) "sector=%u offset=%u addr=%d value=0x%02x"
+
+# grlib_ahb_apb_pnp.c
+grlib_ahb_pnp_read(uint64_t addr, uint32_t value) "AHB PnP read addr:0x%03"PRIx64" data:0x%08x"
+grlib_apb_pnp_read(uint64_t addr, uint32_t value) "APB PnP read addr:0x%03"PRIx64" data:0x%08x"
-- 
2.21.1

Re: [PATCH-for-5.1 4/7] hw/misc/grlib_ahb_apb_pnp: Add trace events on read accesses

[KONRAD Frederic]

Le 3/31/20 à 12:50 PM, Philippe Mathieu-Daudé a écrit :
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
>   hw/misc/grlib_ahb_apb_pnp.c | 13 +++++++++++--
>   hw/misc/trace-events        |  4 ++++
>   2 files changed, 15 insertions(+), 2 deletions(-)
> 
> diff --git a/hw/misc/grlib_ahb_apb_pnp.c b/hw/misc/grlib_ahb_apb_pnp.c
> index d22ed00206..43e001c3c7 100644
> --- a/hw/misc/grlib_ahb_apb_pnp.c
> +++ b/hw/misc/grlib_ahb_apb_pnp.c
> @@ -25,6 +25,7 @@
>   #include "qemu/log.h"
>   #include "hw/sysbus.h"
>   #include "hw/misc/grlib_ahb_apb_pnp.h"
> +#include "trace.h"
>   
>   #define GRLIB_PNP_VENDOR_SHIFT (24)
>   #define GRLIB_PNP_VENDOR_SIZE   (8)
> @@ -132,8 +133,12 @@ void grlib_ahb_pnp_add_entry(AHBPnp *dev, uint32_t address, uint32_t mask,
>   static uint64_t grlib_ahb_pnp_read(void *opaque, hwaddr offset, unsigned size)
>   {
>       AHBPnp *ahb_pnp = GRLIB_AHB_PNP(opaque);
> +    uint32_t val;
>   
> -    return ahb_pnp->regs[offset >> 2];
> +    val = ahb_pnp->regs[offset >> 2];
> +    trace_grlib_ahb_pnp_read(offset, val);
> +
> +    return val;
>   }
>   
>   static void grlib_ahb_pnp_write(void *opaque, hwaddr addr,
> @@ -239,8 +244,12 @@ void grlib_apb_pnp_add_entry(APBPnp *dev, uint32_t address, uint32_t mask,
>   static uint64_t grlib_apb_pnp_read(void *opaque, hwaddr offset, unsigned size)
>   {
>       APBPnp *apb_pnp = GRLIB_APB_PNP(opaque);
> +    uint32_t val;
>   
> -    return apb_pnp->regs[offset >> 2];
> +    val = apb_pnp->regs[offset >> 2];
> +    trace_grlib_apb_pnp_read(offset, val);
> +
> +    return val;
>   }
>   
>   static void grlib_apb_pnp_write(void *opaque, hwaddr addr,
> diff --git a/hw/misc/trace-events b/hw/misc/trace-events
> index a5862b2bed..9387664823 100644
> --- a/hw/misc/trace-events
> +++ b/hw/misc/trace-events
> @@ -198,3 +198,7 @@ via1_rtc_cmd_pram_read(int addr, int value) "addr=%u value=0x%02x"
>   via1_rtc_cmd_pram_write(int addr, int value) "addr=%u value=0x%02x"
>   via1_rtc_cmd_pram_sect_read(int sector, int offset, int addr, int value) "sector=%u offset=%u addr=%d value=0x%02x"
>   via1_rtc_cmd_pram_sect_write(int sector, int offset, int addr, int value) "sector=%u offset=%u addr=%d value=0x%02x"
> +
> +# grlib_ahb_apb_pnp.c
> +grlib_ahb_pnp_read(uint64_t addr, uint32_t value) "AHB PnP read addr:0x%03"PRIx64" data:0x%08x"
> +grlib_apb_pnp_read(uint64_t addr, uint32_t value) "APB PnP read addr:0x%03"PRIx64" data:0x%08x"
> 

Reviewed-by: KONRAD Frederic <frederic.konrad@adacore.com>

[PATCH-for-5.1 5/7] hw/timer/grlib_gptimer: Display frequency in decimal

[Philippe Mathieu-Daudé]

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
 hw/timer/trace-events | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/timer/trace-events b/hw/timer/trace-events
index 29fda7870e..96a6c9138c 100644
--- a/hw/timer/trace-events
+++ b/hw/timer/trace-events
@@ -19,7 +19,7 @@ slavio_timer_mem_writel_invalid(uint64_t addr) "invalid write address 0x%"PRIx64
 grlib_gptimer_enable(int id, uint32_t count) "timer:%d set count 0x%x and run"
 grlib_gptimer_disabled(int id, uint32_t config) "timer:%d Timer disable config 0x%x"
 grlib_gptimer_restart(int id, uint32_t reload) "timer:%d reload val: 0x%x"
-grlib_gptimer_set_scaler(uint32_t scaler, uint32_t freq) "scaler:0x%x freq: 0x%x"
+grlib_gptimer_set_scaler(uint32_t scaler, uint32_t freq) "scaler:0x%x freq:%uHz"
 grlib_gptimer_hit(int id) "timer:%d HIT"
 grlib_gptimer_readl(int id, uint64_t addr, uint32_t val) "timer:%d addr 0x%"PRIx64" 0x%x"
 grlib_gptimer_writel(int id, uint64_t addr, uint32_t val) "timer:%d addr 0x%"PRIx64" 0x%x"
-- 
2.21.1

Re: [PATCH-for-5.1 5/7] hw/timer/grlib_gptimer: Display frequency in decimal

[KONRAD Frederic]

Le 3/31/20 à 12:50 PM, Philippe Mathieu-Daudé a écrit :
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
>   hw/timer/trace-events | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/timer/trace-events b/hw/timer/trace-events
> index 29fda7870e..96a6c9138c 100644
> --- a/hw/timer/trace-events
> +++ b/hw/timer/trace-events
> @@ -19,7 +19,7 @@ slavio_timer_mem_writel_invalid(uint64_t addr) "invalid write address 0x%"PRIx64
>   grlib_gptimer_enable(int id, uint32_t count) "timer:%d set count 0x%x and run"
>   grlib_gptimer_disabled(int id, uint32_t config) "timer:%d Timer disable config 0x%x"
>   grlib_gptimer_restart(int id, uint32_t reload) "timer:%d reload val: 0x%x"
> -grlib_gptimer_set_scaler(uint32_t scaler, uint32_t freq) "scaler:0x%x freq: 0x%x"
> +grlib_gptimer_set_scaler(uint32_t scaler, uint32_t freq) "scaler:0x%x freq:%uHz"
>   grlib_gptimer_hit(int id) "timer:%d HIT"
>   grlib_gptimer_readl(int id, uint64_t addr, uint32_t val) "timer:%d addr 0x%"PRIx64" 0x%x"
>   grlib_gptimer_writel(int id, uint64_t addr, uint32_t val) "timer:%d addr 0x%"PRIx64" 0x%x"
> 

Reviewed-by: KONRAD Frederic <frederic.konrad@adacore.com>

[PATCH-for-5.1 6/7] target/sparc/int32_helper: Remove DEBUG_PCALL definition

[Philippe Mathieu-Daudé]

We define DEBUG_PCALL since b884fc5e (2012-10-06).
7.5 years later it is safe to assume we can remove it :)

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
 target/sparc/int32_helper.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/target/sparc/int32_helper.c b/target/sparc/int32_helper.c
index 813b47dbb2..c56dd3df18 100644
--- a/target/sparc/int32_helper.c
+++ b/target/sparc/int32_helper.c
@@ -23,9 +23,7 @@
 #include "exec/log.h"
 #include "sysemu/runstate.h"
 
-#define DEBUG_PCALL
 
-#ifdef DEBUG_PCALL
 static const char * const excp_names[0x80] = {
     [TT_TFAULT] = "Instruction Access Fault",
     [TT_ILL_INSN] = "Illegal Instruction",
@@ -58,7 +56,6 @@ static const char * const excp_names[0x80] = {
     [TT_DIV_ZERO] = "Division By Zero",
     [TT_NCP_INSN] = "Coprocessor Disabled",
 };
-#endif
 
 void sparc_cpu_do_interrupt(CPUState *cs)
 {
@@ -71,7 +68,6 @@ void sparc_cpu_do_interrupt(CPUState *cs)
         cpu_get_psr(env);
     }
 
-#ifdef DEBUG_PCALL
     if (qemu_loglevel_mask(CPU_LOG_INT)) {
         static int count;
         const char *name;
@@ -104,7 +100,6 @@ void sparc_cpu_do_interrupt(CPUState *cs)
 #endif
         count++;
     }
-#endif
 #if !defined(CONFIG_USER_ONLY)
     if (env->psret == 0) {
         if (cs->exception_index == 0x80 &&
-- 
2.21.1

Re: [PATCH-for-5.1 6/7] target/sparc/int32_helper: Remove DEBUG_PCALL definition

[KONRAD Frederic]

Le 3/31/20 à 12:50 PM, Philippe Mathieu-Daudé a écrit :
> We define DEBUG_PCALL since b884fc5e (2012-10-06).
> 7.5 years later it is safe to assume we can remove it :)
> 
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
>   target/sparc/int32_helper.c | 5 -----
>   1 file changed, 5 deletions(-)
> 
> diff --git a/target/sparc/int32_helper.c b/target/sparc/int32_helper.c
> index 813b47dbb2..c56dd3df18 100644
> --- a/target/sparc/int32_helper.c
> +++ b/target/sparc/int32_helper.c
> @@ -23,9 +23,7 @@
>   #include "exec/log.h"
>   #include "sysemu/runstate.h"
>   
> -#define DEBUG_PCALL
>   
> -#ifdef DEBUG_PCALL
>   static const char * const excp_names[0x80] = {
>       [TT_TFAULT] = "Instruction Access Fault",
>       [TT_ILL_INSN] = "Illegal Instruction",
> @@ -58,7 +56,6 @@ static const char * const excp_names[0x80] = {
>       [TT_DIV_ZERO] = "Division By Zero",
>       [TT_NCP_INSN] = "Coprocessor Disabled",
>   };
> -#endif
>   
>   void sparc_cpu_do_interrupt(CPUState *cs)
>   {
> @@ -71,7 +68,6 @@ void sparc_cpu_do_interrupt(CPUState *cs)
>           cpu_get_psr(env);
>       }
>   
> -#ifdef DEBUG_PCALL
>       if (qemu_loglevel_mask(CPU_LOG_INT)) {
>           static int count;
>           const char *name;
> @@ -104,7 +100,6 @@ void sparc_cpu_do_interrupt(CPUState *cs)
>   #endif

I was wonderring what was this #endif above:

#if 0
         {
             int i;
             uint8_t *ptr;

             qemu_log("       code=");
             ptr = (uint8_t *)env->pc;
             for (i = 0; i < 16; i++) {
                 qemu_log(" %02x", ldub(ptr + i));
             }
             qemu_log("\n");
         }
#endif

Should we drop that as well?

>           count++;
>       }
> -#endif
>   #if !defined(CONFIG_USER_ONLY)
>       if (env->psret == 0) {
>           if (cs->exception_index == 0x80 &&
> 

In any case LGTM:

Reviewed-by: KONRAD Frederic <frederic.konrad@adacore.com>

[PATCH-for-5.1 7/7] target/sparc/int32_helper: Extract and use excp_name_str()

[Philippe Mathieu-Daudé]

Improve exception error report:

Before:

  qemu: fatal: Trap 0x06 while interrupts disabled, Error state

After:

  qemu: fatal: Trap 0x06 (Window Underflow) while interrupts disabled, Error state

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
 target/sparc/int32_helper.c | 18 ++++++++++++------
 1 file changed, 12 insertions(+), 6 deletions(-)

diff --git a/target/sparc/int32_helper.c b/target/sparc/int32_helper.c
index c56dd3df18..9a71e1abd8 100644
--- a/target/sparc/int32_helper.c
+++ b/target/sparc/int32_helper.c
@@ -57,6 +57,14 @@ static const char * const excp_names[0x80] = {
     [TT_NCP_INSN] = "Coprocessor Disabled",
 };
 
+static const char *excp_name_str(int32_t exception_index)
+{
+    if (exception_index < 0 || exception_index >= ARRAY_SIZE(excp_names)) {
+        return "Unknown";
+    }
+    return excp_names[exception_index];
+}
+
 void sparc_cpu_do_interrupt(CPUState *cs)
 {
     SPARCCPU *cpu = SPARC_CPU(cs);
@@ -77,10 +85,7 @@ void sparc_cpu_do_interrupt(CPUState *cs)
         } else if (intno >= 0x80) {
             name = "Trap Instruction";
         } else {
-            name = excp_names[intno];
-            if (!name) {
-                name = "Unknown";
-            }
+            name = excp_name_str(intno);
         }
 
         qemu_log("%6d: %s (v=%02x)\n", count, name, intno);
@@ -106,8 +111,9 @@ void sparc_cpu_do_interrupt(CPUState *cs)
             env->def.features & CPU_FEATURE_TA0_SHUTDOWN) {
             qemu_system_shutdown_request(SHUTDOWN_CAUSE_GUEST_SHUTDOWN);
         } else {
-            cpu_abort(cs, "Trap 0x%02x while interrupts disabled, Error state",
-                      cs->exception_index);
+            cpu_abort(cs, "Trap 0x%02x (%s) while interrupts disabled, "
+                          "Error state",
+                      cs->exception_index, excp_name_str(cs->exception_index));
         }
         return;
     }
-- 
2.21.1

Re: [PATCH-for-5.1 7/7] target/sparc/int32_helper: Extract and use excp_name_str()

[KONRAD Frederic]

Le 3/31/20 à 12:50 PM, Philippe Mathieu-Daudé a écrit :
> Improve exception error report:
> 
> Before:
> 
>    qemu: fatal: Trap 0x06 while interrupts disabled, Error state
> 
> After:
> 
>    qemu: fatal: Trap 0x06 (Window Underflow) while interrupts disabled, Error state
> 
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
>   target/sparc/int32_helper.c | 18 ++++++++++++------
>   1 file changed, 12 insertions(+), 6 deletions(-)
> 
> diff --git a/target/sparc/int32_helper.c b/target/sparc/int32_helper.c
> index c56dd3df18..9a71e1abd8 100644
> --- a/target/sparc/int32_helper.c
> +++ b/target/sparc/int32_helper.c
> @@ -57,6 +57,14 @@ static const char * const excp_names[0x80] = {
>       [TT_NCP_INSN] = "Coprocessor Disabled",
>   };
>   
> +static const char *excp_name_str(int32_t exception_index)
> +{
> +    if (exception_index < 0 || exception_index >= ARRAY_SIZE(excp_names)) {
> +        return "Unknown";
> +    }
> +    return excp_names[exception_index];
> +}
> +
>   void sparc_cpu_do_interrupt(CPUState *cs)
>   {
>       SPARCCPU *cpu = SPARC_CPU(cs);
> @@ -77,10 +85,7 @@ void sparc_cpu_do_interrupt(CPUState *cs)
>           } else if (intno >= 0x80) {
>               name = "Trap Instruction";
>           } else {
> -            name = excp_names[intno];
> -            if (!name) {
> -                name = "Unknown";
> -            }
> +            name = excp_name_str(intno);
>           }
>   
>           qemu_log("%6d: %s (v=%02x)\n", count, name, intno);
> @@ -106,8 +111,9 @@ void sparc_cpu_do_interrupt(CPUState *cs)
>               env->def.features & CPU_FEATURE_TA0_SHUTDOWN) {
>               qemu_system_shutdown_request(SHUTDOWN_CAUSE_GUEST_SHUTDOWN);
>           } else {
> -            cpu_abort(cs, "Trap 0x%02x while interrupts disabled, Error state",
> -                      cs->exception_index);
> +            cpu_abort(cs, "Trap 0x%02x (%s) while interrupts disabled, "
> +                          "Error state",
> +                      cs->exception_index, excp_name_str(cs->exception_index));
>           }
>           return;
>       }
> 

Reviewed-by: KONRAD Frederic <frederic.konrad@adacore.com>

Thanks,
Fred

Re: [PATCH 0/7] hw/sparc/leon3: Few fixes and disable HelenOS test

[Philippe Mathieu-Daudé]

On 3/31/20 12:50 PM, Philippe Mathieu-Daudé wrote:
> Philippe Mathieu-Daudé (7):
>   hw/misc/grlib_ahb_apb_pnp: Avoid crash when writing to AHB PnP
>     registers
>   hw/misc/grlib_ahb_apb_pnp: Fix AHB PnP 8-bit accesses

Ping ^^^ for 5.0?

>   hw/misc/grlib_ahb_apb_pnp: Add trace events on read accesses
>   hw/timer/grlib_gptimer: Display frequency in decimal
>   target/sparc/int32_helper: Remove DEBUG_PCALL definition
>   target/sparc/int32_helper: Extract and use excp_name_str()
> 
>  hw/misc/grlib_ahb_apb_pnp.c             | 24 ++++++++++++++++++++++--
>  target/sparc/int32_helper.c             | 23 ++++++++++++-----------
>  hw/misc/trace-events                    |  4 ++++
>  hw/timer/trace-events                   |  2 +-
>  tests/acceptance/machine_sparc_leon3.py |  4 ++++
>  5 files changed, 43 insertions(+), 14 deletions(-)
> 

Re: [PATCH 0/7] hw/sparc/leon3: Few fixes and disable HelenOS test

[KONRAD Frederic]

Le 4/11/20 à 7:30 PM, Philippe Mathieu-Daudé a écrit :
> On 3/31/20 12:50 PM, Philippe Mathieu-Daudé wrote:
>> Philippe Mathieu-Daudé (7):
>>    hw/misc/grlib_ahb_apb_pnp: Avoid crash when writing to AHB PnP
>>      registers
>>    hw/misc/grlib_ahb_apb_pnp: Fix AHB PnP 8-bit accesses
> 
> Ping ^^^ for 5.0?

Hi Philippe,

You already have my rb tag for those one, and IMHO they should be good candidate
for 5.0 (if it's not too late).

Cheers,
Fred

> 
>>    hw/misc/grlib_ahb_apb_pnp: Add trace events on read accesses
>>    hw/timer/grlib_gptimer: Display frequency in decimal
>>    target/sparc/int32_helper: Remove DEBUG_PCALL definition
>>    target/sparc/int32_helper: Extract and use excp_name_str()
>>
>>   hw/misc/grlib_ahb_apb_pnp.c             | 24 ++++++++++++++++++++++--
>>   target/sparc/int32_helper.c             | 23 ++++++++++++-----------
>>   hw/misc/trace-events                    |  4 ++++
>>   hw/timer/trace-events                   |  2 +-
>>   tests/acceptance/machine_sparc_leon3.py |  4 ++++
>>   5 files changed, 43 insertions(+), 14 deletions(-)
>>

Re: [PATCH 0/7] hw/sparc/leon3: Few fixes and disable HelenOS test

[Philippe Mathieu-Daudé]

[Cc'ing Peter]

On 4/13/20 12:12 PM, KONRAD Frederic wrote:
> Le 4/11/20 à 7:30 PM, Philippe Mathieu-Daudé a écrit :
>> On 3/31/20 12:50 PM, Philippe Mathieu-Daudé wrote:
>>> Philippe Mathieu-Daudé (7):
>>>    hw/misc/grlib_ahb_apb_pnp: Avoid crash when writing to AHB PnP
>>>      registers
>>>    hw/misc/grlib_ahb_apb_pnp: Fix AHB PnP 8-bit accesses
>>
>> Ping ^^^ for 5.0?
> 
> Hi Philippe,
> 
> You already have my rb tag for those one, and IMHO they should be good
> candidate
> for 5.0 (if it's not too late).

Yes, thanks for the reviews. I see Mark Cave-Ayland merged this file
first, but you are listed as maintainer :) I was hoping you could send a
pull request.

$ scripts/get_maintainer.pl -f hw/misc/grlib_ahb_apb_pnp.c
Fabien Chouteau <chouteau@adacore.com> (maintainer:Leon3)
KONRAD Frederic <frederic.konrad@adacore.com> (maintainer:Leon3)
qemu-devel@nongnu.org (open list:All patches CC here)

This is a bug but not 'security critical', so it might wait 5.1 and go
via qemu-trivial tree.

Regards,

Phil.

> 
> Cheers,
> Fred
> 
>>
>>>    hw/misc/grlib_ahb_apb_pnp: Add trace events on read accesses
>>>    hw/timer/grlib_gptimer: Display frequency in decimal
>>>    target/sparc/int32_helper: Remove DEBUG_PCALL definition
>>>    target/sparc/int32_helper: Extract and use excp_name_str()
>>>
>>>   hw/misc/grlib_ahb_apb_pnp.c             | 24 ++++++++++++++++++++++--
>>>   target/sparc/int32_helper.c             | 23 ++++++++++++-----------
>>>   hw/misc/trace-events                    |  4 ++++
>>>   hw/timer/trace-events                   |  2 +-
>>>   tests/acceptance/machine_sparc_leon3.py |  4 ++++
>>>   5 files changed, 43 insertions(+), 14 deletions(-)
>>>
> 

Re: [PATCH 0/7] hw/sparc/leon3: Few fixes and disable HelenOS test

[KONRAD Frederic]

Le 4/13/20 à 11:07 PM, Philippe Mathieu-Daudé a écrit :
> [Cc'ing Peter]
> 
> On 4/13/20 12:12 PM, KONRAD Frederic wrote:
>> Le 4/11/20 à 7:30 PM, Philippe Mathieu-Daudé a écrit :
>>> On 3/31/20 12:50 PM, Philippe Mathieu-Daudé wrote:
>>>> Philippe Mathieu-Daudé (7):
>>>>     hw/misc/grlib_ahb_apb_pnp: Avoid crash when writing to AHB PnP
>>>>       registers
>>>>     hw/misc/grlib_ahb_apb_pnp: Fix AHB PnP 8-bit accesses
>>>
>>> Ping ^^^ for 5.0?
>>
>> Hi Philippe,
>>
>> You already have my rb tag for those one, and IMHO they should be good
>> candidate
>> for 5.0 (if it's not too late).
> 
> Yes, thanks for the reviews. I see Mark Cave-Ayland merged this file
> first, but you are listed as maintainer :) I was hoping you could send a
> pull request.

Yes that's usually Mark who take the patches, sorry I didn't get it.

> 
> $ scripts/get_maintainer.pl -f hw/misc/grlib_ahb_apb_pnp.c
> Fabien Chouteau <chouteau@adacore.com> (maintainer:Leon3)
> KONRAD Frederic <frederic.konrad@adacore.com> (maintainer:Leon3)
> qemu-devel@nongnu.org (open list:All patches CC here)
> 

> This is a bug but not 'security critical', so it might wait 5.1 and go
> via qemu-trivial tree.

Well let's do that then if you're ok.

Best Regards,
Fred

> 
> Regards,
> 
> Phil.
> 
>>
>> Cheers,
>> Fred
>>
>>>
>>>>     hw/misc/grlib_ahb_apb_pnp: Add trace events on read accesses
>>>>     hw/timer/grlib_gptimer: Display frequency in decimal
>>>>     target/sparc/int32_helper: Remove DEBUG_PCALL definition
>>>>     target/sparc/int32_helper: Extract and use excp_name_str()
>>>>
>>>>    hw/misc/grlib_ahb_apb_pnp.c             | 24 ++++++++++++++++++++++--
>>>>    target/sparc/int32_helper.c             | 23 ++++++++++++-----------
>>>>    hw/misc/trace-events                    |  4 ++++
>>>>    hw/timer/trace-events                   |  2 +-
>>>>    tests/acceptance/machine_sparc_leon3.py |  4 ++++
>>>>    5 files changed, 43 insertions(+), 14 deletions(-)
>>>>
>>

Re: [PATCH 0/7] hw/sparc/leon3: Few fixes and disable HelenOS test

[Philippe Mathieu-Daudé]

On 4/14/20 12:00 PM, KONRAD Frederic wrote:
> Le 4/13/20 à 11:07 PM, Philippe Mathieu-Daudé a écrit :
>> [Cc'ing Peter]
>>
>> On 4/13/20 12:12 PM, KONRAD Frederic wrote:
>>> Le 4/11/20 à 7:30 PM, Philippe Mathieu-Daudé a écrit :
>>>> On 3/31/20 12:50 PM, Philippe Mathieu-Daudé wrote:
>>>>> Philippe Mathieu-Daudé (7):
>>>>>     hw/misc/grlib_ahb_apb_pnp: Avoid crash when writing to AHB PnP
>>>>>       registers
>>>>>     hw/misc/grlib_ahb_apb_pnp: Fix AHB PnP 8-bit accesses
>>>>
>>>> Ping ^^^ for 5.0?
>>>
>>> Hi Philippe,
>>>
>>> You already have my rb tag for those one, and IMHO they should be good
>>> candidate
>>> for 5.0 (if it's not too late).
>>
>> Yes, thanks for the reviews. I see Mark Cave-Ayland merged this file
>> first, but you are listed as maintainer :) I was hoping you could send a
>> pull request.
> 
> Yes that's usually Mark who take the patches, sorry I didn't get it.

No worries. As there are other sparc64 patches on the list, maybe Mark 
will prepare a pull request now.

> 
>>
>> $ scripts/get_maintainer.pl -f hw/misc/grlib_ahb_apb_pnp.c
>> Fabien Chouteau <chouteau@adacore.com> (maintainer:Leon3)
>> KONRAD Frederic <frederic.konrad@adacore.com> (maintainer:Leon3)
>> qemu-devel@nongnu.org (open list:All patches CC here)
>>
> 
>> This is a bug but not 'security critical', so it might wait 5.1 and go
>> via qemu-trivial tree.
> 
> Well let's do that then if you're ok.

OK, then ping? :)

> 
> Best Regards,
> Fred
> 
>>
>> Regards,
>>
>> Phil.
>>
>>>
>>> Cheers,
>>> Fred
>>>
>>>>
>>>>>     hw/misc/grlib_ahb_apb_pnp: Add trace events on read accesses
>>>>>     hw/timer/grlib_gptimer: Display frequency in decimal
>>>>>     target/sparc/int32_helper: Remove DEBUG_PCALL definition
>>>>>     target/sparc/int32_helper: Extract and use excp_name_str()
>>>>>
>>>>>    hw/misc/grlib_ahb_apb_pnp.c             | 24 
>>>>> ++++++++++++++++++++++--
>>>>>    target/sparc/int32_helper.c             | 23 
>>>>> ++++++++++++-----------
>>>>>    hw/misc/trace-events                    |  4 ++++
>>>>>    hw/timer/trace-events                   |  2 +-
>>>>>    tests/acceptance/machine_sparc_leon3.py |  4 ++++
>>>>>    5 files changed, 43 insertions(+), 14 deletions(-)
>>>>>
>>>
> 

Re: [PATCH 0/7] hw/sparc/leon3: Few fixes and disable HelenOS test

[Philippe Mathieu-Daudé]

ping?

On 5/11/20 9:03 AM, Philippe Mathieu-Daudé wrote:
> On 4/14/20 12:00 PM, KONRAD Frederic wrote:
>> Le 4/13/20 à 11:07 PM, Philippe Mathieu-Daudé a écrit :
>>> [Cc'ing Peter]
>>>
>>> On 4/13/20 12:12 PM, KONRAD Frederic wrote:
>>>> Le 4/11/20 à 7:30 PM, Philippe Mathieu-Daudé a écrit :
>>>>> On 3/31/20 12:50 PM, Philippe Mathieu-Daudé wrote:
>>>>>> Philippe Mathieu-Daudé (7):
>>>>>>     hw/misc/grlib_ahb_apb_pnp: Avoid crash when writing to AHB PnP
>>>>>>       registers
>>>>>>     hw/misc/grlib_ahb_apb_pnp: Fix AHB PnP 8-bit accesses
>>>>>
>>>>> Ping ^^^ for 5.0?
>>>>
>>>> Hi Philippe,
>>>>
>>>> You already have my rb tag for those one, and IMHO they should be good
>>>> candidate
>>>> for 5.0 (if it's not too late).
>>>
>>> Yes, thanks for the reviews. I see Mark Cave-Ayland merged this file
>>> first, but you are listed as maintainer :) I was hoping you could send a
>>> pull request.
>>
>> Yes that's usually Mark who take the patches, sorry I didn't get it.
> 
> No worries. As there are other sparc64 patches on the list, maybe Mark
> will prepare a pull request now.
> 
>>
>>>
>>> $ scripts/get_maintainer.pl -f hw/misc/grlib_ahb_apb_pnp.c
>>> Fabien Chouteau <chouteau@adacore.com> (maintainer:Leon3)
>>> KONRAD Frederic <frederic.konrad@adacore.com> (maintainer:Leon3)
>>> qemu-devel@nongnu.org (open list:All patches CC here)
>>>
>>
>>> This is a bug but not 'security critical', so it might wait 5.1 and go
>>> via qemu-trivial tree.
>>
>> Well let's do that then if you're ok.
> 
> OK, then ping? :)
> 
>>
>> Best Regards,
>> Fred
>>
>>>
>>> Regards,
>>>
>>> Phil.
>>>
>>>>
>>>> Cheers,
>>>> Fred
>>>>
>>>>>
>>>>>>     hw/misc/grlib_ahb_apb_pnp: Add trace events on read accesses
>>>>>>     hw/timer/grlib_gptimer: Display frequency in decimal
>>>>>>     target/sparc/int32_helper: Remove DEBUG_PCALL definition
>>>>>>     target/sparc/int32_helper: Extract and use excp_name_str()
>>>>>>
>>>>>>    hw/misc/grlib_ahb_apb_pnp.c             | 24
>>>>>> ++++++++++++++++++++++--
>>>>>>    target/sparc/int32_helper.c             | 23
>>>>>> ++++++++++++-----------
>>>>>>    hw/misc/trace-events                    |  4 ++++
>>>>>>    hw/timer/trace-events                   |  2 +-
>>>>>>    tests/acceptance/machine_sparc_leon3.py |  4 ++++
>>>>>>    5 files changed, 43 insertions(+), 14 deletions(-)
>>>>>>
>>>>
>>
> 

Re: [PATCH 0/7] hw/sparc/leon3: Few fixes and disable HelenOS test

[Fred Konrad]

Sorry Philippe I missed that.

Would be happy to do a PR if needed but:
   * I never did that.
   * Looking at https://wiki.qemu.org/Contribute/SubmitAPullRequest, I don't have
     the signed GPG key either.

Cheers,
Fred

Le 5/23/20 à 7:26 PM, Philippe Mathieu-Daudé a écrit :
> ping?
> 
> On 5/11/20 9:03 AM, Philippe Mathieu-Daudé wrote:
>> On 4/14/20 12:00 PM, KONRAD Frederic wrote:
>>> Le 4/13/20 à 11:07 PM, Philippe Mathieu-Daudé a écrit :
>>>> [Cc'ing Peter]
>>>>
>>>> On 4/13/20 12:12 PM, KONRAD Frederic wrote:
>>>>> Le 4/11/20 à 7:30 PM, Philippe Mathieu-Daudé a écrit :
>>>>>> On 3/31/20 12:50 PM, Philippe Mathieu-Daudé wrote:
>>>>>>> Philippe Mathieu-Daudé (7):
>>>>>>>      hw/misc/grlib_ahb_apb_pnp: Avoid crash when writing to AHB PnP
>>>>>>>        registers
>>>>>>>      hw/misc/grlib_ahb_apb_pnp: Fix AHB PnP 8-bit accesses
>>>>>>
>>>>>> Ping ^^^ for 5.0?
>>>>>
>>>>> Hi Philippe,
>>>>>
>>>>> You already have my rb tag for those one, and IMHO they should be good
>>>>> candidate
>>>>> for 5.0 (if it's not too late).
>>>>
>>>> Yes, thanks for the reviews. I see Mark Cave-Ayland merged this file
>>>> first, but you are listed as maintainer :) I was hoping you could send a
>>>> pull request.
>>>
>>> Yes that's usually Mark who take the patches, sorry I didn't get it.
>>
>> No worries. As there are other sparc64 patches on the list, maybe Mark
>> will prepare a pull request now.
>>
>>>
>>>>
>>>> $ scripts/get_maintainer.pl -f hw/misc/grlib_ahb_apb_pnp.c
>>>> Fabien Chouteau <chouteau@adacore.com> (maintainer:Leon3)
>>>> KONRAD Frederic <frederic.konrad@adacore.com> (maintainer:Leon3)
>>>> qemu-devel@nongnu.org (open list:All patches CC here)
>>>>
>>>
>>>> This is a bug but not 'security critical', so it might wait 5.1 and go
>>>> via qemu-trivial tree.
>>>
>>> Well let's do that then if you're ok.
>>
>> OK, then ping? :)
>>
>>>
>>> Best Regards,
>>> Fred
>>>
>>>>
>>>> Regards,
>>>>
>>>> Phil.
>>>>
>>>>>
>>>>> Cheers,
>>>>> Fred
>>>>>
>>>>>>
>>>>>>>      hw/misc/grlib_ahb_apb_pnp: Add trace events on read accesses
>>>>>>>      hw/timer/grlib_gptimer: Display frequency in decimal
>>>>>>>      target/sparc/int32_helper: Remove DEBUG_PCALL definition
>>>>>>>      target/sparc/int32_helper: Extract and use excp_name_str()
>>>>>>>
>>>>>>>     hw/misc/grlib_ahb_apb_pnp.c             | 24
>>>>>>> ++++++++++++++++++++++--
>>>>>>>     target/sparc/int32_helper.c             | 23
>>>>>>> ++++++++++++-----------
>>>>>>>     hw/misc/trace-events                    |  4 ++++
>>>>>>>     hw/timer/trace-events                   |  2 +-
>>>>>>>     tests/acceptance/machine_sparc_leon3.py |  4 ++++
>>>>>>>     5 files changed, 43 insertions(+), 14 deletions(-)
>>>>>>>
>>>>>
>>>
>>

Re: [PATCH 0/7] hw/sparc/leon3: Few fixes and disable HelenOS test

[Philippe Mathieu-Daudé]

On 5/25/20 1:02 PM, Fred Konrad wrote:
> Sorry Philippe I missed that.
> 
> Would be happy to do a PR if needed but:
>   * I never did that.
>   * Looking at https://wiki.qemu.org/Contribute/SubmitAPullRequest, I
> don't have
>     the signed GPG key either.

Thanks Fred for following this series.

I am not insisting for you to do the pull request, I was waiting for
Artyom (sparc32) and Mark (sparc64) who usually handle the pull requests.

Artyom seems busy lately.

Mark, do you plan to send a hw/sparc* pull request soon? Do you prefer I
ask to trivial@ for this series?

FYI there is another sparc32 candidate patch:
https://www.mail-archive.com/qemu-devel@nongnu.org/msg701850.html

Regards,

Phil.

> 
> Cheers,
> Fred
> 
> Le 5/23/20 à 7:26 PM, Philippe Mathieu-Daudé a écrit :
>> ping?
>>
>> On 5/11/20 9:03 AM, Philippe Mathieu-Daudé wrote:
>>> On 4/14/20 12:00 PM, KONRAD Frederic wrote:
>>>> Le 4/13/20 à 11:07 PM, Philippe Mathieu-Daudé a écrit :
>>>>> [Cc'ing Peter]
>>>>>
>>>>> On 4/13/20 12:12 PM, KONRAD Frederic wrote:
>>>>>> Le 4/11/20 à 7:30 PM, Philippe Mathieu-Daudé a écrit :
>>>>>>> On 3/31/20 12:50 PM, Philippe Mathieu-Daudé wrote:
>>>>>>>> Philippe Mathieu-Daudé (7):
>>>>>>>>      hw/misc/grlib_ahb_apb_pnp: Avoid crash when writing to AHB PnP
>>>>>>>>        registers
>>>>>>>>      hw/misc/grlib_ahb_apb_pnp: Fix AHB PnP 8-bit accesses
>>>>>>>
>>>>>>> Ping ^^^ for 5.0?
>>>>>>
>>>>>> Hi Philippe,
>>>>>>
>>>>>> You already have my rb tag for those one, and IMHO they should be
>>>>>> good
>>>>>> candidate
>>>>>> for 5.0 (if it's not too late).
>>>>>
>>>>> Yes, thanks for the reviews. I see Mark Cave-Ayland merged this file
>>>>> first, but you are listed as maintainer :) I was hoping you could
>>>>> send a
>>>>> pull request.
>>>>
>>>> Yes that's usually Mark who take the patches, sorry I didn't get it.
>>>
>>> No worries. As there are other sparc64 patches on the list, maybe Mark
>>> will prepare a pull request now.
>>>
>>>>
>>>>>
>>>>> $ scripts/get_maintainer.pl -f hw/misc/grlib_ahb_apb_pnp.c
>>>>> Fabien Chouteau <chouteau@adacore.com> (maintainer:Leon3)
>>>>> KONRAD Frederic <frederic.konrad@adacore.com> (maintainer:Leon3)
>>>>> qemu-devel@nongnu.org (open list:All patches CC here)
>>>>>
>>>>
>>>>> This is a bug but not 'security critical', so it might wait 5.1 and go
>>>>> via qemu-trivial tree.
>>>>
>>>> Well let's do that then if you're ok.
>>>
>>> OK, then ping? :)
>>>
>>>>
>>>> Best Regards,
>>>> Fred
>>>>
>>>>>
>>>>> Regards,
>>>>>
>>>>> Phil.
>>>>>
>>>>>>
>>>>>> Cheers,
>>>>>> Fred
>>>>>>
>>>>>>>
>>>>>>>>      hw/misc/grlib_ahb_apb_pnp: Add trace events on read accesses
>>>>>>>>      hw/timer/grlib_gptimer: Display frequency in decimal
>>>>>>>>      target/sparc/int32_helper: Remove DEBUG_PCALL definition
>>>>>>>>      target/sparc/int32_helper: Extract and use excp_name_str()
>>>>>>>>
>>>>>>>>     hw/misc/grlib_ahb_apb_pnp.c             | 24
>>>>>>>> ++++++++++++++++++++++--
>>>>>>>>     target/sparc/int32_helper.c             | 23
>>>>>>>> ++++++++++++-----------
>>>>>>>>     hw/misc/trace-events                    |  4 ++++
>>>>>>>>     hw/timer/trace-events                   |  2 +-
>>>>>>>>     tests/acceptance/machine_sparc_leon3.py |  4 ++++
>>>>>>>>     5 files changed, 43 insertions(+), 14 deletions(-)
>>>>>>>>
>>>>>>
>>>>
>>>
> 

Re: [PATCH 0/7] hw/sparc/leon3: Few fixes and disable HelenOS test

[Philippe Mathieu-Daudé]

On 5/26/20 11:50 AM, Philippe Mathieu-Daudé wrote:
> On 5/25/20 1:02 PM, Fred Konrad wrote:
>> Sorry Philippe I missed that.
>>
>> Would be happy to do a PR if needed but:
>>   * I never did that.
>>   * Looking at https://wiki.qemu.org/Contribute/SubmitAPullRequest, I
>> don't have
>>     the signed GPG key either.
> 
> Thanks Fred for following this series.
> 
> I am not insisting for you to do the pull request, I was waiting for
> Artyom (sparc32) and Mark (sparc64) who usually handle the pull requests.
> 
> Artyom seems busy lately.

Artyom, if you agree I can send a pullreq with this series and the
empty_slot one.

> 
> Mark, do you plan to send a hw/sparc* pull request soon? Do you prefer I
> ask to trivial@ for this series?
> 
> FYI there is another sparc32 candidate patch:
> https://www.mail-archive.com/qemu-devel@nongnu.org/msg701850.html
> 
> Regards,
> 
> Phil.
> 
>>
>> Cheers,
>> Fred
>>
>> Le 5/23/20 à 7:26 PM, Philippe Mathieu-Daudé a écrit :
>>> ping?
>>>
>>> On 5/11/20 9:03 AM, Philippe Mathieu-Daudé wrote:
>>>> On 4/14/20 12:00 PM, KONRAD Frederic wrote:
>>>>> Le 4/13/20 à 11:07 PM, Philippe Mathieu-Daudé a écrit :
>>>>>> [Cc'ing Peter]
>>>>>>
>>>>>> On 4/13/20 12:12 PM, KONRAD Frederic wrote:
>>>>>>> Le 4/11/20 à 7:30 PM, Philippe Mathieu-Daudé a écrit :
>>>>>>>> On 3/31/20 12:50 PM, Philippe Mathieu-Daudé wrote:
>>>>>>>>> Philippe Mathieu-Daudé (7):
>>>>>>>>>      hw/misc/grlib_ahb_apb_pnp: Avoid crash when writing to AHB PnP
>>>>>>>>>        registers
>>>>>>>>>      hw/misc/grlib_ahb_apb_pnp: Fix AHB PnP 8-bit accesses
>>>>>>>>
>>>>>>>> Ping ^^^ for 5.0?
>>>>>>>
>>>>>>> Hi Philippe,
>>>>>>>
>>>>>>> You already have my rb tag for those one, and IMHO they should be
>>>>>>> good
>>>>>>> candidate
>>>>>>> for 5.0 (if it's not too late).
>>>>>>
>>>>>> Yes, thanks for the reviews. I see Mark Cave-Ayland merged this file
>>>>>> first, but you are listed as maintainer :) I was hoping you could
>>>>>> send a
>>>>>> pull request.
>>>>>
>>>>> Yes that's usually Mark who take the patches, sorry I didn't get it.
>>>>
>>>> No worries. As there are other sparc64 patches on the list, maybe Mark
>>>> will prepare a pull request now.
>>>>
>>>>>
>>>>>>
>>>>>> $ scripts/get_maintainer.pl -f hw/misc/grlib_ahb_apb_pnp.c
>>>>>> Fabien Chouteau <chouteau@adacore.com> (maintainer:Leon3)
>>>>>> KONRAD Frederic <frederic.konrad@adacore.com> (maintainer:Leon3)
>>>>>> qemu-devel@nongnu.org (open list:All patches CC here)
>>>>>>
>>>>>
>>>>>> This is a bug but not 'security critical', so it might wait 5.1 and go
>>>>>> via qemu-trivial tree.
>>>>>
>>>>> Well let's do that then if you're ok.
>>>>
>>>> OK, then ping? :)
>>>>
>>>>>
>>>>> Best Regards,
>>>>> Fred
>>>>>
>>>>>>
>>>>>> Regards,
>>>>>>
>>>>>> Phil.
>>>>>>
>>>>>>>
>>>>>>> Cheers,
>>>>>>> Fred
>>>>>>>
>>>>>>>>
>>>>>>>>>      hw/misc/grlib_ahb_apb_pnp: Add trace events on read accesses
>>>>>>>>>      hw/timer/grlib_gptimer: Display frequency in decimal
>>>>>>>>>      target/sparc/int32_helper: Remove DEBUG_PCALL definition
>>>>>>>>>      target/sparc/int32_helper: Extract and use excp_name_str()
>>>>>>>>>
>>>>>>>>>     hw/misc/grlib_ahb_apb_pnp.c             | 24
>>>>>>>>> ++++++++++++++++++++++--
>>>>>>>>>     target/sparc/int32_helper.c             | 23
>>>>>>>>> ++++++++++++-----------
>>>>>>>>>     hw/misc/trace-events                    |  4 ++++
>>>>>>>>>     hw/timer/trace-events                   |  2 +-
>>>>>>>>>     tests/acceptance/machine_sparc_leon3.py |  4 ++++
>>>>>>>>>     5 files changed, 43 insertions(+), 14 deletions(-)
>>>>>>>>>
>>>>>>>
>>>>>
>>>>
>>
> 

Re: [PATCH 0/7] hw/sparc/leon3: Few fixes and disable HelenOS test

[Mark Cave-Ayland]

On 08/06/2020 16:20, Philippe Mathieu-Daudé wrote:

> On 5/26/20 11:50 AM, Philippe Mathieu-Daudé wrote:
>> On 5/25/20 1:02 PM, Fred Konrad wrote:
>>> Sorry Philippe I missed that.
>>>
>>> Would be happy to do a PR if needed but:
>>>   * I never did that.
>>>   * Looking at https://wiki.qemu.org/Contribute/SubmitAPullRequest, I
>>> don't have
>>>     the signed GPG key either.
>>
>> Thanks Fred for following this series.
>>
>> I am not insisting for you to do the pull request, I was waiting for
>> Artyom (sparc32) and Mark (sparc64) who usually handle the pull requests.
>>
>> Artyom seems busy lately.
> 
> Artyom, if you agree I can send a pullreq with this series and the
> empty_slot one.
> 
>>
>> Mark, do you plan to send a hw/sparc* pull request soon? Do you prefer I
>> ask to trivial@ for this series?
>>
>> FYI there is another sparc32 candidate patch:
>> https://www.mail-archive.com/qemu-devel@nongnu.org/msg701850.html

Apologies, it looks as if this one slipped under my radar. I don't have any SPARC
patches queued at the moment, so if you have a series prepared with both these
patches then I'm happy for you to include them. The bits of time I have had to work
on QEMU this cycle have been spent looking at the QOM patches and some ADB fixes I
hope to finish soon...


ATB,

Mark.

Re: [PATCH 0/7] hw/sparc/leon3: Few fixes and disable HelenOS test

[Artyom Tarasenko]

On Mon, Jun 8, 2020 at 5:20 PM Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
>
> On 5/26/20 11:50 AM, Philippe Mathieu-Daudé wrote:
> > On 5/25/20 1:02 PM, Fred Konrad wrote:
> >> Sorry Philippe I missed that.
> >>
> >> Would be happy to do a PR if needed but:
> >>   * I never did that.
> >>   * Looking at https://wiki.qemu.org/Contribute/SubmitAPullRequest, I
> >> don't have
> >>     the signed GPG key either.
> >
> > Thanks Fred for following this series.
> >
> > I am not insisting for you to do the pull request, I was waiting for
> > Artyom (sparc32) and Mark (sparc64) who usually handle the pull requests.
> >
> > Artyom seems busy lately.
>
> Artyom, if you agree I can send a pullreq with this series and the
> empty_slot one.
>

Yes, please.
Artyom

> >
> > Mark, do you plan to send a hw/sparc* pull request soon? Do you prefer I
> > ask to trivial@ for this series?
> >
> > FYI there is another sparc32 candidate patch:
> > https://www.mail-archive.com/qemu-devel@nongnu.org/msg701850.html
> >
> > Regards,
> >
> > Phil.
> >
> >>
> >> Cheers,
> >> Fred
> >>
> >> Le 5/23/20 à 7:26 PM, Philippe Mathieu-Daudé a écrit :
> >>> ping?
> >>>
> >>> On 5/11/20 9:03 AM, Philippe Mathieu-Daudé wrote:
> >>>> On 4/14/20 12:00 PM, KONRAD Frederic wrote:
> >>>>> Le 4/13/20 à 11:07 PM, Philippe Mathieu-Daudé a écrit :
> >>>>>> [Cc'ing Peter]
> >>>>>>
> >>>>>> On 4/13/20 12:12 PM, KONRAD Frederic wrote:
> >>>>>>> Le 4/11/20 à 7:30 PM, Philippe Mathieu-Daudé a écrit :
> >>>>>>>> On 3/31/20 12:50 PM, Philippe Mathieu-Daudé wrote:
> >>>>>>>>> Philippe Mathieu-Daudé (7):
> >>>>>>>>>      hw/misc/grlib_ahb_apb_pnp: Avoid crash when writing to AHB PnP
> >>>>>>>>>        registers
> >>>>>>>>>      hw/misc/grlib_ahb_apb_pnp: Fix AHB PnP 8-bit accesses
> >>>>>>>>
> >>>>>>>> Ping ^^^ for 5.0?
> >>>>>>>
> >>>>>>> Hi Philippe,
> >>>>>>>
> >>>>>>> You already have my rb tag for those one, and IMHO they should be
> >>>>>>> good
> >>>>>>> candidate
> >>>>>>> for 5.0 (if it's not too late).
> >>>>>>
> >>>>>> Yes, thanks for the reviews. I see Mark Cave-Ayland merged this file
> >>>>>> first, but you are listed as maintainer :) I was hoping you could
> >>>>>> send a
> >>>>>> pull request.
> >>>>>
> >>>>> Yes that's usually Mark who take the patches, sorry I didn't get it.
> >>>>
> >>>> No worries. As there are other sparc64 patches on the list, maybe Mark
> >>>> will prepare a pull request now.
> >>>>
> >>>>>
> >>>>>>
> >>>>>> $ scripts/get_maintainer.pl -f hw/misc/grlib_ahb_apb_pnp.c
> >>>>>> Fabien Chouteau <chouteau@adacore.com> (maintainer:Leon3)
> >>>>>> KONRAD Frederic <frederic.konrad@adacore.com> (maintainer:Leon3)
> >>>>>> qemu-devel@nongnu.org (open list:All patches CC here)
> >>>>>>
> >>>>>
> >>>>>> This is a bug but not 'security critical', so it might wait 5.1 and go
> >>>>>> via qemu-trivial tree.
> >>>>>
> >>>>> Well let's do that then if you're ok.
> >>>>
> >>>> OK, then ping? :)
> >>>>
> >>>>>
> >>>>> Best Regards,
> >>>>> Fred
> >>>>>
> >>>>>>
> >>>>>> Regards,
> >>>>>>
> >>>>>> Phil.
> >>>>>>
> >>>>>>>
> >>>>>>> Cheers,
> >>>>>>> Fred
> >>>>>>>
> >>>>>>>>
> >>>>>>>>>      hw/misc/grlib_ahb_apb_pnp: Add trace events on read accesses
> >>>>>>>>>      hw/timer/grlib_gptimer: Display frequency in decimal
> >>>>>>>>>      target/sparc/int32_helper: Remove DEBUG_PCALL definition
> >>>>>>>>>      target/sparc/int32_helper: Extract and use excp_name_str()
> >>>>>>>>>
> >>>>>>>>>     hw/misc/grlib_ahb_apb_pnp.c             | 24
> >>>>>>>>> ++++++++++++++++++++++--
> >>>>>>>>>     target/sparc/int32_helper.c             | 23
> >>>>>>>>> ++++++++++++-----------
> >>>>>>>>>     hw/misc/trace-events                    |  4 ++++
> >>>>>>>>>     hw/timer/trace-events                   |  2 +-
> >>>>>>>>>     tests/acceptance/machine_sparc_leon3.py |  4 ++++
> >>>>>>>>>     5 files changed, 43 insertions(+), 14 deletions(-)
> >>>>>>>>>
> >>>>>>>
> >>>>>
> >>>>
> >>
> >



-- 
Regards,
Artyom Tarasenko

SPARC and PPC PReP under qemu blog: http://tyom.blogspot.com/search/label/qemu

Re: [PATCH 0/7] hw/sparc/leon3: Few fixes and disable HelenOS test

[Philippe Mathieu-Daudé]

On 3/31/20 12:50 PM, Philippe Mathieu-Daudé wrote:
> The Leon3Machine.test_leon3_helenos_uimage has been running
> erratically since some time now. Time to disable it (at least
> until we make it reliable).
> Few other patches added while tracking the issue.
> 
> Philippe Mathieu-Daudé (7):
>   tests/acceptance/machine_sparc_leon3: Disable HelenOS test
>   hw/misc/grlib_ahb_apb_pnp: Avoid crash when writing to AHB PnP
>     registers
>   hw/misc/grlib_ahb_apb_pnp: Fix AHB PnP 8-bit accesses
>   hw/misc/grlib_ahb_apb_pnp: Add trace events on read accesses
>   hw/timer/grlib_gptimer: Display frequency in decimal
>   target/sparc/int32_helper: Remove DEBUG_PCALL definition
>   target/sparc/int32_helper: Extract and use excp_name_str()
> 
>  hw/misc/grlib_ahb_apb_pnp.c             | 24 ++++++++++++++++++++++--
>  target/sparc/int32_helper.c             | 23 ++++++++++++-----------
>  hw/misc/trace-events                    |  4 ++++
>  hw/timer/trace-events                   |  2 +-
>  tests/acceptance/machine_sparc_leon3.py |  4 ++++
>  5 files changed, 43 insertions(+), 14 deletions(-)
> 

Thanks, series applied to for the next (temporary) sparc-next pull request.