From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8332FC433B4 for ; Wed, 12 May 2021 11:25:50 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A69D261376 for ; Wed, 12 May 2021 11:25:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A69D261376 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=vivier.eu Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:47902 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lgmzs-0003xz-Fr for qemu-devel@archiver.kernel.org; Wed, 12 May 2021 07:25:48 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43454) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lgmqo-0007Tv-Qg for qemu-devel@nongnu.org; Wed, 12 May 2021 07:16:26 -0400 Received: from mout.kundenserver.de ([217.72.192.74]:38807) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lgmqm-0002Cy-ML for qemu-devel@nongnu.org; Wed, 12 May 2021 07:16:26 -0400 Received: from [192.168.100.1] ([82.142.31.78]) by mrelayeu.kundenserver.de (mreue106 [213.165.67.119]) with ESMTPSA (Nemesis) id 1MvJo7-1lOqQJ18Vd-00rJwN; Wed, 12 May 2021 13:16:14 +0200 Subject: Re: [PATCH] Constify bitmask_transtbl fcntl/mmap flags_tlb[] To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-devel@nongnu.org References: <20210511103502.2875844-1-f4bug@amsat.org> From: Laurent Vivier Message-ID: Date: Wed, 12 May 2021 13:16:13 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210511103502.2875844-1-f4bug@amsat.org> Content-Type: text/plain; charset=utf-8 Content-Language: fr Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K1:T7o6HDjHibuDULfCs4ZMS3x/FSWC9yQEghANPSfeWPvisXjoTlQ WcbTU4b9ClNW6PrNk4BNNng0+T3eamOm8D+9i+4yUkY+562qYGUm1mzPYBGFYjywL5GfBQR I8Rd2QlXmiCEOelaUEzj0qy4BdN1inGrWXfuuYjlPNvDRL2ayqNXdYkNF8wMbmmFa2sNoEA aqLKKqDFU1Opr7rmX5gHQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:j/XlrEh7e5Q=:JeezTVikxvg4sEmRrMHkZN JUQ4o/86zWQHkK7mfAC0PcuaSKwDSdDcTykH1sZnDvmT73cuPoCNQo6cKGw9fqmWh2RswlVbM BIrBYFUYpjkEE8G2lh2Eubc90hSL2c0bADkj67TNa+k3Fu3hMUU69TBGb5BUox24dx0EWX6J7 O63DKzbc01ZQzrbNy45UJfGADFXnHYNU9EAA1fUIuiE/EB3mHkKynaN/JkvY1zyFif5CuQu3J /g0PLsZM6bj+WTYiLDMIbcWd8PmHfud2YpURhGzA0qkAM8AdzItg4B94HVdafdq9/QhZ/KNCU krLNv4thMtt/hGeQBr/K22vpJ/rvtCMTjoezSzYqZ/s7zkDQgWcIYR6le3t4PaHYxIMKwWAkI oFmBT7mX0M1fgnldynwQGdZRmI5sNxm/KfjLmYsCbxkB3yAit0FwVESX79wGjqAZdm1hcT4Pq wKgWwZetTVqsOnOlOd+Pa+p19bLRauGqfA8B2/m2JfMsE8EhWIJ5Rra4E5Ly0eCVNPlO6tLrm hKAKRHeZPJdKcqJqB/NJnU= Received-SPF: none client-ip=217.72.192.74; envelope-from=laurent@vivier.eu; helo=mout.kundenserver.de X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Le 11/05/2021 à 12:35, Philippe Mathieu-Daudé a écrit : > Keep bitmask_transtbl in .rodata by marking the arrays const. > > Signed-off-by: Philippe Mathieu-Daudé > --- > linux-user/syscall.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/linux-user/syscall.c b/linux-user/syscall.c > index 95d79ddc437..64f486743a9 100644 > --- a/linux-user/syscall.c > +++ b/linux-user/syscall.c > @@ -365,7 +365,7 @@ _syscall5(int, sys_statx, int, dirfd, const char *, pathname, int, flags, > _syscall2(int, membarrier, int, cmd, int, flags) > #endif > > -static bitmask_transtbl fcntl_flags_tbl[] = { > +static const bitmask_transtbl fcntl_flags_tbl[] = { > { TARGET_O_ACCMODE, TARGET_O_WRONLY, O_ACCMODE, O_WRONLY, }, > { TARGET_O_ACCMODE, TARGET_O_RDWR, O_ACCMODE, O_RDWR, }, > { TARGET_O_CREAT, TARGET_O_CREAT, O_CREAT, O_CREAT, }, > @@ -6062,7 +6062,7 @@ static const StructEntry struct_termios_def = { > .print = print_termios, > }; > > -static bitmask_transtbl mmap_flags_tbl[] = { > +static const bitmask_transtbl mmap_flags_tbl[] = { > { TARGET_MAP_SHARED, TARGET_MAP_SHARED, MAP_SHARED, MAP_SHARED }, > { TARGET_MAP_PRIVATE, TARGET_MAP_PRIVATE, MAP_PRIVATE, MAP_PRIVATE }, > { TARGET_MAP_FIXED, TARGET_MAP_FIXED, MAP_FIXED, MAP_FIXED }, > Reviewed-by: Laurent Vivier