Re: [PATCH] configure: Check bzip2 is available

[Thomas Huth <thuth@redhat.com>]

On 08/11/2019 11.28, Philippe Mathieu-Daudé wrote:
> The bzip2 tool is not included in default installations.
> On freshly installed systems, ./configure succeeds but 'make'
> might fail later:
> 
>      BUNZIP2 pc-bios/edk2-i386-secure-code.fd.bz2
>    /bin/sh: bzip2: command not found
>    make: *** [Makefile:305: pc-bios/edk2-i386-secure-code.fd] Error 127
>    make: *** Deleting file 'pc-bios/edk2-i386-secure-code.fd'
>    make: *** Waiting for unfinished jobs....
> 
> Add a check in ./configure to warn the user if bzip2 is missing.
> 
> Fixes: 536d2173b2b
> Reported-by: Thomas Huth <thuth@redhat.com>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
>   configure | 7 +++++++
>   1 file changed, 7 insertions(+)
> 
> diff --git a/configure b/configure
> index efe165edf9..9957e913e8 100755
> --- a/configure
> +++ b/configure
> @@ -1851,6 +1851,13 @@ python_version=$($python -c 'import sys; print("%d.%d.%d" % (sys.version_info[0]
>   # Suppress writing compiled files
>   python="$python -B"
>   
> +# Some firmware binaries are compressed with bzip2
> +if has bzip2; then
> +  :
> +else
> +  error_exit "bzip2 program not found. Please install it"
> +fi

It's only required for the edk2 binaries, isn't it? So should this maybe 
also check whether we build any of the i386-softmmu, x86_64-softmmu 
arm-softmmu or aarch64-softmmu targets and pass otherwise?

  Thomas