From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Sarah Harris <S.E.Harris@kent.ac.uk>, Thomas Huth <thuth@redhat.com>
Cc: Richard Henderson <richard.henderson@linaro.org>,
Igor Mammedov <imammedo@redhat.com>,
Michael Rolnik <mrolnik@gmail.com>,
QEMU Developers <qemu-devel@nongnu.org>,
Pavel Dovgalyuk <dovgaluk@ispras.ru>
Subject: Re: [Qemu-devel] [PATCH v29 1/8] target/avr: Add outward facing interfaces and core CPU logic
Date: Sat, 12 Oct 2019 09:22:59 +0200 [thread overview]
Message-ID: <b60d0bc3-27f8-2dec-979a-f724106c2347@redhat.com> (raw)
In-Reply-To: <20190827115954.d2f925de4c0f7c063a7e7131@kent.ac.uk>
On 8/27/19 12:59 PM, Sarah Harris wrote:
> I don't mind if you want to drop my signed-off-by for commits that were based on Michael's work.
> You probably want to keep my sign-off for the USART/timer commit though as that was new code.
Linux offers a Co-developed-by, some QEMU developers started to use it.
Co-developed-by: states that the patch was co-created by multiple
developers; it is a used to give attribution to co-authors (in
addition to the author attributed by the From: tag) when several
people work on a single patch. Since Co-developed-by: denotes
authorship, every Co-developed-by: must be immediately followed
by a Signed-off-by: of the associated co-author. Standard sign-off
procedure applies, i.e. the ordering of Signed-off-by: tags should
reflect the chronological history of the patch insofar as possible,
regardless of whether the author is attributed via From: or
Co-developed-by:. Notably, the last Signed-off-by: must always be
that of the developer submitting the patch.
https://www.kernel.org/doc/html/latest/process/submitting-patches.html#when-to-use-acked-by-cc-and-co-developed-by
>
> Regards,
> Sarah Harris
>
> On Mon, 26 Aug 2019 10:00:51 +0200
> Thomas Huth <thuth@redhat.com> wrote:
>
>> On 26/08/2019 09.53, Michael Rolnik wrote:
>>> the commit was originally mine. Then Sarah rearranged it, signed and
>>> submitted. She no longer maintains it. So' I believe I can remove her sob.
>>> what do you think?.
>>
>> Fine for me, but maybe you should mention her in the patch description
>> if she made significant changes?
>>
>> Sarah, what do you think?
>>
>> Anyway, if the patch is originally from you, you should also remove the
>> "From: Sarah ..." line from the patch. For this, you likely have to
>> change the author of the patch in your git tree with "git commit --amend
>> --reset-author".
>>
>> Thomas
next prev parent reply other threads:[~2019-10-12 7:23 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-24 18:46 [Qemu-devel] [PATCH v29 0/8] QEMU AVR 8 bit cores Michael Rolnik
2019-08-24 18:46 ` [Qemu-devel] [PATCH v29 1/8] target/avr: Add outward facing interfaces and core CPU logic Michael Rolnik
2019-08-26 7:21 ` Thomas Huth
2019-08-26 7:53 ` Michael Rolnik
2019-08-26 8:00 ` Thomas Huth
2019-08-27 10:59 ` Sarah Harris
2019-10-12 7:22 ` Philippe Mathieu-Daudé [this message]
2019-08-24 18:46 ` [Qemu-devel] [PATCH v29 2/8] target/avr: Add instruction helpers Michael Rolnik
2019-08-24 18:46 ` [Qemu-devel] [PATCH v29 3/8] target/avr: Add instruction decoding Michael Rolnik
2019-08-24 18:46 ` [Qemu-devel] [PATCH v29 4/8] target/avr: Add instruction translation Michael Rolnik
2019-08-24 18:46 ` [Qemu-devel] [PATCH v29 5/8] target/avr: Add limited support for USART and 16 bit timer peripherals Michael Rolnik
2019-08-24 18:46 ` [Qemu-devel] [PATCH v29 6/8] target/avr: Add example board configuration Michael Rolnik
2019-08-24 18:46 ` [Qemu-devel] [PATCH v29 7/8] target/avr: Register AVR support with the rest of QEMU, the build system, and the MAINTAINERS file Michael Rolnik
2019-08-26 6:01 ` Thomas Huth
2019-08-24 18:46 ` [Qemu-devel] [PATCH v29 8/8] target/avr: Add tests Michael Rolnik
2019-08-26 5:39 ` Thomas Huth
2019-08-26 9:23 ` Alex Bennée
2019-08-26 17:13 ` Richard Henderson
2019-08-27 9:25 ` Alex Bennée
2019-08-27 9:29 ` Pavel Dovgalyuk
2019-10-12 7:17 ` Philippe Mathieu-Daudé
2019-10-12 14:11 ` Pavel Dovgalyuk
2019-08-26 7:09 ` [Qemu-devel] [PATCH v29 0/8] QEMU AVR 8 bit cores Pavel Dovgalyuk
2019-08-26 7:46 ` Michael Rolnik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b60d0bc3-27f8-2dec-979a-f724106c2347@redhat.com \
--to=philmd@redhat.com \
--cc=S.E.Harris@kent.ac.uk \
--cc=dovgaluk@ispras.ru \
--cc=imammedo@redhat.com \
--cc=mrolnik@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).