Re: [Qemu-devel] [PATCH v29 1/8] target/avr: Add outward facing interfaces and core CPU logic - Philippe Mathieu-Daudé

From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Sarah Harris <S.E.Harris@kent.ac.uk>, Thomas Huth <thuth@redhat.com>
Cc: Richard Henderson <richard.henderson@linaro.org>,
	Igor Mammedov <imammedo@redhat.com>,
	Michael Rolnik <mrolnik@gmail.com>,
	QEMU Developers <qemu-devel@nongnu.org>,
	Pavel Dovgalyuk <dovgaluk@ispras.ru>
Subject: Re: [Qemu-devel] [PATCH v29 1/8] target/avr: Add outward facing interfaces and core CPU logic
Date: Sat, 12 Oct 2019 09:22:59 +0200
Message-ID: <b60d0bc3-27f8-2dec-979a-f724106c2347@redhat.com> (raw)
In-Reply-To: <20190827115954.d2f925de4c0f7c063a7e7131@kent.ac.uk>

On 8/27/19 12:59 PM, Sarah Harris wrote:
> I don't mind if you want to drop my signed-off-by for commits that were based on Michael's work.
> You probably want to keep my sign-off for the USART/timer commit though as that was new code.

Linux offers a Co-developed-by, some QEMU developers started to use it.

   Co-developed-by: states that the patch was co-created by multiple
   developers; it is a used to give attribution to co-authors (in
   addition to the author attributed by the From: tag) when several
   people work on a single patch. Since Co-developed-by: denotes
   authorship, every Co-developed-by: must be immediately followed
   by a Signed-off-by: of the associated co-author. Standard sign-off
   procedure applies, i.e. the ordering of Signed-off-by: tags should
   reflect the chronological history of the patch insofar as possible,
   regardless of whether the author is attributed via From: or
   Co-developed-by:. Notably, the last Signed-off-by: must always be
   that of the developer submitting the patch.

https://www.kernel.org/doc/html/latest/process/submitting-patches.html#when-to-use-acked-by-cc-and-co-developed-by

> 
> Regards,
> Sarah Harris
> 
> On Mon, 26 Aug 2019 10:00:51 +0200
> Thomas Huth <thuth@redhat.com> wrote:
> 
>> On 26/08/2019 09.53, Michael Rolnik wrote:
>>> the commit was originally mine. Then Sarah rearranged it, signed and
>>> submitted. She no longer maintains it. So' I believe I can remove her sob.
>>> what do you think?.
>>
>> Fine for me, but maybe you should mention her in the patch description
>> if she made significant changes?
>>
>> Sarah, what do you think?
>>
>> Anyway, if the patch is originally from you, you should also remove the
>> "From: Sarah ..." line from the patch. For this, you likely have to
>> change the author of the patch in your git tree with "git commit --amend
>> --reset-author".
>>
>>   Thomas