From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5594AC4727C for ; Thu, 1 Oct 2020 15:33:07 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DED0E2074B for ; Thu, 1 Oct 2020 15:33:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="F7qV23H4" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DED0E2074B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:43602 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kO0Zu-0001cX-0I for qemu-devel@archiver.kernel.org; Thu, 01 Oct 2020 11:33:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54526) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kO0Si-0003Wb-7t for qemu-devel@nongnu.org; Thu, 01 Oct 2020 11:25:40 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:44230) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kO0Sd-0001Iz-0b for qemu-devel@nongnu.org; Thu, 01 Oct 2020 11:25:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1601565932; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=3y1TfeXMgsJtfe1WZc6EheXAqi9HhWSEoluhlHAW3Yc=; b=F7qV23H4hfOe1DFVu8d9ZQz8I4g2MjUE8pggrNygJIk6xa95fi5VQxQtJT3sqD+5zkEwjg ll8vXfqr+rtATx3ZMMTDLXF1TUojiBGE9hlYa5FMN/NfEZFrn6XHxkZvR5JQzhGseeiqrZ FAyGJfASdiBnqziNqZAcKleIqtwtBu4= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-385-0GmIHtm1PPqsGK3dycELPQ-1; Thu, 01 Oct 2020 11:25:31 -0400 X-MC-Unique: 0GmIHtm1PPqsGK3dycELPQ-1 Received: by mail-wr1-f72.google.com with SMTP id b7so2200596wrn.6 for ; Thu, 01 Oct 2020 08:25:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=3y1TfeXMgsJtfe1WZc6EheXAqi9HhWSEoluhlHAW3Yc=; b=pMFs1sW051vsezrGJewmz2WDyq4jNoOOVVOroWeNH/7XWCARRnRT2Ic7gS0QMQQLs/ jmaF73EsR+a1klH5ALO0qCwjyJKfdPjih/tCM9uYuQIiip4GvMrF7s2Xpzq7qqV6kDf0 boyAOa7ihBufaNakK+RkEFzBxUTFXSoJC/Jef5BrKZq8S11HEI35b9K9nuDbmcF8yJb/ M0jAvUGAQeUXJcUyUmFzvs26+JbUyB3tWM9kvC7UHGUsP5PAaEpDnXYjCFEEm2GSYerv X3uIML4IACZqFjWM61bTsiE5nMUtz93qsWpKa53MJDnn2jqVxS2ASqbTgrTBBFi0Ql6s SkEA== X-Gm-Message-State: AOAM533GTwDeJ8a3GT70IGKvV0HpfT1FAQYeBaVITUaSTVORLYIrPdxj Qm8qJw9O7lSayMBsPDmdqx6nmVvuLMGtSf6f1iStck9ObETlAt4XjUDivVEcUkTTXUQ3lnxIoFH dGFHiJPkayzRurm0= X-Received: by 2002:a05:600c:1293:: with SMTP id t19mr604333wmd.34.1601565930084; Thu, 01 Oct 2020 08:25:30 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyn+T0LHGJczjvENR20UHEMXnQi0jr9hF7e22pIdDmvVZEndUedaeoY5prCacFwTEFfG6q3mg== X-Received: by 2002:a05:600c:1293:: with SMTP id t19mr604314wmd.34.1601565929894; Thu, 01 Oct 2020 08:25:29 -0700 (PDT) Received: from [192.168.1.36] (74.red-83-53-161.dynamicip.rima-tde.net. [83.53.161.74]) by smtp.gmail.com with ESMTPSA id 185sm478095wma.18.2020.10.01.08.25.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 01 Oct 2020 08:25:29 -0700 (PDT) Subject: Re: [PATCH 8/9] hw/block/nvme: add trace event for requests with non-zero status code To: Keith Busch , qemu-block@nongnu.org, qemu-devel@nongnu.org, Klaus Jensen References: <20200930220414.562527-1-kbusch@kernel.org> <20200930220414.562527-9-kbusch@kernel.org> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Autocrypt: addr=philmd@redhat.com; keydata= mQINBDXML8YBEADXCtUkDBKQvNsQA7sDpw6YLE/1tKHwm24A1au9Hfy/OFmkpzo+MD+dYc+7 bvnqWAeGweq2SDq8zbzFZ1gJBd6+e5v1a/UrTxvwBk51yEkadrpRbi+r2bDpTJwXc/uEtYAB GvsTZMtiQVA4kRID1KCdgLa3zztPLCj5H1VZhqZsiGvXa/nMIlhvacRXdbgllPPJ72cLUkXf z1Zu4AkEKpccZaJspmLWGSzGu6UTZ7UfVeR2Hcc2KI9oZB1qthmZ1+PZyGZ/Dy+z+zklC0xl XIpQPmnfy9+/1hj1LzJ+pe3HzEodtlVA+rdttSvA6nmHKIt8Ul6b/h1DFTmUT1lN1WbAGxmg CH1O26cz5nTrzdjoqC/b8PpZiT0kO5MKKgiu5S4PRIxW2+RA4H9nq7nztNZ1Y39bDpzwE5Sp bDHzd5owmLxMLZAINtCtQuRbSOcMjZlg4zohA9TQP9krGIk+qTR+H4CV22sWldSkVtsoTaA2 qNeSJhfHQY0TyQvFbqRsSNIe2gTDzzEQ8itsmdHHE/yzhcCVvlUzXhAT6pIN0OT+cdsTTfif MIcDboys92auTuJ7U+4jWF1+WUaJ8gDL69ThAsu7mGDBbm80P3vvUZ4fQM14NkxOnuGRrJxO qjWNJ2ZUxgyHAh5TCxMLKWZoL5hpnvx3dF3Ti9HW2dsUUWICSQARAQABtDJQaGlsaXBwZSBN YXRoaWV1LURhdWTDqSAoUGhpbCkgPHBoaWxtZEByZWRoYXQuY29tPokCVQQTAQgAPwIbDwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4AWIQSJweePYB7obIZ0lcuio/1u3q3A3gUCXsfWwAUJ KtymWgAKCRCio/1u3q3A3ircD/9Vjh3aFNJ3uF3hddeoFg1H038wZr/xi8/rX27M1Vj2j9VH 0B8Olp4KUQw/hyO6kUxqkoojmzRpmzvlpZ0cUiZJo2bQIWnvScyHxFCv33kHe+YEIqoJlaQc JfKYlbCoubz+02E2A6bFD9+BvCY0LBbEj5POwyKGiDMjHKCGuzSuDRbCn0Mz4kCa7nFMF5Jv piC+JemRdiBd6102ThqgIsyGEBXuf1sy0QIVyXgaqr9O2b/0VoXpQId7yY7OJuYYxs7kQoXI 6WzSMpmuXGkmfxOgbc/L6YbzB0JOriX0iRClxu4dEUg8Bs2pNnr6huY2Ft+qb41RzCJvvMyu gS32LfN0bTZ6Qm2A8ayMtUQgnwZDSO23OKgQWZVglGliY3ezHZ6lVwC24Vjkmq/2yBSLakZE 6DZUjZzCW1nvtRK05ebyK6tofRsx8xB8pL/kcBb9nCuh70aLR+5cmE41X4O+MVJbwfP5s/RW 9BFSL3qgXuXso/3XuWTQjJJGgKhB6xXjMmb1J4q/h5IuVV4juv1Fem9sfmyrh+Wi5V1IzKI7 RPJ3KVb937eBgSENk53P0gUorwzUcO+ASEo3Z1cBKkJSPigDbeEjVfXQMzNt0oDRzpQqH2vp apo2jHnidWt8BsckuWZpxcZ9+/9obQ55DyVQHGiTN39hkETy3Emdnz1JVHTU0Q== Message-ID: Date: Thu, 1 Oct 2020 17:25:27 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <20200930220414.562527-9-kbusch@kernel.org> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=216.205.24.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/01 04:25:37 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -23 X-Spam_score: -2.4 X-Spam_bar: -- X-Spam_report: (-2.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.26, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Dmitry Fomichev , Niklas Cassel , Kevin Wolf Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 10/1/20 12:04 AM, Keith Busch wrote: > From: Klaus Jensen > > If a command results in a non-zero status code, trace it. > > Signed-off-by: Klaus Jensen > Signed-off-by: Keith Busch > --- > hw/block/nvme.c | 6 ++++++ > hw/block/trace-events | 1 + > 2 files changed, 7 insertions(+) Reviewed-by: Philippe Mathieu-Daudé