From: Thomas Huth <thuth@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>, qemu-devel@nongnu.org
Cc: Stefan Weil <sw@weilnetz.de>,
Richard Henderson <richard.henderson@linaro.org>,
"Daniel P . Berrange" <berrange@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH 2/2] meson: Warn when TCI is selected but TCG backend is available
Date: Fri, 22 Jan 2021 10:43:27 +0100 [thread overview]
Message-ID: <b661e53c-8c3a-ae19-0250-400d9977dc76@redhat.com> (raw)
In-Reply-To: <20210122092205.1855659-3-philmd@redhat.com>
On 22/01/2021 10.22, Philippe Mathieu-Daudé wrote:
> Some new users get confused with 'TCG' and 'TCI', and enable TCI
> support expecting to enable TCG.
>
> Emit a warning when native TCG backend is available on the
> host architecture, mentioning this is a suboptimal configuration.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> meson.build | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/meson.build b/meson.build
> index 0a645e54662..7aa52d306c6 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -234,6 +234,9 @@
> error('Unsupported CPU @0@, try --enable-tcg-interpreter'.format(cpu))
> endif
> endif
> + if 'CONFIG_TCG_INTERPRETER' in config_host and cpu in supported_cpus
> + warning('Experimental TCI requested while native TCG is available on @0@, suboptimal performance expected'.format(cpu))
> + endif
> accelerators += 'CONFIG_TCG'
> config_host += { 'CONFIG_TCG': 'y' }
> endif
>
Reviewed-by: Thomas Huth <thuth@redhat.com>
... maybe you could also add some wording to the help text of the configure
script? Or maybe we could simply rename the "--enable-tcg-interpreter"
option into "--enable-tci" to avoid confusion with the normal TCG ?
next prev parent reply other threads:[~2021-01-22 9:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-22 9:22 [PATCH 0/2] meson: Try to clarify TCG / TCI options for new users Philippe Mathieu-Daudé
2021-01-22 9:22 ` [PATCH 1/2] meson: Explicit TCG backend used Philippe Mathieu-Daudé
2021-01-22 9:41 ` Thomas Huth
2021-01-22 9:22 ` [PATCH 2/2] meson: Warn when TCI is selected but TCG backend is available Philippe Mathieu-Daudé
2021-01-22 9:43 ` Thomas Huth [this message]
2021-01-22 9:46 ` Philippe Mathieu-Daudé
2021-01-22 9:47 ` Thomas Huth
2021-01-22 9:56 ` Stefan Weil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b661e53c-8c3a-ae19-0250-400d9977dc76@redhat.com \
--to=thuth@redhat.com \
--cc=berrange@redhat.com \
--cc=pbonzini@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).