From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4847AC4742C for ; Mon, 16 Nov 2020 07:33:11 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 99EE92225B for ; Mon, 16 Nov 2020 07:33:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 99EE92225B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:43700 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1keZ0f-0004df-82 for qemu-devel@archiver.kernel.org; Mon, 16 Nov 2020 02:33:09 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:43244) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1keYyu-0003mn-OC for qemu-devel@nongnu.org; Mon, 16 Nov 2020 02:31:20 -0500 Received: from mga01.intel.com ([192.55.52.88]:59781) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1keYyp-0006GA-UA for qemu-devel@nongnu.org; Mon, 16 Nov 2020 02:31:20 -0500 IronPort-SDR: roeQA4pLfT2+j9MbDh0eIQQalHdGo7PgSX7wn8VHghVW2l7Ah12dAJUbuEpbl/GkdZDOsa57NW dEIGEVuWGjiw== X-IronPort-AV: E=McAfee;i="6000,8403,9806"; a="188753481" X-IronPort-AV: E=Sophos;i="5.77,481,1596524400"; d="scan'208";a="188753481" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Nov 2020 23:31:10 -0800 IronPort-SDR: tLLsOEQixSNcEf1jpNB8YQToLyGja8ECYPIm4T1XSR8cnrKuZsf+v07sfYfp/duIigVOUdpT6A e5yhb0RV8j1A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,481,1596524400"; d="scan'208";a="533324241" Received: from fmsmsx605.amr.corp.intel.com ([10.18.126.85]) by fmsmga005.fm.intel.com with ESMTP; 15 Nov 2020 23:31:10 -0800 Received: from shsmsx606.ccr.corp.intel.com (10.109.6.216) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Sun, 15 Nov 2020 23:31:10 -0800 Received: from shsmsx605.ccr.corp.intel.com (10.109.6.215) by SHSMSX606.ccr.corp.intel.com (10.109.6.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 16 Nov 2020 15:31:08 +0800 Received: from shsmsx605.ccr.corp.intel.com ([10.109.6.215]) by SHSMSX605.ccr.corp.intel.com ([10.109.6.215]) with mapi id 15.01.1713.004; Mon, 16 Nov 2020 15:31:08 +0800 From: "Zhang, Chen" To: Lukas Straub , qemu-devel Subject: RE: [PATCH 1/2] net/colo-compare.c: Fix memory leak for non-tcp packet Thread-Topic: [PATCH 1/2] net/colo-compare.c: Fix memory leak for non-tcp packet Thread-Index: AQHWu0Elzuw4zb+K2EeJydnV8hB8B6nKXg4A Date: Mon, 16 Nov 2020 07:31:08 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.5.1.3 dlp-reaction: no-action x-originating-ip: [10.239.127.36] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Received-SPF: pass client-ip=192.55.52.88; envelope-from=chen.zhang@intel.com; helo=mga01.intel.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/16 02:31:11 X-ACL-Warn: Detected OS = FreeBSD 9.x or newer [fuzzy] X-Spam_score_int: -68 X-Spam_score: -6.9 X-Spam_bar: ------ X-Spam_report: (-6.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jason Wang , Li Zhijian Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" > -----Original Message----- > From: Lukas Straub > Sent: Sunday, November 15, 2020 7:19 PM > To: qemu-devel > Cc: Zhang, Chen ; Li Zhijian > ; Jason Wang > Subject: [PATCH 1/2] net/colo-compare.c: Fix memory leak for non-tcp > packet >=20 > Additional to removing the packet from the secondary queue, we also need > to free it. >=20 > Signed-off-by: Lukas Straub Looks good to me. Reviewed-by: Zhang Chen Thanks Chen > --- > net/colo-compare.c | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/net/colo-compare.c b/net/colo-compare.c index > 337025b44f..eed0fbb27b 100644 > --- a/net/colo-compare.c > +++ b/net/colo-compare.c > @@ -690,6 +690,7 @@ static void colo_compare_packet(CompareState *s, > Connection *conn, >=20 > if (result) { > colo_release_primary_pkt(s, pkt); > + packet_destroy(result->data, NULL); > g_queue_remove(&conn->secondary_list, result->data); > } else { > /* > -- > 2.20.1