From: Eric Blake <eblake@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Finn Thain" <fthain@telegraphics.com.au>,
qemu-devel@nongnu.org
Cc: jasowang@redhat.com, qemu-stable@nongnu.org, laurent@vivier.eu,
hpoussin@reactos.org, "Paolo Bonzini" <pbonzini@redhat.com>,
aleksandar.rikalo@rt-rk.com,
"Alex Bennée" <alex.bennee@linaro.org>
Subject: Re: [PATCH 00/10] Fixes for DP8393X SONIC device emulation
Date: Sat, 14 Dec 2019 07:45:59 -0600 [thread overview]
Message-ID: <b73284e3-b6e7-1e4d-0d93-6cdcdd0f2ae9@redhat.com> (raw)
In-Reply-To: <b8c42c79-ed61-031d-a7f7-0af82992bd85@redhat.com>
On 12/14/19 7:38 AM, Philippe Mathieu-Daudé wrote:
> On 12/14/19 3:52 AM, Finn Thain wrote:
>> On Fri, 13 Dec 2019, no-reply@patchew.org wrote:
>>
>>> === OUTPUT BEGIN ===
>>> 1/10 Checking commit 9c9ffc38e9b9 (dp8393x: Mask EOL bit from
>>> descriptor addresses)
>>> ERROR: return is not a function, parentheses are not required
>>> #24: FILE: hw/net/dp8393x.c:200:
>>> + return (s->regs[SONIC_URDA] << 16) | (s->regs[SONIC_CRDA] &
>>> 0xfffe);
>>>
>>> ERROR: return is not a function, parentheses are not required
>>> #33: FILE: hw/net/dp8393x.c:220:
>>> + return (s->regs[SONIC_UTDA] << 16) | (s->regs[SONIC_TTDA] &
>>> 0xfffe);
>>>
>>
>> I expect that checkpatch.pl has no idea about operator precedence, but
>> these parentheses could actually be omitted.
You are correct: It's a false positive; you can safely ignore it.
>>
>> I kept them because I don't want readers to have to remember that bit
>> shift operator has higher precedence than bitwise OR operator, or look it
>> up if they don't.
>>
>> The existing code also has those unnecessary parentheses.
>>
>> Please let me know if this patch should include a code style change.
>
> This is a bug in checkpatch. Since this script doesn't have dedicated
> maintainer, I Cc'ed the recent contributors:
However, it's complex enough, and the false positive occurs infrequently
enough, that just ignoring it (instead of trying to patch checkpatch) is
also fine, and probably what will happen.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
next prev parent reply other threads:[~2019-12-14 21:50 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-14 1:25 [PATCH 00/10] Fixes for DP8393X SONIC device emulation Finn Thain
2019-12-14 1:25 ` [PATCH 08/10] dp8393x: Implement packet size limit and RBAE interrupt Finn Thain
2019-12-14 1:25 ` [PATCH 09/10] dp8393x: Don't stop reception upon RBE interrupt assertion Finn Thain
2019-12-14 1:25 ` [PATCH 06/10] dp8393x: Clear RRRA command register bit only when appropriate Finn Thain
2019-12-14 13:31 ` Philippe Mathieu-Daudé
2019-12-14 1:25 ` [PATCH 02/10] dp8393x: Clean up endianness hacks Finn Thain
2019-12-14 1:25 ` [PATCH 05/10] dp8393x: Update LLFA register Finn Thain
2019-12-14 1:25 ` [PATCH 10/10] dp8393x: Don't clobber packet checksum Finn Thain
2019-12-14 13:21 ` Philippe Mathieu-Daudé
2019-12-14 1:25 ` [PATCH 07/10] dp8393x: Implement TBWC0 and TBWC1 registers to restore buffer state Finn Thain
2019-12-14 1:25 ` [PATCH 01/10] dp8393x: Mask EOL bit from descriptor addresses Finn Thain
2019-12-14 13:35 ` Philippe Mathieu-Daudé
2019-12-14 23:21 ` Finn Thain
2019-12-14 1:25 ` [PATCH 04/10] dp8393x: Don't advance RX descriptor twice Finn Thain
2019-12-14 1:25 ` [PATCH 03/10] dp8393x: Have dp8393x_receive() return the packet size Finn Thain
2019-12-14 13:26 ` Philippe Mathieu-Daudé
2019-12-14 1:43 ` [PATCH 00/10] Fixes for DP8393X SONIC device emulation no-reply
2019-12-14 2:52 ` Finn Thain
2019-12-14 13:38 ` Philippe Mathieu-Daudé
2019-12-14 13:45 ` Eric Blake [this message]
2019-12-14 17:17 ` Aleksandar Markovic
2019-12-14 23:16 ` Finn Thain
2019-12-14 23:32 ` Aleksandar Markovic
2019-12-14 23:35 ` Aleksandar Markovic
2019-12-20 4:24 ` Finn Thain
2019-12-23 17:17 ` Philippe Mathieu-Daudé
2019-12-24 0:12 ` NetBSD/arc on MIPS Magnum, was " Finn Thain
2019-12-24 4:33 ` Finn Thain
2019-12-24 6:53 ` Hervé Poussineau
2020-01-06 22:15 ` Finn Thain
2019-12-16 0:36 ` Finn Thain
2019-12-20 4:21 ` Finn Thain
2019-12-20 11:38 ` Aleksandar Markovic
2019-12-20 12:03 ` Aleksandar Markovic
2019-12-20 12:54 ` Laurent Vivier
2019-12-20 23:22 ` Finn Thain
2019-12-21 12:03 ` Aleksandar Markovic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b73284e3-b6e7-1e4d-0d93-6cdcdd0f2ae9@redhat.com \
--to=eblake@redhat.com \
--cc=aleksandar.rikalo@rt-rk.com \
--cc=alex.bennee@linaro.org \
--cc=fthain@telegraphics.com.au \
--cc=hpoussin@reactos.org \
--cc=jasowang@redhat.com \
--cc=laurent@vivier.eu \
--cc=pbonzini@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).