qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Eduardo Habkost <ehabkost@redhat.com>, qemu-devel@nongnu.org
Cc: qemu-block@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [PATCH 01/10] image-fuzzer: Open image files in binary mode
Date: Thu, 17 Oct 2019 11:55:49 +0200	[thread overview]
Message-ID: <b76b52af-c1b7-273e-cfdf-2d061ee37de2@redhat.com> (raw)
In-Reply-To: <20191016192430.25098-2-ehabkost@redhat.com>

On 10/16/19 9:24 PM, Eduardo Habkost wrote:
> This probably never caused problems because on Linux there's no
> actual newline conversion happening, but on Python 3 the
> binary/text distinction is stronger and we must explicitly open
> the image file in binary mode.
> 
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> ---
>   tests/image-fuzzer/qcow2/layout.py | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/image-fuzzer/qcow2/layout.py b/tests/image-fuzzer/qcow2/layout.py
> index 675877da96..c57418fa15 100644
> --- a/tests/image-fuzzer/qcow2/layout.py
> +++ b/tests/image-fuzzer/qcow2/layout.py
> @@ -503,7 +503,7 @@ class Image(object):
>   
>       def write(self, filename):
>           """Write an entire image to the file."""
> -        image_file = open(filename, 'w')
> +        image_file = open(filename, 'wb')
>           for field in self:
>               image_file.seek(field.offset)
>               image_file.write(struct.pack(field.fmt, field.value))
> 

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>


  reply	other threads:[~2019-10-17  9:56 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-16 19:24 [PATCH 00/10] image-fuzzer: Port to Python 3 Eduardo Habkost
2019-10-16 19:24 ` [PATCH 01/10] image-fuzzer: Open image files in binary mode Eduardo Habkost
2019-10-17  9:55   ` Philippe Mathieu-Daudé [this message]
2019-10-16 19:24 ` [PATCH 02/10] image-fuzzer: Write bytes instead of string to image file Eduardo Habkost
2019-10-17  9:56   ` Philippe Mathieu-Daudé
2019-10-16 19:24 ` [PATCH 03/10] image-fuzzer: Explicitly use integer division operator Eduardo Habkost
2019-10-16 19:24 ` [PATCH 04/10] image-fuzzer: Use io.StringIO Eduardo Habkost
2019-10-16 19:24 ` [PATCH 05/10] image-fuzzer: Use %r for all fiels at Field.__repr__() Eduardo Habkost
2019-10-17 21:08   ` John Snow
2019-10-16 19:24 ` [PATCH 06/10] image-fuzzer: Return bytes objects on string fuzzing functions Eduardo Habkost
2019-10-16 19:24 ` [PATCH 07/10] image-fuzzer: Use bytes constant for field values Eduardo Habkost
2019-10-17  9:55   ` Philippe Mathieu-Daudé
2019-10-16 19:24 ` [PATCH 08/10] image-fuzzer: Encode file name and file format to bytes Eduardo Habkost
2019-10-16 19:24 ` [PATCH 09/10] image-fuzzer: Run using python3 Eduardo Habkost
2019-10-16 19:24 ` [PATCH 10/10] image-fuzzer: Use errors parameter of subprocess.Popen() Eduardo Habkost
2019-10-17 21:11 ` [PATCH 00/10] image-fuzzer: Port to Python 3 John Snow
2019-10-17 21:29   ` Eduardo Habkost
2019-10-17 22:41     ` John Snow
2019-10-22 20:26     ` Eduardo Habkost
2019-10-23 15:42       ` John Snow
2019-11-05 15:35 ` Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b76b52af-c1b7-273e-cfdf-2d061ee37de2@redhat.com \
    --to=philmd@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).