From: Richard Henderson <richard.henderson@linaro.org>
To: Jason Thorpe <thorpej@me.com>, qemu-devel@nongnu.org
Subject: Re: [PATCH 3/8] Fix initialization of the hwrpb.hwrpb.cpuid field.
Date: Sat, 5 Jun 2021 17:28:18 -0700 [thread overview]
Message-ID: <b89efddf-4960-07c4-1c13-f2eb80c44117@linaro.org> (raw)
In-Reply-To: <20210603035317.6814-4-thorpej@me.com>
On 6/2/21 8:53 PM, Jason Thorpe wrote:
> Initialize the hwrpb.hwrpb.cpuid field with the primary CPU ID, not
> the processor type, as per the architecture specification. Some
> operating systems check and assert this.
>
> Improve a couple of comments.
>
> Signed-off-by: Jason Thorpe<thorpej@me.com>
> ---
> init.c | 29 ++++++++++++++++++++++-------
> 1 file changed, 22 insertions(+), 7 deletions(-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
> @@ -257,8 +272,8 @@ init_i8259 (void)
> outb(0x04, PORT_PIC1_DATA); /* ICW3: slave control INTC2 */
> outb(0x01, PORT_PIC1_DATA); /* ICW4 */
>
> - /* Initialize level triggers. The CY82C693UB that's on real alpha
> - hardware doesn't have this; this is a PIIX extension. However,
> + /* Initialize level triggers. The CY82C693UB that's on some real alpha
> + systems controls these differently; we assume a PIIX here. However,
> QEMU doesn't implement regular level triggers. */
> outb(0xff, PORT_PIC2_ELCR);
> outb(0xff, PORT_PIC1_ELCR);
I'll split this out to a separate patch.
r~
next prev parent reply other threads:[~2021-06-06 0:29 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-03 3:53 [PATCH 0/8] PALcode fixes required to run NetBSD/alpha Jason Thorpe
2021-06-03 3:53 ` [PATCH 1/8] Make qemu-palcode build environment standalone. NFC Jason Thorpe
2021-06-05 23:27 ` Richard Henderson
2021-06-03 3:53 ` [PATCH 2/8] Fix delivery of unaligned access exceptions Jason Thorpe
2021-06-05 23:28 ` Richard Henderson
2021-06-03 3:53 ` [PATCH 3/8] Fix initialization of the hwrpb.hwrpb.cpuid field Jason Thorpe
2021-06-06 0:28 ` Richard Henderson [this message]
2021-06-03 3:53 ` [PATCH 4/8] Make some PCI macros available to other files. NFC Jason Thorpe
2021-06-06 0:32 ` Richard Henderson
2021-06-03 3:53 ` [PATCH 5/8] Fix incorrect initialization of PCI BARs Jason Thorpe
2021-06-03 9:24 ` Philippe Mathieu-Daudé
2021-06-04 18:23 ` Jason Thorpe
2021-06-06 0:41 ` Richard Henderson
2021-06-03 3:53 ` [PATCH 6/8] Provide interrupt mapping information in PCI config registers Jason Thorpe
2021-06-06 1:49 ` Richard Henderson
2021-06-03 3:53 ` [PATCH 7/8] Provide a Console Terminal Block in the HWRPB Jason Thorpe
2021-06-06 19:27 ` Richard Henderson
2021-06-06 20:12 ` Jason Thorpe
2021-06-03 3:53 ` [PATCH 8/8] Fixes for seconday CPU start-up Jason Thorpe
2021-06-06 20:27 ` Richard Henderson
2021-06-03 9:26 ` [PATCH 0/8] PALcode fixes required to run NetBSD/alpha Philippe Mathieu-Daudé
2021-06-06 20:30 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b89efddf-4960-07c4-1c13-f2eb80c44117@linaro.org \
--to=richard.henderson@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=thorpej@me.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).