From: Laszlo Ersek <lersek@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
qemu-devel@nongnu.org
Cc: "Fam Zheng" <fam@euphon.net>,
"Michal Prívozník" <mprivozn@redhat.com>,
"Igor Mammedov" <imammedo@redhat.com>,
"Gerd Hoffmann" <kraxel@redhat.com>,
"Michael S . Tsirkin" <mst@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 5/5] .travis.yml: Build and install EDK2 roms
Date: Fri, 14 Jun 2019 20:31:48 +0200 [thread overview]
Message-ID: <b8aad7bf-1dec-5c1d-1b76-d15b639e4953@redhat.com> (raw)
In-Reply-To: <19958c32-2df9-cccf-3f05-c2fa0fe3dec2@redhat.com>
On 06/13/19 18:59, Philippe Mathieu-Daudé wrote:
> Hi Laszlo,
>
> On 3/12/19 5:29 PM, Laszlo Ersek wrote:
>> On 03/11/19 01:30, Philippe Mathieu-Daudé wrote:
>>> Add a job to build and install the EDK2 platform firmware binaries.
>>>
>>> This job is only triggered if the last commit matches the EDK2
>>> name (case insensitive), or when tag are created (such releases
>>> or release candidates).
>>>
>>> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>>> ---
>>> .travis.yml | 21 +++++++++++++++++++++
>>> 1 file changed, 21 insertions(+)
>>>
>>> diff --git a/.travis.yml b/.travis.yml
>>> index e942175dd3..628cc52c99 100644
>>> --- a/.travis.yml
>>> +++ b/.travis.yml
>>> @@ -258,3 +258,24 @@ matrix:
>>> - env:
>>> - CONFIG="--disable-system"
>>> - TEST_CMD="make -j3 check-tcg V=1"
>>> +
>>> +
>>> + # EDK2 roms builds
>>> + - if: tag IS present OR commit_message =~ /(edk2|EDK2)/
>>> + env:
>>> + - CONFIG="--disable-system --disable-user --prefix=$PWD/dist"
>>> + - EDK2_BUILD_OPTIONS="--quiet --silent"
>>> + script:
>>> + - git submodule update --init roms/edk2
>>> + - make -j3
>>> + - make -C roms efi -j2
>>> + - make install
>>> + addons:
>>> + apt:
>>> + packages:
>>> + - dos2unix
>>> + - gcc-aarch64-linux-gnu
>>> + - gcc-arm-linux-gnueabihf
>>> + - iasl
>>> + - nasm
>>> + - uuid-dev
>>>
>>
>> Regardless of what problem we're trying to address with "--quiet
>> --silent", those options are wrong. You certainly want detailed build
>> logs for the case a CI job fails (at build time or at runtime).
>
> On Travis we get:
>
> The job exceeded the maximum log length, and has been terminated.
> (https://travis-ci.org/philmd/qemu/jobs/545329905)
>
> So I moved to GitLab, but we still get:
>
> "Job's log exceeded limit of 4194304 bytes."
> (https://gitlab.com/philmd/qemu/-/jobs/230772314)
>
> Regarding the options to pass to edk2-build.sh,
>
> $ build --help
> -j LOGFILE, --log=LOGFILE
> Put log in specified file as well as on console.
> -s, --silent Make use of silent mode of (n)make.
> -q, --quiet Disable all messages except FATAL ERRORS.
> -v, --verbose Turn on verbose output with informational messages
> printed, including library instances selected, final
> dependency expression, and warning messages, etc.
>
> '--log' duplicate the output, and I don't want to reduce the log
> details, so I understand I should use:
>
> ./edk2-build.sh [...] --log=build.log >/dev/null || cat build.log
>
> Is that correct? But then I'd need to modify Makefile.edk2 to redirect
> stdout.
Would it be possible to invoke the outermost make like this?
make -C roms -j2 efi >make.roms.efi.log 2>&1 \
|| ( tail -c 2M make.roms.efi.log; false )
Thanks
Laszlo
>
>> The reason why I only include DEBUG firmware builds in the edk2 bundling
>> series is similar -- RELEASE builds lack DEBUG messages and ASSERT()s,
>> and as such they are 100% unsupportable in my book. Bugs in software are
>> the norm, not the exception, so we should allow (even force) the user
>> (and remote systems) to provide as much information as they can.
>
> Sure, we have the same book here ;)
>
> Regards,
>
> Phil.
>
next prev parent reply other threads:[~2019-06-14 19:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-11 0:30 [Qemu-devel] [PATCH 0/5] travis-ci: Build EDK2 roms Philippe Mathieu-Daudé
2019-03-11 0:30 ` [Qemu-devel] [PATCH 1/5] roms/edk2: Avoid bashism in Makefile 'shell' function Philippe Mathieu-Daudé
2019-03-11 0:30 ` [Qemu-devel] [PATCH 2/5] roms/edk2: Avoid bashism in script Philippe Mathieu-Daudé
2019-03-11 0:30 ` [Qemu-devel] [PATCH 3/5] roms/edk2: Pass extra arguments to the build script via EDK2_BUILD_OPTIONS Philippe Mathieu-Daudé
2019-03-11 0:30 ` [Qemu-devel] [PATCH 4/5] NOTFORMERGE roms/edk2: Use arm-linux-gnueabihf-gcc on Debian based distribs Philippe Mathieu-Daudé
2019-03-11 0:30 ` [Qemu-devel] [PATCH 5/5] .travis.yml: Build and install EDK2 roms Philippe Mathieu-Daudé
[not found] ` <ecd8aaf1-f75e-abd0-48b1-e80a227f01c3@redhat.com>
2019-06-13 16:59 ` Philippe Mathieu-Daudé
2019-06-14 18:31 ` Laszlo Ersek [this message]
2019-06-14 18:44 ` Alex Bennée
2019-09-21 9:14 ` Philippe Mathieu-Daudé
2019-06-14 18:32 ` [Qemu-devel] " Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b8aad7bf-1dec-5c1d-1b76-d15b639e4953@redhat.com \
--to=lersek@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=fam@euphon.net \
--cc=imammedo@redhat.com \
--cc=kraxel@redhat.com \
--cc=mprivozn@redhat.com \
--cc=mst@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).