From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB493C433E0 for ; Sun, 17 Jan 2021 16:44:06 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1869B20720 for ; Sun, 17 Jan 2021 16:44:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1869B20720 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:43990 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l1B9o-0002Ag-U5 for qemu-devel@archiver.kernel.org; Sun, 17 Jan 2021 11:44:04 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:60810) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l1B99-0001fN-Ff for qemu-devel@nongnu.org; Sun, 17 Jan 2021 11:43:23 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:27436) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1l1B96-0008ON-9K for qemu-devel@nongnu.org; Sun, 17 Jan 2021 11:43:22 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1610901798; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=48WKtWO3GLc07dUk+0V7gia0jN9m+GtRLmTQyQFnvYU=; b=iJKBevtUGUqM2GOgwSPYyWxYT3I3xlft+LukjETzz+avKNMyVFNLdvzMHzcGOZuSIpCZUI D68uhViJPpKCK4W3KuVdYqmYOhHJvduEkx1I3DsapJWjtZxvMf4OheJdibQ6NFyoUBYnEG 8kmHdOM/jwPMG+p7LFyAfnoPfXMvqZk= Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-317-GtiWPLGtNWK7bFO1Be6riw-1; Sun, 17 Jan 2021 11:43:16 -0500 X-MC-Unique: GtiWPLGtNWK7bFO1Be6riw-1 Received: by mail-ed1-f71.google.com with SMTP id t9so676390edd.3 for ; Sun, 17 Jan 2021 08:43:16 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=48WKtWO3GLc07dUk+0V7gia0jN9m+GtRLmTQyQFnvYU=; b=XGEinkBKFJ+c0xJJGlS6F98noekIsC5pbKbtcBUOaVWEpKCzhMmb11vCjGzPAA6vKu sTwfnqnwZCEHcdZEuPlPAdc2CFNVg6PXutB+EdS9pmbzjSL5/zwJ8iza98ptVXu77Gxx /sU/M0kUI2JRTbbE6GdTY9AZ8M9OReJaT+URan9kuA7GSMttiZoepDo8QAlKTwj6BKKf 16NcOC0kN3KcqKqXP3xJzhGxEIPTb5qt4R0KNsY5mmepFWiy9lpKz//YrteAvvpS+3pi o1EJi0X6HG/L88qPwWjkTjmHLrn5KbXhqmNrHEuSCMxKJ2xrxAwPqcgCcNNJ1zkQ6VwY KIzQ== X-Gm-Message-State: AOAM532oNVEMxMW/UAn5MSnh+8CwlenuP392/14g+EjGrZbGU+lAmiJr +CBZq+Pfn8+hNjfH6sf3LQkORzqg0xDcEWAuHyDHozhO60wMr8pZh4QSVqb+l8d/Agkhn7u5EMW BsLcUtUfCObd0//U= X-Received: by 2002:aa7:cb49:: with SMTP id w9mr17218922edt.357.1610901795078; Sun, 17 Jan 2021 08:43:15 -0800 (PST) X-Google-Smtp-Source: ABdhPJxXP5hQ/yiq9vwwSAfYtXPJ4GPAUp0onPS6aWzPaCRayFs/YnTtHvo/1amWv/2kkn/U5nfM1Q== X-Received: by 2002:aa7:cb49:: with SMTP id w9mr17218901edt.357.1610901794816; Sun, 17 Jan 2021 08:43:14 -0800 (PST) Received: from ?IPv6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id dm1sm2764409edb.72.2021.01.17.08.43.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 17 Jan 2021 08:43:13 -0800 (PST) Subject: Re: [PATCH] util/cacheflush: Fix error generated by clang To: Gan Qixin , qemu-devel@nongnu.org, qemu-trivial@nongnu.org References: <20210115075656.717957-1-ganqixin@huawei.com> From: Paolo Bonzini Message-ID: Date: Sun, 17 Jan 2021 17:43:12 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20210115075656.717957-1-ganqixin@huawei.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=pbonzini@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=216.205.24.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -32 X-Spam_score: -3.3 X-Spam_bar: --- X-Spam_report: (-3.3 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.189, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.252, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kuhn.chenqun@huawei.com, Richard Henderson , zhang.zhanghailiang@huawei.com, Euler Robot Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 15/01/21 08:56, Gan Qixin wrote: > When compiling qemu-fuzz-i386 on aarch64 host, clang reported the following > error: > > ../util/cacheflush.c:38:44: error: value size does not match register size > specified by the constraint and modifier [-Werror,-Wasm-operand-widths] > asm volatile("mrs\t%0, ctr_el0" : "=r"(save_ctr_el0)); > ^ > ../util/cacheflush.c:38:24: note: use constraint modifier "w" > asm volatile("mrs\t%0, ctr_el0" : "=r"(save_ctr_el0)); > ^~ > %w0 > > Modify the type of save_ctr_el0 to uint64_t to fix it. > > Reported-by: Euler Robot > Signed-off-by: Gan Qixin > --- > Cc: Richard Henderson > Cc: Paolo Bonzini > --- > util/cacheflush.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/util/cacheflush.c b/util/cacheflush.c > index 6a20723902..933355b0c9 100644 > --- a/util/cacheflush.c > +++ b/util/cacheflush.c > @@ -32,7 +32,7 @@ void flush_idcache_range(uintptr_t rx, uintptr_t rw, size_t len) > * We want to save the whole contents of CTR_EL0, so that we > * have more than the linesize, but also IDC and DIC. > */ > -static unsigned int save_ctr_el0; > +static uint64_t save_ctr_el0; > static void __attribute__((constructor)) init_ctr_el0(void) > { > asm volatile("mrs\t%0, ctr_el0" : "=r"(save_ctr_el0)); > @@ -46,9 +46,9 @@ void flush_idcache_range(uintptr_t rx, uintptr_t rw, size_t len) > { > const unsigned CTR_IDC = 1u << 28; > const unsigned CTR_DIC = 1u << 29; > - const unsigned int ctr_el0 = save_ctr_el0; > - const uintptr_t icache_lsize = 4 << extract32(ctr_el0, 0, 4); > - const uintptr_t dcache_lsize = 4 << extract32(ctr_el0, 16, 4); > + const uint64_t ctr_el0 = save_ctr_el0; > + const uintptr_t icache_lsize = 4 << extract64(ctr_el0, 0, 4); > + const uintptr_t dcache_lsize = 4 << extract64(ctr_el0, 16, 4); > uintptr_t p; > > /* > Queued, thanks.