From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64D9FC41604 for ; Wed, 7 Oct 2020 16:49:50 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BC752206FC for ; Wed, 7 Oct 2020 16:49:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Pqm+fcOW" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BC752206FC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:58420 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kQCdQ-0000kk-DB for qemu-devel@archiver.kernel.org; Wed, 07 Oct 2020 12:49:48 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41138) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kQCDt-0003zz-W7 for qemu-devel@nongnu.org; Wed, 07 Oct 2020 12:23:27 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:52823) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kQCDq-0005iq-2U for qemu-devel@nongnu.org; Wed, 07 Oct 2020 12:23:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1602087801; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3c8sxjL7MKquoo3fzCSguchValwZLe0rt4SorCHvOs4=; b=Pqm+fcOWPd3K1LWwG81o4NeegiI2YnMe+6m1+vVLhM+T15bzZyht/Dk4t1UE55kNQjWHjl yJcZ75X352i6+PMsFkyNpJcrnlYDJEg4C3UcrNoMqphtMKJmttqEasuBlE1fE+w/FRNImQ YJfe5+jf9Sto9DzMNt+qc/mxFrPgJdI= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-511-VD4RR4nhMfSQW2geLn5XjA-1; Wed, 07 Oct 2020 12:23:19 -0400 X-MC-Unique: VD4RR4nhMfSQW2geLn5XjA-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 0DDE210BBEC6 for ; Wed, 7 Oct 2020 16:23:19 +0000 (UTC) Received: from [10.10.120.38] (ovpn-120-38.rdu2.redhat.com [10.10.120.38]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8CC4B19C4F; Wed, 7 Oct 2020 16:23:18 +0000 (UTC) Subject: Re: [PATCH v5 29/36] qapi/gen.py: Remove unused parameter To: Markus Armbruster References: <20201005195158.2348217-1-jsnow@redhat.com> <20201005195158.2348217-30-jsnow@redhat.com> <871riacjjv.fsf@dusky.pond.sub.org> From: John Snow Message-ID: Date: Wed, 7 Oct 2020 12:23:18 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <871riacjjv.fsf@dusky.pond.sub.org> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=jsnow@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=216.205.24.124; envelope-from=jsnow@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/07 00:54:30 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.742, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel@nongnu.org, Eduardo Habkost , Cleber Rosa Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 10/7/20 8:22 AM, Markus Armbruster wrote: > John Snow writes: > >> module_basename doesn't use the 'what' argument, so remove it. > > _module_dirname(), I suppose. > My brain just translates stuff I didn't ask it to all the time. (Fixed.) >> >> Signed-off-by: John Snow >> Reviewed-by: Eduardo Habkost >> Reviewed-by: Cleber Rosa >> --- >> scripts/qapi/gen.py | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/scripts/qapi/gen.py b/scripts/qapi/gen.py >> index d0391cd8718..3624162bb77 100644 >> --- a/scripts/qapi/gen.py >> +++ b/scripts/qapi/gen.py >> @@ -259,7 +259,7 @@ def _is_user_module(name: Optional[str]) -> bool: >> def _is_builtin_module(name: Optional[str]) -> bool: >> return not name >> >> - def _module_dirname(self, what: str, name: Optional[str]) -> str: >> + def _module_dirname(self, name: Optional[str]) -> str: >> if self._is_user_module(name): >> return os.path.dirname(name) >> return '' >> @@ -277,7 +277,7 @@ def _module_basename(self, what: str, name: Optional[str]) -> str: >> return ret >> >> def _module_filename(self, what: str, name: Optional[str]) -> str: >> - return os.path.join(self._module_dirname(what, name), >> + return os.path.join(self._module_dirname(name), >> self._module_basename(what, name)) >> >> def _add_module(self, name: Optional[str], blurb: str) -> None: