From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 815A2C47404 for ; Wed, 9 Oct 2019 21:08:30 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5085E206B6 for ; Wed, 9 Oct 2019 21:08:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5085E206B6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:58124 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iIJC9-0001y2-EZ for qemu-devel@archiver.kernel.org; Wed, 09 Oct 2019 17:08:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48011) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iIH9F-0005GA-4g for qemu-devel@nongnu.org; Wed, 09 Oct 2019 14:57:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iIH9D-00047y-SA for qemu-devel@nongnu.org; Wed, 09 Oct 2019 14:57:20 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40018) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iIH9A-00045n-Iy; Wed, 09 Oct 2019 14:57:16 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 2E2B918C4289; Wed, 9 Oct 2019 18:57:14 +0000 (UTC) Received: from [10.3.116.162] (ovpn-116-162.phx2.redhat.com [10.3.116.162]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7B5C35DA8C; Wed, 9 Oct 2019 18:57:13 +0000 (UTC) Subject: Re: [PATCH 0/5] block/dirty-bitmap: check number and size constraints against queued bitmaps To: John Snow , qemu-block@nongnu.org, qemu-devel@nongnu.org References: <20190606184159.979-1-jsnow@redhat.com> From: Eric Blake Organization: Red Hat, Inc. Message-ID: Date: Wed, 9 Oct 2019 13:57:12 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.0 MIME-Version: 1.0 In-Reply-To: <20190606184159.979-1-jsnow@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.6.2 (mx1.redhat.com [10.5.110.62]); Wed, 09 Oct 2019 18:57:14 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fam Zheng , Kevin Wolf , vsementsov@virtuozzo.com, aihua liang , Markus Armbruster , Max Reitz Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 6/6/19 1:41 PM, John Snow wrote: > When adding new persistent dirty bitmaps, we only check constraints > against currently stored bitmaps, and ignore the pending number and size > of any bitmaps yet to be stored. > > Rework the "can_store" and "remove" interface to explicit "add" and "remove", > and begin keeping track of the queued burden when adding new bitmaps. > > Reported-by: aihua liang > Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1712636 > > John Snow (5): > block/qcow2-bitmap: allow bitmap_list_load to return an error code > block/dirty-bitmap: Refactor bdrv_can_store_new_bitmap > block/dirty-bitmap: rework bdrv_remove_persistent_dirty_bitmap > block/qcow2-bitmap: Count queued bitmaps towards nb_bitmaps > block/qcow2-bitmap: Count queued bitmaps towards directory_size Is this series worth reviving as a v2, as it solves a corner-case bug? -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org