From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54A14C433E0 for ; Thu, 28 May 2020 07:27:34 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2E214207BC for ; Thu, 28 May 2020 07:27:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2E214207BC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=ispras.ru Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:35120 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jeCwv-0005Bx-Cj for qemu-devel@archiver.kernel.org; Thu, 28 May 2020 03:27:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50408) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jeCwA-0004Xj-N8 for qemu-devel@nongnu.org; Thu, 28 May 2020 03:26:46 -0400 Received: from mail.ispras.ru ([83.149.199.45]:57540) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jeCw9-0000ul-C7 for qemu-devel@nongnu.org; Thu, 28 May 2020 03:26:46 -0400 Received: from [192.168.0.183] (unknown [62.118.151.149]) by mail.ispras.ru (Postfix) with ESMTPSA id 2600DCD462; Thu, 28 May 2020 10:26:42 +0300 (MSK) Subject: Re: [PATCH v2 04/11] tests/acceptance: add kernel record/replay test for x86_64 To: =?UTF-8?Q?Alex_Benn=c3=a9e?= , Pavel Dovgalyuk References: <159057543840.16818.14393433996899521784.stgit@pasha-ThinkPad-X280> <159057546117.16818.15607496040935344350.stgit@pasha-ThinkPad-X280> <87v9kh5qtm.fsf@linaro.org> <87lfld5ozj.fsf@linaro.org> From: Pavel Dovgalyuk Message-ID: Date: Thu, 28 May 2020 10:26:41 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <87lfld5ozj.fsf@linaro.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Received-SPF: pass client-ip=83.149.199.45; envelope-from=dovgaluk@ispras.ru; helo=mail.ispras.ru X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/28 02:12:01 X-ACL-Warn: Detected OS = Linux 3.11 and newer X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: wrampazz@redhat.com, qemu-devel@nongnu.org, pavel.dovgaluk@ispras.ru, crosa@redhat.com, pbonzini@redhat.com, philmd@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 27.05.2020 19:20, Alex Bennée wrote: > Alex Bennée writes: > >> Pavel Dovgalyuk writes: >> >>> This patch adds a test for record/replay an execution of x86_64 machine. >>> Execution scenario includes simple kernel boot, which allows testing >>> basic hardware interaction in RR mode. >>> >>> Signed-off-by: Pavel Dovgalyuk >>> --- >>> 0 files changed >>> >>> diff --git a/tests/acceptance/replay_kernel.py b/tests/acceptance/replay_kernel.py >>> index b8b277ad2f..c7526f1aba 100644 >>> --- a/tests/acceptance/replay_kernel.py >>> +++ b/tests/acceptance/replay_kernel.py >>> @@ -55,3 +55,19 @@ class ReplayKernel(LinuxKernelUtils): >>> True, shift, args) >>> self.run_vm(kernel_path, kernel_command_line, console_pattern, >>> False, shift, args) >>> + >>> + def test_x86_64_pc(self): >>> + """ >>> + :avocado: tags=arch:x86_64 >>> + :avocado: tags=machine:pc >>> + """ >>> + kernel_url = ('https://archives.fedoraproject.org/pub/archive/fedora' >>> + '/linux/releases/29/Everything/x86_64/os/images/pxeboot' >>> + '/vmlinuz') >>> + kernel_hash = '23bebd2680757891cf7adedb033532163a792495' >>> + kernel_path = self.fetch_asset(kernel_url, asset_hash=kernel_hash) >>> + >>> + kernel_command_line = self.KERNEL_COMMON_COMMAND_LINE + >>> 'console=ttyS0' >> I note that: >> >> KERNEL_COMMON_COMMAND_LINE = 'printk.time=0 ' >> >> and given we are looking for repeatability here maybe we should use our >> own command line so we can compare the recorded and replayed boot? > To build on that I think a command line like: > > KERNEL_COMMON_COMMAND_LINE = 'printk.time=1 panic=-1 ' > > called with --no-reboot and a pattern: > > console_pattern = 'VFS: Cannot open root device' > > You will run more of the kernel (importantly with timestamps > 0.000) so > we can have a better compare between the recorded and replayed run. > This is reasonable, thank you.