From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>,
qemu-devel@nongnu.org, alxndr@bu.edu, laurent@vivier.eu,
pbonzini@redhat.com
Subject: Re: [PATCH v3 03/11] esp: consolidate esp_cmdfifo_push() into esp_fifo_push()
Date: Thu, 1 Apr 2021 10:15:15 +0200 [thread overview]
Message-ID: <bc8795c0-4fc6-a923-0458-f2ac0feb590c@amsat.org> (raw)
In-Reply-To: <20210401074933.9923-4-mark.cave-ayland@ilande.co.uk>
On 4/1/21 9:49 AM, Mark Cave-Ayland wrote:
> Each FIFO currently has its own push functions with the only difference being
> the capacity check. The original reason for this was that the fifo8
> implementation doesn't have a formal API for retrieving the FIFO capacity,
> however there are multiple examples within QEMU where the capacity field is
> accessed directly.
So the Fifo8 API is not complete / practical.
> Change esp_fifo_push() to access the FIFO capacity directly and then consolidate
> esp_cmdfifo_push() into esp_fifo_push().
>
> Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
> ---
> hw/scsi/esp.c | 27 ++++++++-------------------
> 1 file changed, 8 insertions(+), 19 deletions(-)
>
> diff --git a/hw/scsi/esp.c b/hw/scsi/esp.c
> index 26fe1dcb9d..16aaf8be93 100644
> --- a/hw/scsi/esp.c
> +++ b/hw/scsi/esp.c
> @@ -98,16 +98,15 @@ void esp_request_cancelled(SCSIRequest *req)
> }
> }
>
> -static void esp_fifo_push(ESPState *s, uint8_t val)
> +static void esp_fifo_push(Fifo8 *fifo, uint8_t val)
> {
> - if (fifo8_num_used(&s->fifo) == ESP_FIFO_SZ) {
> + if (fifo8_num_used(fifo) == fifo->capacity) {
> trace_esp_error_fifo_overrun();
> return;
> }
>
> - fifo8_push(&s->fifo, val);
> + fifo8_push(fifo, val);
> }
> -
Spurious line removal?
> static uint8_t esp_fifo_pop(ESPState *s)
> {
> if (fifo8_is_empty(&s->fifo)) {
> @@ -117,16 +116,6 @@ static uint8_t esp_fifo_pop(ESPState *s)
> return fifo8_pop(&s->fifo);
> }
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
next prev parent reply other threads:[~2021-04-01 8:21 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-01 7:49 [PATCH v3 00/11] esp: fix asserts/segfaults discovered by fuzzer Mark Cave-Ayland
2021-04-01 7:49 ` [PATCH v3 01/11] esp: always check current_req is not NULL before use in DMA callbacks Mark Cave-Ayland
2021-04-01 7:49 ` [PATCH v3 02/11] esp: rework write_response() to avoid using the FIFO for DMA transactions Mark Cave-Ayland
2021-04-01 8:26 ` Philippe Mathieu-Daudé
2021-04-01 7:49 ` [PATCH v3 03/11] esp: consolidate esp_cmdfifo_push() into esp_fifo_push() Mark Cave-Ayland
2021-04-01 8:15 ` Philippe Mathieu-Daudé [this message]
2021-04-01 8:50 ` Mark Cave-Ayland
2021-04-01 9:16 ` Philippe Mathieu-Daudé
2021-04-01 7:49 ` [PATCH v3 04/11] esp: consolidate esp_cmdfifo_pop() into esp_fifo_pop() Mark Cave-Ayland
2021-04-01 8:15 ` Philippe Mathieu-Daudé
2021-04-01 7:49 ` [PATCH v3 05/11] esp: introduce esp_fifo_pop_buf() and use it instead of fifo8_pop_buf() Mark Cave-Ayland
2021-04-01 9:34 ` Philippe Mathieu-Daudé
2021-04-01 10:51 ` Mark Cave-Ayland
2021-04-01 18:05 ` Philippe Mathieu-Daudé
2021-04-01 7:49 ` [PATCH v3 06/11] esp: ensure cmdfifo is not empty and current_dev is non-NULL Mark Cave-Ayland
2021-04-01 8:17 ` Philippe Mathieu-Daudé
2021-04-01 7:49 ` [PATCH v3 07/11] esp: don't underflow cmdfifo in do_cmd() Mark Cave-Ayland
2021-04-01 8:19 ` Philippe Mathieu-Daudé
2021-04-01 8:51 ` Mark Cave-Ayland
2021-04-01 7:49 ` [PATCH v3 08/11] esp: don't overflow cmdfifo in get_cmd() Mark Cave-Ayland
2021-04-01 8:19 ` Philippe Mathieu-Daudé
2021-04-01 8:56 ` Mark Cave-Ayland
2021-04-01 7:49 ` [PATCH v3 09/11] esp: don't overflow cmdfifo if TC is larger than the cmdfifo size Mark Cave-Ayland
2021-04-01 7:49 ` [PATCH v3 10/11] esp: don't reset async_len directly in esp_select() if cancelling request Mark Cave-Ayland
2021-04-01 7:49 ` [PATCH v3 11/11] tests/qtest: add tests for am53c974 device Mark Cave-Ayland
2021-04-01 16:55 ` Alexander Bulekov
2021-04-02 7:29 ` Mark Cave-Ayland
2021-04-01 17:00 ` [PATCH v3 00/11] esp: fix asserts/segfaults discovered by fuzzer Alexander Bulekov
2021-04-02 7:35 ` Mark Cave-Ayland
2021-04-02 16:20 ` [PATCH] tests/qtest: add one more test for the am53c974 Alexander Bulekov
2021-04-03 14:38 ` Mark Cave-Ayland
2021-04-07 12:08 ` Mark Cave-Ayland
2021-04-07 13:04 ` Mark Cave-Ayland
2021-04-07 14:49 ` Alexander Bulekov
2021-04-07 15:11 ` Mark Cave-Ayland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bc8795c0-4fc6-a923-0458-f2ac0feb590c@amsat.org \
--to=f4bug@amsat.org \
--cc=alxndr@bu.edu \
--cc=laurent@vivier.eu \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).