From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73743C28EBD for ; Fri, 7 Jun 2019 02:26:23 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4AC272064A for ; Fri, 7 Jun 2019 02:26:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4AC272064A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:45523 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hZ4aE-0004sn-Ee for qemu-devel@archiver.kernel.org; Thu, 06 Jun 2019 22:26:22 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44623) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hZ4YH-0004Mw-SW for qemu-devel@nongnu.org; Thu, 06 Jun 2019 22:24:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hZ4YG-0007eO-Se for qemu-devel@nongnu.org; Thu, 06 Jun 2019 22:24:21 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43902) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hZ4YE-0007av-H8; Thu, 06 Jun 2019 22:24:18 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id D71C330C319D; Fri, 7 Jun 2019 02:24:12 +0000 (UTC) Received: from [10.3.116.85] (ovpn-116-85.phx2.redhat.com [10.3.116.85]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 538E67FA30; Fri, 7 Jun 2019 02:24:08 +0000 (UTC) To: John Snow , qemu-block@nongnu.org, qemu-devel@nongnu.org References: <20190606184159.979-1-jsnow@redhat.com> <20190606184159.979-4-jsnow@redhat.com> From: Eric Blake Openpgp: preference=signencrypt Autocrypt: addr=eblake@redhat.com; keydata= xsBNBEvHyWwBCACw7DwsQIh0kAbUXyqhfiKAKOTVu6OiMGffw2w90Ggrp4bdVKmCaEXlrVLU xphBM8mb+wsFkU+pq9YR621WXo9REYVIl0FxKeQo9dyQBZ/XvmUMka4NOmHtFg74nvkpJFCD TUNzmqfcjdKhfFV0d7P/ixKQeZr2WP1xMcjmAQY5YvQ2lUoHP43m8TtpB1LkjyYBCodd+LkV GmCx2Bop1LSblbvbrOm2bKpZdBPjncRNob73eTpIXEutvEaHH72LzpzksfcKM+M18cyRH+nP sAd98xIbVjm3Jm4k4d5oQyE2HwOur+trk2EcxTgdp17QapuWPwMfhaNq3runaX7x34zhABEB AAHNHkVyaWMgQmxha2UgPGVibGFrZUByZWRoYXQuY29tPsLAegQTAQgAJAIbAwULCQgHAwUV CgkICwUWAgMBAAIeAQIXgAUCS8fL9QIZAQAKCRCnoWtKJSdDahBHCACbl/5FGkUqJ89GAjeX RjpAeJtdKhujir0iS4CMSIng7fCiGZ0fNJCpL5RpViSo03Q7l37ss+No+dJI8KtAp6ID+PMz wTJe5Egtv/KGUKSDvOLYJ9WIIbftEObekP+GBpWP2+KbpADsc7EsNd70sYxExD3liwVJYqLc Rw7so1PEIFp+Ni9A1DrBR5NaJBnno2PHzHPTS9nmZVYm/4I32qkLXOcdX0XElO8VPDoVobG6 gELf4v/vIImdmxLh/w5WctUpBhWWIfQDvSOW2VZDOihm7pzhQodr3QP/GDLfpK6wI7exeu3P pfPtqwa06s1pae3ad13mZGzkBdNKs1HEm8x6zsBNBEvHyWwBCADGkMFzFjmmyqAEn5D+Mt4P zPdO8NatsDw8Qit3Rmzu+kUygxyYbz52ZO40WUu7EgQ5kDTOeRPnTOd7awWDQcl1gGBXgrkR pAlQ0l0ReO57Q0eglFydLMi5bkwYhfY+TwDPMh3aOP5qBXkm4qIYSsxb8A+i00P72AqFb9Q7 3weG/flxSPApLYQE5qWGSXjOkXJv42NGS6o6gd4RmD6Ap5e8ACo1lSMPfTpGzXlt4aRkBfvb NCfNsQikLZzFYDLbQgKBA33BDeV6vNJ9Cj0SgEGOkYyed4I6AbU0kIy1hHAm1r6+sAnEdIKj cHi3xWH/UPrZW5flM8Kqo14OTDkI9EtlABEBAAHCwF8EGAEIAAkFAkvHyWwCGwwACgkQp6Fr SiUnQ2q03wgAmRFGDeXzc58NX0NrDijUu0zx3Lns/qZ9VrkSWbNZBFjpWKaeL1fdVeE4TDGm I5mRRIsStjQzc2R9b+2VBUhlAqY1nAiBDv0Qnt+9cLiuEICeUwlyl42YdwpmY0ELcy5+u6wz mK/jxrYOpzXKDwLq5k4X+hmGuSNWWAN3gHiJqmJZPkhFPUIozZUCeEc76pS/IUN72NfprZmF Dp6/QDjDFtfS39bHSWXKVZUbqaMPqlj/z6Ugk027/3GUjHHr8WkeL1ezWepYDY7WSoXwfoAL 2UXYsMAr/uUncSKlfjvArhsej0S4zbqim2ZY6S8aRWw94J3bSvJR+Nwbs34GPTD4Pg== Organization: Red Hat, Inc. Message-ID: Date: Thu, 6 Jun 2019 21:24:07 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190606184159.979-4-jsnow@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="F8gQn3o89Bmc7M2rsqadR8DSHCnWCf8IC" X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.40]); Fri, 07 Jun 2019 02:24:17 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-devel] [PATCH 3/5] block/dirty-bitmap: rework bdrv_remove_persistent_dirty_bitmap X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fam Zheng , Kevin Wolf , vsementsov@virtuozzo.com, Markus Armbruster , Max Reitz Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --F8gQn3o89Bmc7M2rsqadR8DSHCnWCf8IC Content-Type: multipart/mixed; boundary="bRe7Ch9w5zBv12IsZE55ju38W1Aj1Alt8"; protected-headers="v1" From: Eric Blake To: John Snow , qemu-block@nongnu.org, qemu-devel@nongnu.org Cc: Fam Zheng , Max Reitz , Markus Armbruster , Kevin Wolf , vsementsov@virtuozzo.com Message-ID: Subject: Re: [PATCH 3/5] block/dirty-bitmap: rework bdrv_remove_persistent_dirty_bitmap References: <20190606184159.979-1-jsnow@redhat.com> <20190606184159.979-4-jsnow@redhat.com> In-Reply-To: <20190606184159.979-4-jsnow@redhat.com> --bRe7Ch9w5zBv12IsZE55ju38W1Aj1Alt8 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 6/6/19 1:41 PM, John Snow wrote: > Allow propagating error code information from > bdrv_remove_persistent_dirty_bitmap as well. >=20 > Give it an interface that matches the newly revised > bdrv_add_persistent_dirty_bitmap, including removing the persistent fla= g > when the operation succeeds and refusing to operate on bitmaps that are= > not persistent. >=20 > Signed-off-by: John Snow > --- > +++ b/include/block/block_int.h > @@ -540,9 +540,9 @@ struct BlockDriver { > int (*bdrv_add_persistent_dirty_bitmap)(BlockDriverState *bs, > BdrvDirtyBitmap *bitmap, > Error **errp); > - void (*bdrv_remove_persistent_dirty_bitmap)(BlockDriverState *bs, > - const char *name, > - Error **errp); > + int (*bdrv_remove_persistent_dirty_bitmap)(BlockDriverState *bs, > + BdrvDirtyBitmap *bitmap= , > + Error **errp); Would it hurt us (in patch 2 and again here) to add a comment about what each callback is supposed to do? Just because we've been lousy at callback interfaces in the past does not mean that we should continue to omit them. Reviewed-by: Eric Blake --=20 Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org --bRe7Ch9w5zBv12IsZE55ju38W1Aj1Alt8-- --F8gQn3o89Bmc7M2rsqadR8DSHCnWCf8IC Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEccLMIrHEYCkn0vOqp6FrSiUnQ2oFAlz5yscACgkQp6FrSiUn Q2pr2gf/XVIwO/6iak2nPCeXPdKzNIMTo59zXnnWU5hONLp+Oqc86JVQTGjQp2Fm oI+rmLnacWvmHgpa3PxaEeUNQ7wEastR0gzbycL9o7g2sOfBZveDdjNtVDvjtkAN IWsONrzb50KIlxTmVPRpbPC2A0SE8IK0VTfOKbb426kydQje4jZR/8RnnnerXbFG hLmBprzuIOi1lsZ5tQW/MMVGKukruIeZNqwY+bgch/XrJWzv7KfhqDEyNcE3kYuC TEb7zGFegVnP6CAYLeSq3r0s7LQ8ql797M1pxRkDab+TFfG/JyDhfqLoMM7d9Hli FvS+NPsQGY+MdkJoo20xkmXnFjSeOQ== =otkr -----END PGP SIGNATURE----- --F8gQn3o89Bmc7M2rsqadR8DSHCnWCf8IC--