From: Jason Wang <jasowang@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Alexey Kirillov <lekiravi@yandex-team.ru>,
QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [PULL V2 16/20] qapi: net: Add query-netdev command
Date: Wed, 17 Mar 2021 12:16:44 +0800 [thread overview]
Message-ID: <bcd43317-feb1-20aa-946b-758fc44eeba7@redhat.com> (raw)
In-Reply-To: <CAFEAcA94g-5CEf2n=TiZ4yMK6KNyJY3KNv3YnrfmAaiRTo-w7w@mail.gmail.com>
在 2021/3/17 上午5:27, Peter Maydell 写道:
> On Mon, 15 Mar 2021 at 09:15, Jason Wang <jasowang@redhat.com> wrote:
>> From: Alexey Kirillov <lekiravi@yandex-team.ru>
>>
>> The query-netdev command is used to get the configuration of the current
>> network device backends (netdevs).
>> This is the QMP analog of the HMP command "info network" but only for
>> netdevs (i.e. excluding NIC and hubports).
>>
>> The query-netdev command returns an array of objects of the NetdevInfo
>> type, which are an extension of Netdev type. It means that response can
>> be used for netdev-add after small modification. This can be useful for
>> recreate the same netdev configuration.
>>
>> Information about the network device is filled in when it is created or
>> modified and is available through the NetClientState->stored_config.
>>
>> Signed-off-by: Alexey Kirillov <lekiravi@yandex-team.ru>
>> Acked-by: Markus Armbruster <armbru@redhat.com>
>> Signed-off-by: Jason Wang <jasowang@redhat.com>
> Hi; Coverity is doubtful (CID 1450841) about this code:
>
>> @@ -668,12 +686,65 @@ static void net_init_tap_one(const NetdevTapOptions *tap, NetClientState *peer,
>> + if (!stored->has_fds) {
>> + stored->has_fds = true;
>> + stored->fds = g_strdup_printf("%d", fd);
>> + } else {
>> + char *tmp_s = stored->fds;
>> + stored->fds = g_strdup_printf("%s:%d", stored->fds, fd);
>> + g_free(tmp_s);
>> + }
> Here we have a bit of code which maintains stored->fds as a
> colon-separated string of integers, by tacking the new fd onto
> the end of the old string if it's already present.
>
>> @@ -731,6 +813,15 @@ static void net_init_tap_one(const NetdevTapOptions *tap, NetClientState *peer,
>> }
>> options.opaque = (void *)(uintptr_t)vhostfd;
>>
>> + if (!stored->has_vhostfds) {
>> + stored->has_vhostfds = true;
>> + stored->vhostfds = g_strdup_printf("%d", vhostfd);
>> + } else {
>> + char *tmp_s = stored->vhostfds;
>> + stored->vhostfds = g_strdup_printf("%s:%d", stored->fds, vhostfd);
>> + g_free(tmp_s);
>> + }
> Here we have a bit of code that's kind of similar, except that
> the first argument to g_strdup_printf() is 'stored->fds', not
> 'stored->vhostfds'.
>
> Coverity suspects cut-n-paste error -- is it right ?
Yes, stored->vhostfds should be used here.
Alexey, please send patch to fix this.
Thanks
>
> thanks
> -- PMM
>
next prev parent reply other threads:[~2021-03-17 4:17 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-15 9:14 [PULL V2 00/20] Net patches Jason Wang
2021-03-15 9:14 ` [PULL V2 01/20] virtio-net: calculating proper msix vectors on init Jason Wang
2021-03-15 9:14 ` [PULL V2 02/20] net: Fix build error when DEBUG_NET is on Jason Wang
2021-03-15 9:14 ` [PULL V2 03/20] net: validate that ids are well formed Jason Wang
2021-03-15 9:14 ` [PULL V2 04/20] e1000: fail early for evil descriptor Jason Wang
2021-03-15 9:14 ` [PULL V2 05/20] net: introduce qemu_receive_packet() Jason Wang
2021-03-15 9:14 ` [PULL V2 06/20] e1000: switch to use qemu_receive_packet() for loopback Jason Wang
2021-03-15 9:14 ` [PULL V2 07/20] dp8393x: switch to use qemu_receive_packet() for loopback packet Jason Wang
2021-03-15 9:14 ` [PULL V2 08/20] msf2-mac: switch to use qemu_receive_packet() for loopback Jason Wang
2021-03-15 9:14 ` [PULL V2 09/20] sungem: " Jason Wang
2021-03-15 9:14 ` [PULL V2 10/20] tx_pkt: switch to use qemu_receive_packet_iov() " Jason Wang
2021-03-15 9:14 ` [PULL V2 11/20] rtl8139: switch to use qemu_receive_packet() " Jason Wang
2021-03-15 9:14 ` [PULL V2 12/20] pcnet: " Jason Wang
2021-03-15 9:14 ` [PULL V2 13/20] cadence_gem: " Jason Wang
2021-03-15 9:14 ` [PULL V2 14/20] lan9118: " Jason Wang
2021-03-15 9:14 ` [PULL V2 15/20] pvrdma: wean code off pvrdma_ring.h kernel header Jason Wang
2021-03-15 9:14 ` [PULL V2 16/20] qapi: net: Add query-netdev command Jason Wang
2021-03-16 21:27 ` Peter Maydell
2021-03-17 4:16 ` Jason Wang [this message]
2021-03-16 21:37 ` Peter Maydell
2021-03-17 3:34 ` Jason Wang
2021-03-25 2:36 ` Jason Wang
2021-03-15 9:14 ` [PULL V2 17/20] tests: Add tests for " Jason Wang
2021-03-15 9:14 ` [PULL V2 18/20] net: Move NetClientState.info_str to dynamic allocations Jason Wang
2021-03-15 9:14 ` [PULL V2 19/20] hmp: Use QAPI NetdevInfo in hmp_info_network Jason Wang
2021-03-15 9:14 ` [PULL V2 20/20] net: Do not fill legacy info_str for backends Jason Wang
2021-03-16 12:30 ` [PULL V2 00/20] Net patches Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bcd43317-feb1-20aa-946b-758fc44eeba7@redhat.com \
--to=jasowang@redhat.com \
--cc=lekiravi@yandex-team.ru \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).