From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>,
"Dr. David Alan Gilbert (git)" <dgilbert@redhat.com>
Cc: "Thomas Huth" <thuth@redhat.com>,
vsementsov@virtuozzo.com, maozhongyi@cmss.chinamobile.com,
"Cornelia Huck" <cohuck@redhat.com>,
pannengyuan@huawei.com, qemu-devel@nongnu.org,
imammedo@redhat.com, "Alex Bennée" <alex.bennee@linaro.org>
Subject: Re: [PULL 3/9] tests/migration: Reduce autoconverge initial bandwidth
Date: Tue, 9 Jun 2020 18:45:11 +0200 [thread overview]
Message-ID: <bd172db3-d078-79e6-1cad-437bd295a23f@redhat.com> (raw)
In-Reply-To: <20200609123323-mutt-send-email-mst@kernel.org>
On 6/9/20 6:36 PM, Michael S. Tsirkin wrote:
> On Wed, Mar 25, 2020 at 01:16:26PM +0000, Dr. David Alan Gilbert (git) wrote:
>> From: Philippe Mathieu-Daudé <philmd@redhat.com>
>>
>> When using max-bandwidth=~100Mb/s, this test fails on Travis-CI
>> s390x when configured with --disable-tcg:
>>
>> $ make check-qtest
>> TEST check-qtest-s390x: tests/qtest/boot-serial-test
>> qemu-system-s390x: -accel tcg: invalid accelerator tcg
>> qemu-system-s390x: falling back to KVM
>> TEST check-qtest-s390x: tests/qtest/pxe-test
>> TEST check-qtest-s390x: tests/qtest/test-netfilter
>> TEST check-qtest-s390x: tests/qtest/test-filter-mirror
>> TEST check-qtest-s390x: tests/qtest/test-filter-redirector
>> TEST check-qtest-s390x: tests/qtest/drive_del-test
>> TEST check-qtest-s390x: tests/qtest/device-plug-test
>> TEST check-qtest-s390x: tests/qtest/virtio-ccw-test
>> TEST check-qtest-s390x: tests/qtest/cpu-plug-test
>> TEST check-qtest-s390x: tests/qtest/migration-test
>> **
>> ERROR:tests/qtest/migration-test.c:1229:test_migrate_auto_converge: 'got_stop' should be FALSE
>> ERROR - Bail out! ERROR:tests/qtest/migration-test.c:1229:test_migrate_auto_converge: 'got_stop' should be FALSE
>> make: *** [tests/Makefile.include:633: check-qtest-s390x] Error 1
>>
>> Per David Gilbert, "it could just be the writing is slow on s390
>> and the migration thread fast; in which case the autocomplete
>> wouldn't be needed. Perhaps we just need to reduce the bandwidth
>> limit."
>>
>> Tuning the threshold by reducing the initial bandwidth makes the
>> autoconverge test pass.
>>
>> Suggested-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
>> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>> Message-Id: <20200323184015.11565-1-philmd@redhat.com>
>> Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
>> Tested-by: Alex Bennée <alex.bennee@linaro.org>
>> Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
>
>
> This slows make check down significantly for me, it stays
> at the migration test for minutes.
Alex Bennée reported the same problem, I don't know what is the best way
to fix this.
>
> I'm carrying a revert at top of my tree for now but I'd rather
> not need that.
>
>
> This seems like a fragile way to test things anyway.
> What happens if someone slows writing even more
> e.g. because it's running in a container or a VM?
This seems to be the problem I noticed and tried to fix.
>
> How about detecting that migration finished too early
> and slowing it down until autocomplete triggers?
David, I am a bit clueless with this code, do you mind having a look?
We can revert this test and disable the s390x runner, but it is our only
big-endian host, which recently show to be useful.
>
>> ---
>> tests/qtest/migration-test.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.c
>> index 3d6cc83b88..2568c9529c 100644
>> --- a/tests/qtest/migration-test.c
>> +++ b/tests/qtest/migration-test.c
>> @@ -1211,7 +1211,7 @@ static void test_migrate_auto_converge(void)
>> * without throttling.
>> */
>> migrate_set_parameter_int(from, "downtime-limit", 1);
>> - migrate_set_parameter_int(from, "max-bandwidth", 100000000); /* ~100Mb/s */
>> + migrate_set_parameter_int(from, "max-bandwidth", 1000000); /* ~1Mb/s */
>>
>> /* To check remaining size after precopy */
>> migrate_set_capability(from, "pause-before-switchover", true);
>> --
>> 2.25.1
>>
>>
>
next prev parent reply other threads:[~2020-06-09 17:20 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-25 13:16 [PULL 0/9] migration queue Dr. David Alan Gilbert (git)
2020-03-25 13:16 ` [PULL 1/9] hmp-cmd: fix a missing_break warning Dr. David Alan Gilbert (git)
2020-03-25 13:16 ` [PULL 2/9] xbzrle: update xbzrle doc Dr. David Alan Gilbert (git)
2020-03-25 13:16 ` [PULL 3/9] tests/migration: Reduce autoconverge initial bandwidth Dr. David Alan Gilbert (git)
2020-06-09 16:36 ` Michael S. Tsirkin
2020-06-09 16:45 ` Philippe Mathieu-Daudé [this message]
2020-06-09 17:00 ` Dr. David Alan Gilbert
2020-06-09 17:07 ` Philippe Mathieu-Daudé
2020-06-09 18:10 ` Michael S. Tsirkin
2020-03-25 13:16 ` [PULL 4/9] hmp/vnc: Fix info vnc list leak Dr. David Alan Gilbert (git)
2020-03-25 13:16 ` [PULL 5/9] tools/virtiofsd/passthrough_ll: Fix double close() Dr. David Alan Gilbert (git)
2020-03-25 13:16 ` [PULL 6/9] vl.c: fix migration failure for 3.1 and older machine types Dr. David Alan Gilbert (git)
2020-03-25 13:16 ` [PULL 7/9] migration/colo: fix use after free of local_err Dr. David Alan Gilbert (git)
2020-03-25 13:16 ` [PULL 8/9] migration/ram: " Dr. David Alan Gilbert (git)
2020-03-25 13:16 ` [PULL 9/9] migration: use "" instead of (null) for tls-authz Dr. David Alan Gilbert (git)
2020-03-26 10:46 ` [PULL 0/9] migration queue Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bd172db3-d078-79e6-1cad-437bd295a23f@redhat.com \
--to=philmd@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=cohuck@redhat.com \
--cc=dgilbert@redhat.com \
--cc=imammedo@redhat.com \
--cc=maozhongyi@cmss.chinamobile.com \
--cc=mst@redhat.com \
--cc=pannengyuan@huawei.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).