From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 924A0C43613 for ; Thu, 20 Jun 2019 17:20:54 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 672862082C for ; Thu, 20 Jun 2019 17:20:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 672862082C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:51324 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1he0k1-0003A7-F1 for qemu-devel@archiver.kernel.org; Thu, 20 Jun 2019 13:20:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48345) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1he0fV-0000oE-JG for qemu-devel@nongnu.org; Thu, 20 Jun 2019 13:16:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1he0ZR-0000sl-U3 for qemu-devel@nongnu.org; Thu, 20 Jun 2019 13:09:58 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39436) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1he0ZQ-0000rA-J9; Thu, 20 Jun 2019 13:09:56 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id F355E30BBEA4; Thu, 20 Jun 2019 17:09:49 +0000 (UTC) Received: from dresden.str.redhat.com (unknown [10.40.205.208]) by smtp.corp.redhat.com (Postfix) with ESMTPS id F0EC15C221; Thu, 20 Jun 2019 17:09:40 +0000 (UTC) To: John Snow , qemu-devel@nongnu.org, qemu-block@nongnu.org References: <20190620010356.19164-1-jsnow@redhat.com> <20190620010356.19164-9-jsnow@redhat.com> From: Max Reitz Openpgp: preference=signencrypt Autocrypt: addr=mreitz@redhat.com; prefer-encrypt=mutual; keydata= mQENBFXOJlcBCADEyyhOTsoa/2ujoTRAJj4MKA21dkxxELVj3cuILpLTmtachWj7QW+TVG8U /PsMCFbpwsQR7oEy8eHHZwuGQsNpEtNC2G/L8Yka0BIBzv7dEgrPzIu+W3anZXQW4702+uES U29G8TP/NGfXRRHGlbBIH9KNUnOSUD2vRtpOLXkWsV5CN6vQFYgQfFvmp5ZpPeUe6xNplu8V mcTw8OSEDW/ZnxJc8TekCKZSpdzYoxfzjm7xGmZqB18VFwgJZlIibt1HE0EB4w5GsD7x5ekh awIe3RwoZgZDLQMdOitJ1tUc8aqaxvgA4tz6J6st8D8pS//m1gAoYJWGwwIVj1DjTYLtABEB AAG0HU1heCBSZWl0eiA8bXJlaXR6QHJlZGhhdC5jb20+iQFTBBMBCAA9AhsDBQkSzAMABQsJ CAcCBhUICQoLAgQWAgMBAh4BAheABQJVzie5FRhoa3A6Ly9rZXlzLmdudXBnLm5ldAAKCRD0 B9sAYdXPQDcIB/9uNkbYEex1rHKz3mr12uxYMwLOOFY9fstP5aoVJQ1nWQVB6m2cfKGdcRe1 2/nFaHSNAzT0NnKz2MjhZVmcrpyd2Gp2QyISCfb1FbT82GMtXFj1wiHmPb3CixYmWGQUUh+I AvUqsevLA+WihgBUyaJq/vuDVM1/K9Un+w+Tz5vpeMidlIsTYhcsMhn0L9wlCjoucljvbDy/ 8C9L2DUdgi3XTa0ORKeflUhdL4gucWoAMrKX2nmPjBMKLgU7WLBc8AtV+84b9OWFML6NEyo4 4cP7cM/07VlJK53pqNg5cHtnWwjHcbpGkQvx6RUx6F1My3y52vM24rNUA3+ligVEgPYBuQEN BFXOJlcBCADAmcVUNTWT6yLWQHvxZ0o47KCP8OcLqD+67T0RCe6d0LP8GsWtrJdeDIQk+T+F xO7DolQPS6iQ6Ak2/lJaPX8L0BkEAiMuLCKFU6Bn3lFOkrQeKp3u05wCSV1iKnhg0UPji9V2 W5eNfy8F4ZQHpeGUGy+liGXlxqkeRVhLyevUqfU0WgNqAJpfhHSGpBgihUupmyUg7lfUPeRM DzAN1pIqoFuxnN+BRHdAecpsLcbR8sQddXmDg9BpSKozO/JyBmaS1RlquI8HERQoe6EynJhd 64aICHDfj61rp+/0jTIcevxIIAzW70IadoS/y3DVIkuhncgDBvGbF3aBtjrJVP+5ABEBAAGJ ASUEGAEIAA8FAlXOJlcCGwwFCRLMAwAACgkQ9AfbAGHVz0CbFwf9F/PXxQR9i4N0iipISYjU sxVdjJOM2TMut+ZZcQ6NSMvhZ0ogQxJ+iEQ5OjnIputKvPVd5U7WRh+4lF1lB/NQGrGZQ1ic alkj6ocscQyFwfib+xIe9w8TG1CVGkII7+TbS5pXHRxZH1niaRpoi/hYtgzkuOPp35jJyqT/ /ELbqQTDAWcqtJhzxKLE/ugcOMK520dJDeb6x2xVES+S5LXby0D4juZlvUj+1fwZu+7Io5+B bkhSVPb/QdOVTpnz7zWNyNw+OONo1aBUKkhq2UIByYXgORPFnbfMY7QWHcjpBVw9MgC4tGeF R4bv+1nAMMxKmb5VvQCExr0eFhJUAHAhVg== Message-ID: Date: Thu, 20 Jun 2019 19:09:39 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <20190620010356.19164-9-jsnow@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="s84VxFg7i3qQ7QTpOAYxmr9EJv6N6C2Rq" X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.46]); Thu, 20 Jun 2019 17:09:50 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-devel] [PATCH 08/12] iotests: add testing shim for script-style python tests X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Fam Zheng , vsementsov@virtuozzo.com, Wen Congyang , Xie Changlong , Markus Armbruster Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --s84VxFg7i3qQ7QTpOAYxmr9EJv6N6C2Rq Content-Type: multipart/mixed; boundary="t7VDbbpTqxAxri4au7omn3APSUT8L19kY"; protected-headers="v1" From: Max Reitz To: John Snow , qemu-devel@nongnu.org, qemu-block@nongnu.org Cc: Kevin Wolf , Wen Congyang , eblake@redhat.com, vsementsov@virtuozzo.com, Markus Armbruster , Fam Zheng , Xie Changlong Message-ID: Subject: Re: [PATCH 08/12] iotests: add testing shim for script-style python tests References: <20190620010356.19164-1-jsnow@redhat.com> <20190620010356.19164-9-jsnow@redhat.com> In-Reply-To: <20190620010356.19164-9-jsnow@redhat.com> --t7VDbbpTqxAxri4au7omn3APSUT8L19kY Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 20.06.19 03:03, John Snow wrote: > Because the new-style python tests don't use the iotests.main() test > launcher, we don't turn on the debugger logging for these scripts > when invoked via ./check -d. >=20 > Refactor the launcher shim into new and old style shims so that they > share environmental configuration. >=20 > Two cleanup notes: debug was not actually used as a global, and there > was no reason to create a class in an inner scope just to achieve > default variables; we can simply create an instance of the runner with > the values we want instead. >=20 > Signed-off-by: John Snow > --- > tests/qemu-iotests/iotests.py | 40 +++++++++++++++++++++++------------= > 1 file changed, 26 insertions(+), 14 deletions(-) I don=E2=80=99t quite get how script_main() works (yes, both my Pythonfu = and my Googlefu are that bad), but it works and looks good, so have a Reviewed-by: Max Reitz --t7VDbbpTqxAxri4au7omn3APSUT8L19kY-- --s84VxFg7i3qQ7QTpOAYxmr9EJv6N6C2Rq Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEkb62CjDbPohX0Rgp9AfbAGHVz0AFAl0LvdMACgkQ9AfbAGHV z0Dixwf9FoyAFhD1SCvcXUhp/hsgkv4JesnPqzfMqvOYnoY9JpHRtCUABmpoPHxO L7fFt9wuBJlplIPhOQSuwQZJxiPWaw0VGN994XO6IXiEJTuODZk+MrEUEC+sL+7a SFP4eoPm5ZvutzsMnpt/gsPTPMLmpGhkBHdXGOB+k8VginIzuOJkawxblP/w5Yot nvvK0G0i9DbHmmMfBcB0aTQLevtgfUerFZ/UitcJ2gXMsFxlgKtMZk0NH69NefID oq9LZNVduGjmbHlRnYuJa4XGK9JJOQFPslYji/tm65RDG3tE46F5SkBDw1Fb/Iaz WlUPnqufn6T0gx+GcYW7K03U4wOLPw== =TLCM -----END PGP SIGNATURE----- --s84VxFg7i3qQ7QTpOAYxmr9EJv6N6C2Rq--