From: Paolo Bonzini <pbonzini@redhat.com>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: kwolf@redhat.com, qemu-devel@nongnu.org, qemu-block@nongnu.org
Subject: Re: [PATCH v2 0/3] block/io: serialising request clean up and locking fix
Date: Tue, 14 Jan 2020 20:39:16 +0100 [thread overview]
Message-ID: <bea6d0f3-ddca-66a1-de9f-2c11c44d251e@redhat.com> (raw)
In-Reply-To: <20200114162858.GD132666@stefanha-x1.localdomain>
[-- Attachment #1.1: Type: text/plain, Size: 1060 bytes --]
On 14/01/20 17:28, Stefan Hajnoczi wrote:
> On Wed, Jan 08, 2020 at 03:55:53PM +0100, Paolo Bonzini wrote:
>> Peter Lieven noticed that reqs->overlap_offset and reqs->overlap_bytes
>> are written outside bs->reqs_lock. Patch 3 fixes it, while patches 1
>> and 2 are preparatory cleanups.
>>
>> v1->v2: fix comment in patch 2, commit message in patch 3 [Kevin]
>>
>> Paolo Bonzini (3):
>> block: eliminate BDRV_REQ_NO_SERIALISING
>> block/io: wait for serialising requests when a request becomes
>> serialising
>> block/io: take bs->reqs_lock in bdrv_mark_request_serialising
>>
>> block/file-posix.c | 1 -
>> block/io.c | 162 +++++++++++++++++++++++-----------------------
>> include/block/block.h | 12 ----
>> include/block/block_int.h | 3 +-
>> 4 files changed, 81 insertions(+), 97 deletions(-)
> Is it possible to trigger the bug somehow?
>
> Can you implement a test case?
No, it was found by inspection only, and it's actually protected by the
AioContext lock for now.
Paolo
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2020-01-14 19:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-08 14:55 [PATCH v2 0/3] block/io: serialising request clean up and locking fix Paolo Bonzini
2020-01-08 14:55 ` [PATCH v2 1/3] block: eliminate BDRV_REQ_NO_SERIALISING Paolo Bonzini
2020-01-08 14:55 ` [PATCH v2 2/3] block/io: wait for serialising requests when a request becomes serialising Paolo Bonzini
2020-01-08 14:55 ` [PATCH v2 3/3] block/io: take bs->reqs_lock in bdrv_mark_request_serialising Paolo Bonzini
2020-01-14 16:28 ` [PATCH v2 0/3] block/io: serialising request clean up and locking fix Stefan Hajnoczi
2020-01-14 19:39 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bea6d0f3-ddca-66a1-de9f-2c11c44d251e@redhat.com \
--to=pbonzini@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).