Re: [Qemu-devel] [PATCH v3 3/4] block/qcow2: refactor qcow2_co_pwritev_part

From: Max Reitz <mreitz@redhat.com>
To: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
	qemu-block@nongnu.org
Cc: kwolf@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com,
	stefanha@redhat.com, den@openvz.org
Subject: Re: [Qemu-devel] [PATCH v3 3/4] block/qcow2: refactor qcow2_co_pwritev_part
Date: Thu, 15 Aug 2019 16:02:34 +0200	[thread overview]
Message-ID: <bf6e0e4a-bf79-6031-5ad9-55b5793f3e03@redhat.com> (raw)
In-Reply-To: <20190815121042.121309-4-vsementsov@virtuozzo.com>

[-- Attachment #1.1: Type: text/plain, Size: 902 bytes --]

On 15.08.19 14:10, Vladimir Sementsov-Ogievskiy wrote:
> Similarly to previous commit, prepare for parallelizing write-loop
> iterations.
> 
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> ---
>  block/qcow2.c | 153 +++++++++++++++++++++++++++++---------------------
>  1 file changed, 89 insertions(+), 64 deletions(-)
> 
> diff --git a/block/qcow2.c b/block/qcow2.c
> index 89afb4272e..3aaa180e2b 100644
> --- a/block/qcow2.c
> +++ b/block/qcow2.c
> @@ -2234,6 +2234,87 @@ static int handle_alloc_space(BlockDriverState *bs, QCowL2Meta *l2meta)
>      return 0;
>  }
>  
> +/*
> + * qcow2_co_pwritev_task
> + * Called with s->lock unlocked
> + * l2meta  - if not NULL, qcow2_co_do_pwritev() will consume it. Caller must not

You missed this instance of “qcow2_co_do_pwritev()”.

With that fixed:

Reviewed-by: Max Reitz <mreitz@redhat.com>

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]