From: Eric Auger <eric.auger@redhat.com>
To: Andrew Jones <drjones@redhat.com>
Cc: peter.maydell@linaro.org, gshan@redhat.com, mst@redhat.com,
qemu-devel@nongnu.org, Hongbo Zhang <hongbo.zhang@linaro.org>,
shannon.zhaosl@gmail.com, qemu-arm@nongnu.org,
imammedo@redhat.com, Leif Lindholm <leif@nuviainc.com>,
philmd@redhat.com, ardb@kernel.org, eric.auger.pro@gmail.com
Subject: Re: [PATCH v2 0/3] hw/arm/virt_acpi_build: Generate DBG2 table
Date: Thu, 9 Sep 2021 17:41:58 +0200 [thread overview]
Message-ID: <bfd8f1d1-3b36-15d3-23a5-a6da53928d2d@redhat.com> (raw)
In-Reply-To: <20210908091404.ov2ku6t3dl6s2ui3@gator>
Hi Drew,
On 9/8/21 11:14 AM, Andrew Jones wrote:
> On Mon, Sep 06, 2021 at 02:31:36PM +0200, Eric Auger wrote:
>> This series generates the ACPI DBG2 table along with machvirt.
>> It applies on top of Igor's
>> [PATCH v2 00/35] acpi: refactor error prone build_header() and
>> packed structures usage in ACPI tables
>>
>> The DBG2 specification can be found at
>> https://docs.microsoft.com/en-us/windows-hardware/drivers/bringup/acpi-debug-port-table.
>>
>> DBG2 is mandated by ARM SBBR since its v1.0 release (the rationale
>> behind is Windows requires it on all systems).
>>
>> The DBG2 is used to describe a debug port, used by the kernel debugger.
> Hi Eric,
>
> Did you test this in some way with a Linux guest?
no, I don't know how to test it functionaly. As I diff'ed against
sbsa-ref generated table maybe guys using the sbsa-ref have some proper
testing use case of it? Adding Hongbo and Leif in CC.
Thanks
Eric
>
> Thanks,
> drew
>
>> This series and its dependency can be found at
>> https://github.com/eauger/qemu.git
>> branch: dbg2-v2-igor-v2-fix
>>
>> History:
>> v1 -> v2:
>> - rebase on top of Igor's series and use acpi_init_table/acpi_table_composed
>> and build_append_int_noprefix()
>>
>> Eric Auger (3):
>> tests/acpi: Add void table for virt/DBG2 bios-tables-test
>> bios-tables-test: Generate reference table for virt/DBG2
>> hw/arm/virt_acpi_build: Generate DBG2 table
>>
>> hw/arm/virt-acpi-build.c | 64 +++++++++++++++++++++++++++++++++++++-
>> tests/data/acpi/virt/DBG2 | Bin 0 -> 87 bytes
>> 2 files changed, 63 insertions(+), 1 deletion(-)
>> create mode 100644 tests/data/acpi/virt/DBG2
>>
>> --
>> 2.26.3
>>
prev parent reply other threads:[~2021-09-09 15:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-06 12:31 [PATCH v2 0/3] hw/arm/virt_acpi_build: Generate DBG2 table Eric Auger
2021-09-06 12:31 ` [PATCH v2 1/3] tests/acpi: Add void table for virt/DBG2 bios-tables-test Eric Auger
2021-09-07 10:20 ` Igor Mammedov
2021-09-06 12:31 ` [PATCH v2 2/3] bios-tables-test: Generate reference table for virt/DBG2 Eric Auger
2021-09-06 12:31 ` [PATCH v2 3/3] hw/arm/virt_acpi_build: Generate DBG2 table Eric Auger
2021-09-07 10:18 ` Igor Mammedov
2021-09-07 7:02 ` [PATCH v2 0/3] " Igor Mammedov
2021-09-08 9:14 ` Andrew Jones
2021-09-09 15:41 ` Eric Auger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bfd8f1d1-3b36-15d3-23a5-a6da53928d2d@redhat.com \
--to=eric.auger@redhat.com \
--cc=ardb@kernel.org \
--cc=drjones@redhat.com \
--cc=eric.auger.pro@gmail.com \
--cc=gshan@redhat.com \
--cc=hongbo.zhang@linaro.org \
--cc=imammedo@redhat.com \
--cc=leif@nuviainc.com \
--cc=mst@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=shannon.zhaosl@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).