qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Aleksandar Markovic <aleksandar.markovic@rt-rk.com>,
	qemu-devel@nongnu.org, Huacai Chen <chenhc@lemote.com>,
	Huacai Chen <zltjiangshi@gmail.com>
Cc: peter.maydell@linaro.org, aleksandar.rikalo@rt-rk.com,
	hpoussin@reactos.org, amarkovic@wavecomp.com,
	aurelien@aurel32.net
Subject: Re: [PATCH v2 2/5] MAINTAINERS: Adjust maintainership for Fulong 2E board
Date: Thu, 14 Nov 2019 12:49:13 +0100	[thread overview]
Message-ID: <c053c16c-c6f4-4f73-7383-7b66e54ad696@redhat.com> (raw)
In-Reply-To: <1573652826-23987-3-git-send-email-aleksandar.markovic@rt-rk.com>

Hi Aleksandar,

On 11/13/19 2:47 PM, Aleksandar Markovic wrote:
> From: Aleksandar Markovic <amarkovic@wavecomp.com>
> 
> Change the maintainership for Fulong 2E board to improve its quality.

IIRC you told me once this board is named Fuloong, and its CPU is a 
‎Loongson, both with 2x 'o' :) I have a patch renaming the various 
occurrences.

> Signed-off-by: Aleksandar Markovic <amarkovic@wavecomp.com>
> ---
>   MAINTAINERS | 7 ++++---
>   1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index fd9ba32..3bf2144 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -976,9 +976,10 @@ S: Maintained
>   F: hw/mips/mips_r4k.c
>   
>   Fulong 2E
> -M: Aleksandar Markovic <amarkovic@wavecomp.com>
> -R: Aleksandar Rikalo <aleksandar.rikalo@rt-rk.com>
> -S: Odd Fixes
> +M: Philippe Mathieu-Daudé <philmd@redhat.com>

I am happy to keep the Fuloong working, but this will be on my personal 
(hobbyist) time. This area is not a priority for my employer, so I'll 
use my personal email: f4bug@amsat.org.

The original author is active on the Linux kernel, let ask him if he'd 
be OK to keep an eye on his work.

Huacai, would you agree to be listed as a reviewer on the Fuloong 
related QEMU files? You don't have to worry about the generic QEMU code 
plate (like keeping API up to date) I'll manage that, but I'd like to 
have you listed to assert the hardware is properly modeled.

You would appear as:
R: Huacai Chen <chenhc@lemote.com>

> +R: Hervé Poussineau <hpoussin@reactos.org>

I don't think Hervé is interested by this board, he has not modified the 
code.

> +R: Aleksandar Markovic <amarkovic@wavecomp.com>
> +S: Maintained

Let keep it as "Odd Fixes" :)

   Odd Fixes:   It has a maintainer but they don't have
                time to do much other than throw the odd
                patch in.

>   F: hw/mips/mips_fulong2e.c
>   F: hw/isa/vt82c686.c
>   F: hw/pci-host/bonito.c
> 

So the patch would be:

-- 8< --
  Fulong 2E
-M: Aleksandar Markovic <amarkovic@wavecomp.com>
-R: Aleksandar Rikalo <aleksandar.rikalo@rt-rk.com>
+M: Philippe Mathieu-Daudé <f4bug@amsat.org>
+R: Aleksandar Markovic <amarkovic@wavecomp.com>
+R: Huacai Chen <chenhc@lemote.com>
  S: Odd Fixes
  F: hw/mips/mips_fulong2e.c
  F: hw/isa/vt82c686.c
---

But let's wait to see what Huacai Chen thinks of it, before posting it.

Thanks for taking care of those changes!

Phil.



  reply	other threads:[~2019-11-14 11:50 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-13 13:47 [PATCH v2 0/5] MAINTAINERS: Fine adjustment for (mostly mips) content Aleksandar Markovic
2019-11-13 13:47 ` [PATCH v2 1/5] MAINTAINERS: Add a section on UI translation Aleksandar Markovic
2019-11-13 18:52   ` Philippe Mathieu-Daudé
2019-11-13 13:47 ` [PATCH v2 2/5] MAINTAINERS: Adjust maintainership for Fulong 2E board Aleksandar Markovic
2019-11-14 11:49   ` Philippe Mathieu-Daudé [this message]
2019-11-14 12:33     ` [EXTERNAL]Re: " Aleksandar Markovic
2019-11-14 13:08       ` chen huacai
2019-11-14 13:50         ` Philippe Mathieu-Daudé
2019-11-25 22:58           ` Philippe Mathieu-Daudé
2019-11-26 11:19             ` BALATON Zoltan
2019-12-07 19:07           ` Aleksandar Markovic
2019-11-13 13:47 ` [PATCH v2 3/5] MAINTAINERS: Adjust maintainership for Malta board Aleksandar Markovic
2019-11-14 21:23   ` Philippe Mathieu-Daudé
2019-12-07 19:15     ` Aleksandar Markovic
2019-12-09  5:20       ` Markus Armbruster
2019-11-13 13:47 ` [PATCH v2 4/5] MAINTAINERS: Adjust maintainership for R4000 systems Aleksandar Markovic
2019-11-22 13:58   ` Philippe Mathieu-Daudé
2019-11-22 14:14     ` Aleksandar Markovic
2019-11-22 15:29       ` Philippe Mathieu-Daudé
2019-11-22 23:01         ` Hervé Poussineau
2019-11-13 13:47 ` [PATCH v2 5/5] MAINTAINERS: Add two files to Malta section Aleksandar Markovic
2019-11-22 20:28   ` Philippe Mathieu-Daudé
2019-11-22 20:37     ` Aleksandar Markovic
2019-11-23 13:44       ` Philippe Mathieu-Daudé
2019-11-23 14:18         ` Aleksandar Markovic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c053c16c-c6f4-4f73-7383-7b66e54ad696@redhat.com \
    --to=philmd@redhat.com \
    --cc=aleksandar.markovic@rt-rk.com \
    --cc=aleksandar.rikalo@rt-rk.com \
    --cc=amarkovic@wavecomp.com \
    --cc=aurelien@aurel32.net \
    --cc=chenhc@lemote.com \
    --cc=hpoussin@reactos.org \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=zltjiangshi@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).