From: Paolo Bonzini <pbonzini@redhat.com>
To: Lara Lazier <laramglazier@gmail.com>, qemu-devel@nongnu.org
Subject: Re: [PATCH v2] target/i386: Added V_INTR_PRIO check to virtual interrupts
Date: Thu, 29 Jul 2021 09:57:00 +0200 [thread overview]
Message-ID: <c199cfeb-2cc0-e091-379c-ab04119ed8ae@redhat.com> (raw)
In-Reply-To: <20210728101721.26712-1-laramglazier@gmail.com>
On 28/07/21 12:17, Lara Lazier wrote:
> v1->v2: Fixed Mask
>
> The APM2 states that The processor takes a virtual INTR interrupt
> if V_IRQ and V_INTR_PRIO indicate that there is a virtual interrupt pending
> whose priority is greater than the value in V_TPR.
>
> Signed-off-by: Lara Lazier <laramglazier@gmail.com>
> ---
> target/i386/tcg/sysemu/svm_helper.c | 11 ++++++++++-
> 1 file changed, 10 insertions(+), 1 deletion(-)
>
> diff --git a/target/i386/tcg/sysemu/svm_helper.c b/target/i386/tcg/sysemu/svm_helper.c
> index 72ea7c9a08..a3138e9f86 100644
> --- a/target/i386/tcg/sysemu/svm_helper.c
> +++ b/target/i386/tcg/sysemu/svm_helper.c
> @@ -65,6 +65,16 @@ static inline void svm_load_seg_cache(CPUX86State *env, hwaddr addr,
> sc->base, sc->limit, sc->flags);
> }
>
> +static inline bool ctl_has_irq(uint32_t int_ctl)
> +{
> + uint32_t int_prio;
> + uint32_t tpr;
> +
> + int_prio = (int_ctl & V_INTR_PRIO_MASK) >> V_INTR_PRIO_SHIFT;
> + tpr = int_ctl & V_TPR_MASK;
> + return (int_ctl & V_IRQ_MASK) && (int_prio >= tpr);
> +}
> +
> static inline bool is_efer_invalid_state (CPUX86State *env)
> {
> if (!(env->efer & MSR_EFER_SVME)) {
> @@ -365,7 +375,6 @@ void helper_vmrun(CPUX86State *env, int aflag, int next_eip_addend)
>
> if (ctl_has_irq(int_ctl)) {
> CPUState *cs = env_cpu(env);
> -
> cs->interrupt_request |= CPU_INTERRUPT_VIRQ;
> }
>
>
Merged, thanks.
Paolo
prev parent reply other threads:[~2021-07-29 7:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-28 10:17 [PATCH v2] target/i386: Added V_INTR_PRIO check to virtual interrupts Lara Lazier
2021-07-29 7:57 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c199cfeb-2cc0-e091-379c-ab04119ed8ae@redhat.com \
--to=pbonzini@redhat.com \
--cc=laramglazier@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).