From: Eric Blake <eblake@redhat.com>
To: Tao Xu <tao3.xu@intel.com>, Markus Armbruster <armbru@redhat.com>
Cc: "mdroth@linux.vnet.ibm.com" <mdroth@linux.vnet.ibm.com>,
"ehabkost@redhat.com" <ehabkost@redhat.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: Re: [PATCH] util/cutils: Expand do_strtosz parsing precision to 64 bits
Date: Wed, 18 Dec 2019 15:49:34 -0600 [thread overview]
Message-ID: <c19efe27-5a61-100f-7b9b-bbac50209f94@redhat.com> (raw)
In-Reply-To: <e731445a-4461-3212-c08d-05dc7ad2b742@intel.com>
On 12/17/19 7:33 PM, Tao Xu wrote:
>> Also fun: for "0123", we use uint64_t 83, not double 123.0. But for
>> "0123.", we use 123.0, not 83.
>>
>> Do we really want to accept octal and hexadecimal integers?
>>
>
> Thank you for reminding me. Octal and hexadecimal may bring more
> confusion. I will use qemu_strtou64(nptr, &suffixu, 10, &valu) and add
> test for input like "0123".
Note that JSON does not permit octal numbers, but ALSO does not permit
'0123' as a valid JSON number. Of course, this parser is intended for
human users rather than a JSON parser, so silently accepting it as
decimal 123 is probably okay, but it is worth remembering that decisions
are not trivial here.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
next prev parent reply other threads:[~2019-12-18 21:51 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-05 2:14 [PATCH] util/cutils: Expand do_strtosz parsing precision to 64 bits Tao Xu
2019-12-05 15:29 ` Markus Armbruster
2019-12-09 5:38 ` Tao Xu
2019-12-17 10:25 ` Markus Armbruster
2019-12-18 1:33 ` Tao Xu
2019-12-18 5:26 ` Tao Xu
2019-12-18 18:26 ` Markus Armbruster
2019-12-19 7:43 ` Tao Xu
2019-12-19 10:15 ` Markus Armbruster
2019-12-18 21:49 ` Eric Blake [this message]
2019-12-17 12:04 ` Christophe de Dinechin
2019-12-17 14:08 ` Markus Armbruster
2019-12-17 14:12 ` Christophe de Dinechin
2019-12-17 15:01 ` Markus Armbruster
2019-12-18 2:29 ` Tao Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c19efe27-5a61-100f-7b9b-bbac50209f94@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=ehabkost@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=tao3.xu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).