From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD3C3C76191 for ; Mon, 15 Jul 2019 11:04:50 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 84A7B206B8 for ; Mon, 15 Jul 2019 11:04:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 84A7B206B8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:37112 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hmymn-0005CA-Pr for qemu-devel@archiver.kernel.org; Mon, 15 Jul 2019 07:04:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44967) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hmymY-0004X3-10 for qemu-devel@nongnu.org; Mon, 15 Jul 2019 07:04:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hmymW-0003HS-OY for qemu-devel@nongnu.org; Mon, 15 Jul 2019 07:04:33 -0400 Received: from mail-wm1-f66.google.com ([209.85.128.66]:34074) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hmymW-0003GF-Hq for qemu-devel@nongnu.org; Mon, 15 Jul 2019 07:04:32 -0400 Received: by mail-wm1-f66.google.com with SMTP id w9so14039951wmd.1 for ; Mon, 15 Jul 2019 04:04:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=3h7FJeb5FfXjJncaNSFPcAq5CrVN6sKZxo1A34lkJ90=; b=c2Z/RRnYFUp/F3yr8LmrSp+eGgiCGaV+G9G+fxZ2ivn0ptNLVxWROGJ3bDg4UKSMHR XtaGQe7ODKsq/+qk//GS8JQ1ptkUxMg6bRyPnkPMkzUMPwPWHLHm03dTYzQtyiM0MmgR +uxSGIP7P2+S6upwS7oiYnIxZWd+7KxGhqz2PgSXjeHRsPEobMzNfhIzGsisjSMFoSSZ 9B58gOh9n7K5NVPcvg01p+shOkEmyN6JWU4ANP1lihrkjqnbcqbbPGY/CsX9F8uNoT/p 8fzZXgqcdruiuOPauV8TsqcorKi4a60NCI+VvhBRW8F/te8/Omx/IRtjsUx1Uwe+J3DC /daA== X-Gm-Message-State: APjAAAULdUUwcKadpNX32DjE98NTX2p63zCN7aeMU8DzAFWz2nP4+1z1 YGK+pKn/YJjUMMFho9qleIOYcQ== X-Google-Smtp-Source: APXvYqwREF2BzPwOB/3PP7rVeGZ+hCPNrU80TJyAVxF+ZLxX2qTHq5O5dLhhQpxeECd3+7mjBMw+Lg== X-Received: by 2002:a7b:c206:: with SMTP id x6mr24185721wmi.156.1563188670329; Mon, 15 Jul 2019 04:04:30 -0700 (PDT) Received: from [192.168.1.37] (62.red-83-42-61.dynamicip.rima-tde.net. [83.42.61.62]) by smtp.gmail.com with ESMTPSA id p3sm15390645wmg.15.2019.07.15.04.04.28 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Mon, 15 Jul 2019 04:04:29 -0700 (PDT) To: Cornelia Huck , Thomas Huth References: <20190715095545.28545-1-philmd@redhat.com> <20190715095545.28545-2-philmd@redhat.com> <6d69e8ad-d720-ce04-20f2-a03193903078@redhat.com> <20190715125653.6e65d575.cohuck@redhat.com> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Openpgp: id=89C1E78F601EE86C867495CBA2A3FD6EDEADC0DE; url=http://pgp.mit.edu/pks/lookup?op=get&search=0xA2A3FD6EDEADC0DE Message-ID: Date: Mon, 15 Jul 2019 13:04:28 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <20190715125653.6e65d575.cohuck@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.85.128.66 Subject: Re: [Qemu-devel] [qemu-s390x] [RFC PATCH 1/3] hw/Kconfig: PCI bus implies PCI_DEVICES X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Collin Walling , "open list:RISC-V" , Eduardo Habkost , Sagar Karandikar , "Michael S. Tsirkin" , Helge Deller , Palmer Dabbelt , Mark Cave-Ayland , QEMU Developers , Aurelien Jarno , "open list:S390" , qemu-arm , qemu-ppc , Gerd Hoffmann , Paolo Bonzini , Alistair Francis , Richard Henderson , Artyom Tarasenko , David Gibson Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 7/15/19 12:56 PM, Cornelia Huck wrote: > On Mon, 15 Jul 2019 12:48:55 +0200 > Thomas Huth wrote: > >> On 15/07/2019 12.19, Peter Maydell wrote: >>> On Mon, 15 Jul 2019 at 11:15, Thomas Huth wrote: >>>> >>>> On 15/07/2019 11.55, Philippe Mathieu-Daudé wrote: >>>>> If a controller device provides a PCI bus, we can plug any PCI >>>>> daughter card on it. >>>>> >>>>> Signed-off-by: Philippe Mathieu-Daudé >>>>> --- >>> >>>>> diff --git a/hw/pci/Kconfig b/hw/pci/Kconfig >>>>> index 77f8b005ff..0f7267db35 100644 >>>>> --- a/hw/pci/Kconfig >>>>> +++ b/hw/pci/Kconfig >>>>> @@ -1,5 +1,6 @@ >>>>> config PCI >>>>> bool >>>>> + imply PCI_DEVICES >>>> >>>> No, please don't change this. This was done on purpose, since almost all >>>> PCI_DEVICES do not work on s390x (so s390x does *not* imply PCI_DEVICES). >>> >>> But that means that every board that provides PCI has to have an >>> "imply PCI_DEVICES" line, which is pretty clunky just to work >>> around an s390x limitation. >>> >>> Is there some way in the Kconfig syntax for s390x to say >>> "no PCI_DEVICES" so we can have the corner-case be handled >>> by the s390x Kconfig in one place rather than in 20 places >>> affecting everywhere except s390x? >> >> IIRC the problem on s390x are the legacy IRQs. s390x has only MSIs. So I >> guess the correct way to fix this would be to introduce some >> PCI_LEGACY_IRQ switch and let all old devices that do not work with MSI >> depend on it. > > s/MSI/MSI-X/, IIRC. Not sure how far 'legacy' would stretch. Maybe we can have something like PCI_LEGACY_DEVICES and PCI_MSI_DEVICES? So if s390x only selects PCI_LEGACY (not PCI_MSI) bus, then it only get legacy devices? Other MSI compliant should select PCI_MSI instead. PCI alone seems to give troubles. > cc:ing Collin in case there's something else. >