From: John Snow <jsnow@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: Michael Roth <mdroth@linux.vnet.ibm.com>,
qemu-devel@nongnu.org, Eduardo Habkost <ehabkost@redhat.com>,
Cleber Rosa <crosa@redhat.com>
Subject: Re: [PATCH 00/25] qapi: static typing conversion, pt6
Date: Thu, 22 Oct 2020 10:51:29 -0400 [thread overview]
Message-ID: <c2fb9926-4fd5-5419-934f-90c355ca9203@redhat.com> (raw)
In-Reply-To: <20200922224501.4087749-1-jsnow@redhat.com>
On 9/22/20 6:44 PM, John Snow wrote:
> based-on: <20200922223525.4085762-1-jsnow@redhat.com>
> [PATCH 00/26] qapi: static typing conversion, pt5
>
> Hi, this series adds static type hints to the QAPI module.
> This is the final part, part six!
>
> Part 6 (Everything):
> https://gitlab.com/jsnow/qemu/-/tree/python-qapi-cleanup-pt6
>
Note: I have rebased and updated the pt6 branch. I am currently working
on respinning pt2, which now contains the introspect.py patches that
were formerly in pt1.
Thanks,
--js
> - Requires Python 3.6+
> - Requires mypy 0.770 or newer (for type analysis only)
> - Requires pylint 2.6.0 or newer (for lint checking only)
>
> This part of the series focuses on schema.py.
>
> Type hints are added in patches that add *only* type hints and change no
> other behavior. Any necessary changes to behavior to accommodate typing
> are split out into their own tiny patches.
>
> Every commit should pass with:
> - flake8 qapi/
> - pylint --rcfile=qapi/pylintrc qapi/
> - mypy --config-file=qapi/mypy.ini qapi/
>
> John Snow (25):
> qapi/schema: add Visitable mixin
> qapi/schema.py: Move meta-type into class instances
> qapi/schema.py: add assert in stub methods
> qapi/schema.py: constrain QAPISchemaObjectType base type
> qapi/schema.py: constrain QAPISchemaObjectTypeMember arg_type type
> qapi/schema.py: constrain QAPISchemaEvent arg_type type
> qapi/schema.py: constrain tag_member type
> qapi/schema.py: Allow alternate_type to assert
> qapi/schema.py: remove superfluous assert
> qapi/schema.py: Add assertion to ifcond property
> qapi/schema.py: Constrain type of QAPISchemaObjectType members field
> qapi/schema.py: remove 'and' from non-bool rvalue expressions
> qapi/schema.py: Test type of self.ret_type instead of local temp
> qapi/schema.py: Assert variants of an object are also objects
> qapi/schema.py: add type hint annotations
> qapi/schema.py: enable checking
> qapi: Disable similarity checks in pylint entirely
> qapi/schema.py: Add pylint warning suppressions
> qapi/schema.py: Convert several methods to classmethods
> qapi/schema.py: Replace one-letter variable names
> qapi/schema.py: disable pylint line limit
> qapi/schema.py: Ignore unused argument for check()
> qapi/schema.py: enable pylint checks
> qapi/schema.py: Add module docstring
> qapi/schema.py: Use python3 style super()
>
> scripts/qapi/mypy.ini | 6 -
> scripts/qapi/pylintrc | 6 +-
> scripts/qapi/schema.py | 848 +++++++++++++++++++++++++++--------------
> 3 files changed, 557 insertions(+), 303 deletions(-)
>
prev parent reply other threads:[~2020-10-22 14:53 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-22 22:44 [PATCH 00/25] qapi: static typing conversion, pt6 John Snow
2020-09-22 22:44 ` [PATCH 01/25] qapi/schema: add Visitable mixin John Snow
2020-09-22 22:44 ` [PATCH 02/25] qapi/schema.py: Move meta-type into class instances John Snow
2020-09-22 22:44 ` [PATCH 03/25] qapi/schema.py: add assert in stub methods John Snow
2020-09-22 22:44 ` [PATCH 04/25] qapi/schema.py: constrain QAPISchemaObjectType base type John Snow
2020-09-22 22:44 ` [PATCH 05/25] qapi/schema.py: constrain QAPISchemaObjectTypeMember arg_type type John Snow
2020-09-22 22:44 ` [PATCH 06/25] qapi/schema.py: constrain QAPISchemaEvent " John Snow
2020-09-22 22:44 ` [PATCH 07/25] qapi/schema.py: constrain tag_member type John Snow
2020-09-22 22:44 ` [PATCH 08/25] qapi/schema.py: Allow alternate_type to assert John Snow
2020-09-22 22:44 ` [PATCH 09/25] qapi/schema.py: remove superfluous assert John Snow
2020-09-22 22:44 ` [PATCH 10/25] qapi/schema.py: Add assertion to ifcond property John Snow
2020-09-22 22:44 ` [PATCH 11/25] qapi/schema.py: Constrain type of QAPISchemaObjectType members field John Snow
2020-09-22 22:44 ` [PATCH 12/25] qapi/schema.py: remove 'and' from non-bool rvalue expressions John Snow
2020-09-22 22:44 ` [PATCH 13/25] qapi/schema.py: Test type of self.ret_type instead of local temp John Snow
2020-09-22 22:44 ` [PATCH 14/25] qapi/schema.py: Assert variants of an object are also objects John Snow
2020-09-22 22:44 ` [PATCH 15/25] qapi/schema.py: add type hint annotations John Snow
2020-09-22 22:44 ` [PATCH 16/25] qapi/schema.py: enable checking John Snow
2020-09-22 22:44 ` [PATCH 17/25] qapi: Disable similarity checks in pylint entirely John Snow
2020-09-22 22:44 ` [PATCH 18/25] qapi/schema.py: Add pylint warning suppressions John Snow
2020-09-22 22:44 ` [PATCH 19/25] qapi/schema.py: Convert several methods to classmethods John Snow
2020-09-22 22:44 ` [PATCH 20/25] qapi/schema.py: Replace one-letter variable names John Snow
2020-09-22 22:44 ` [PATCH 21/25] qapi/schema.py: disable pylint line limit John Snow
2020-09-22 22:44 ` [PATCH 22/25] qapi/schema.py: Ignore unused argument for check() John Snow
2020-09-22 22:44 ` [PATCH 23/25] qapi/schema.py: enable pylint checks John Snow
2020-09-22 22:45 ` [PATCH 24/25] qapi/schema.py: Add module docstring John Snow
2020-09-22 22:45 ` [PATCH 25/25] qapi/schema.py: Use python3 style super() John Snow
2020-10-22 14:51 ` John Snow [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c2fb9926-4fd5-5419-934f-90c355ca9203@redhat.com \
--to=jsnow@redhat.com \
--cc=armbru@redhat.com \
--cc=crosa@redhat.com \
--cc=ehabkost@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).