From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8AA32C433E0 for ; Thu, 2 Jul 2020 19:27:26 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4861F20772 for ; Thu, 2 Jul 2020 19:27:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="NOSSBS+I" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4861F20772 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:41328 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jr4rl-0002CU-EV for qemu-devel@archiver.kernel.org; Thu, 02 Jul 2020 15:27:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47856) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jr4qq-0001TT-8o for qemu-devel@nongnu.org; Thu, 02 Jul 2020 15:26:28 -0400 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:40879 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jr4qo-0006Bj-8e for qemu-devel@nongnu.org; Thu, 02 Jul 2020 15:26:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1593717983; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=h+kkp0glMQKAXMJ6/bC36ZxkMzJectPPpL5LAdpf9ms=; b=NOSSBS+IdrS1ipNyY2/9r/1cov0duUNyjdNvAGCq60lWak2CEEc8g5RrZAwPvEC4colnyQ opcYmBo9FWhyOhzBaqojd6UY90AnGbeywDF/peFYpiHLoZaMhi3+y8z7iRbfkuPljrgSTX VnxKsbVfrTjjsrux8hoHHyByog7KPo8= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-160-cS6ilCO-OF-CB6j5O0CnyA-1; Thu, 02 Jul 2020 15:26:18 -0400 X-MC-Unique: cS6ilCO-OF-CB6j5O0CnyA-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 45D84804001; Thu, 2 Jul 2020 19:26:17 +0000 (UTC) Received: from [10.36.112.70] (ovpn-112-70.ams2.redhat.com [10.36.112.70]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 85918100164D; Thu, 2 Jul 2020 19:26:08 +0000 (UTC) Subject: Re: [PATCH 0/4] hw/arm/virt-acpi-build: Only expose flash on older machine types To: Andrew Jones , qemu-devel@nongnu.org, qemu-arm@nongnu.org References: <20200629140938.17566-1-drjones@redhat.com> From: Auger Eric Message-ID: Date: Thu, 2 Jul 2020 21:26:06 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <20200629140938.17566-1-drjones@redhat.com> Content-Language: en-US X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=eric.auger@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=205.139.110.120; envelope-from=eric.auger@redhat.com; helo=us-smtp-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/07/02 04:00:43 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, mst@redhat.com, philmd@redhat.com, shannon.zhaosl@gmail.com, ard.biesheuvel@arm.com, imammedo@redhat.com, lersek@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Hi Drew, On 6/29/20 4:09 PM, Andrew Jones wrote: > The flash device is exclusively for the host-controlled firmware, so > we should not expose it to the OS. Exposing it risks the OS messing > with it, which could break firmware runtime services and surprise the > OS when all its changes disappear after reboot. > > This change was suggested by Ard and Laszlo. > > Patch 3/4 is the meat. The other patches deal with updating qtest. > > Thanks, > drew > > Andrew Jones (4): > tests/acpi: remove stale allowed tables > tests/acpi: virt: allow DSDT acpi table changes > hw/arm/virt-acpi-build: Only expose flash on older machine types > tests/acpi: virt: update golden masters for DSDT SERIES: Reviewed-by: Eric Auger Thanks Eric > > hw/arm/virt-acpi-build.c | 5 ++++- > hw/arm/virt.c | 3 +++ > include/hw/arm/virt.h | 1 + > tests/data/acpi/virt/DSDT | Bin 5307 -> 5205 bytes > tests/data/acpi/virt/DSDT.memhp | Bin 6668 -> 6566 bytes > tests/data/acpi/virt/DSDT.numamem | Bin 5307 -> 5205 bytes > tests/qtest/bios-tables-test-allowed-diff.h | 18 ------------------ > 7 files changed, 8 insertions(+), 19 deletions(-) >