From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC790C433E0 for ; Thu, 14 Jan 2021 16:17:49 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2FEEC239EB for ; Thu, 14 Jan 2021 16:17:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2FEEC239EB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=amsat.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:40066 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l05Jj-0000xp-UA for qemu-devel@archiver.kernel.org; Thu, 14 Jan 2021 11:17:47 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:33246) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l052u-0002Fc-6y; Thu, 14 Jan 2021 11:00:26 -0500 Received: from mail-wm1-x330.google.com ([2a00:1450:4864:20::330]:53435) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l052p-0001Gv-EU; Thu, 14 Jan 2021 11:00:22 -0500 Received: by mail-wm1-x330.google.com with SMTP id k10so4969511wmi.3; Thu, 14 Jan 2021 08:00:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:from:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=5XT/S1rmYl0aWz2RdxT7IxZAvLzn8PyBUJ4yxYv5shI=; b=BT8rT0TyBSUawHM+bnX+b+enr+CCK8H5JsispZcM83yBu7JIwgg563RdExVPTylEJ7 k8qy1SFEYyAtSnF/b8U6f+20Y5JwpuI9Ecv05/Z8FMdePDsz1WoyjpWC2vpOqdA8VtpB k1g90Z8jEDVAbTMsVCB0oekZgDhzH4JoS5bccGXWjT+HrGTGy5KCRyubeCrVNZcL4zYp 3LYXXDH9fTeEAkfHnLF4+kdZCvdM/QL1dAIQe4HYdEJsZWBCjLftriMF3KNCBjt5T22m d2gvXxe+hSssQ7oExRlKlNePNVN1oLUGhlqjeGnzUz4GDwVKzOmgpT6vzQWQkCkaEzCD OFtg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:from:to:cc:references:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=5XT/S1rmYl0aWz2RdxT7IxZAvLzn8PyBUJ4yxYv5shI=; b=uJnb4jChu02SjBzpXUbT9fAB/CFsNy/hqPyY9QVK5CJLCClUkmoE5rtp2gLnpr2rGn 3y+0Mns6uc/ji6gH/1roLKpzRKuPFoNJLqSrfDEy8wgo08VsalHgFd0YCO2qGGKd6pFy UrBSLdUFV5c8BABJNxzVvoXFMUOetvK2zPUn4HmCdsazHIFBjirESGmCv5StDmeG/6+P +YKIgmjnrZoh8PRI7uQVyNOytgRkyd7D4yrhM3+HmuFjVsCl0VmELSxj/tCNba7oL19c bTPFtk9MfITRtSNcc1lqJA9ucJRf2SR1A2Z50q3m/OkQSTGDhXUYVdeJ0YAPz4m5AT/N C0tA== X-Gm-Message-State: AOAM531e8jLWohCWU/eFHWifvmdlLmYg97ZlZmxt1E8LQaMeHGIXfSVc 9N88VUgm5bLuq0LsDV6dmDk= X-Google-Smtp-Source: ABdhPJziXEgOFCA2hXbICC05y4iYG6fN8J9F7joacO9vFAlu1/gMVI+LWcXeSIodBoctmKm4XPlOiQ== X-Received: by 2002:a1c:220b:: with SMTP id i11mr4671626wmi.8.1610640017531; Thu, 14 Jan 2021 08:00:17 -0800 (PST) Received: from [192.168.1.36] (13.red-83-57-169.dynamicip.rima-tde.net. [83.57.169.13]) by smtp.gmail.com with ESMTPSA id a24sm2979691wmj.17.2021.01.14.08.00.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 14 Jan 2021 08:00:16 -0800 (PST) Subject: Re: [RFC PATCH v6 00/11] hw/ssi: imx_spi: Fix various bugs in the imx_spi model From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= To: Bin Meng References: <20210112183529.2011863-1-f4bug@amsat.org> <74a2566b-cd32-743f-8088-c59e992be755@amsat.org> <7c8e33c2-d86a-44ef-8d4c-0f6dcf9f7b2c@amsat.org> Message-ID: Date: Thu, 14 Jan 2021 17:00:15 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <7c8e33c2-d86a-44ef-8d4c-0f6dcf9f7b2c@amsat.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::330; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-x330.google.com X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.248, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.248, NICE_REPLY_A=-0.237, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Alistair Francis , Xuzhou Cheng , Bin Meng , "qemu-devel@nongnu.org Developers" , Jean-Christophe Dubois , qemu-arm , Peter Chubb Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Hi Ben, On 1/13/21 6:56 PM, Philippe Mathieu-Daudé wrote: > On 1/13/21 2:27 PM, Bin Meng wrote: >> Hi Philippe, >> >>>> Unfortunately this series breaks SPI flash testing under both U-Boot >>>> and VxWorks 7. >>> >>> Thanks for testing :) Can you provide the binary tested and the command >>> line used? At least one, so I can have a look. >> >> Sure, will send you offline. > > Arf, stupid mistake in patch 7 :) With this diff I can run your > test: > > -- >8 -- > --- a/hw/ssi/imx_spi.c > +++ b/hw/ssi/imx_spi.c > @@ -343,7 +343,7 @@ static void imx_spi_write(void *opaque, hwaddr > offset, uint64_t value, > return; > } > s->regs[ECSPI_CONREG] = value; > - if (value & ECSPI_CONREG_EN) { > + if (!(value & ECSPI_CONREG_EN)) { > /* Keep disabled */ > return; > } > --- Could you have a try at this? Do you prefer I resubmit the whole series? Thanks, Phil.