From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Wainer dos Santos Moschetta <wainersm@redhat.com>, qemu-devel@nongnu.org
Cc: fam@euphon.net, alex.bennee@linaro.org, jsnow@redhat.com,
ehabkost@redhat.com, crosa@redhat.com
Subject: Re: [PATCH 0/4] python/qemu: New accel module and improvements
Date: Tue, 3 Dec 2019 18:25:07 +0100 [thread overview]
Message-ID: <c3dabd1f-8e28-2a89-8c81-3fde07af5779@redhat.com> (raw)
In-Reply-To: <20191115180829.10275-1-wainersm@redhat.com>
On 11/15/19 7:08 PM, Wainer dos Santos Moschetta wrote:
> On commit abf0bf998dcb John Snow moved some code out of __init__.py
> to machine.py. kvm_available() remained in though. So on patch 01
> I continue his work by creating a home for that method (the new
> 'accel' module). Honestly I was unsure about whether move the code
> to any existing module or make a new, but since I am adding more
> methods related with accelerators then I thought they would
> deserve a module.
>
> The patches 02-04 introduce new helpers and make improvements. Later
> I intend to use those methods on the acceptance tests such as
> to automatically set the accelerator in QEMUMachine VM via Avocado
> tags, and skip the test if the accelerator is not available.
>
> Git:
> - Tree: https://github.com/wainersm/qemu
> - Branch: python_accel
>
> CI:
> - Travis (FAIL): https://travis-ci.org/wainersm/qemu/builds/612382935
> Non-related fail due build timeout
>
> Wainer dos Santos Moschetta (4):
> python/qemu: Move kvm_available() to its own module
> python/qemu: accel: Add list_accel() method
> python/qemu: accel: Strengthen kvm_available() checks
> python/qemu: accel: Add tcg_available() method
No more comment that what Alex said, I'd move the logging import in
patch #2 where you use LOG.
With Alex comment fixed:
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
prev parent reply other threads:[~2019-12-03 18:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-15 18:08 [PATCH 0/4] python/qemu: New accel module and improvements Wainer dos Santos Moschetta
2019-11-15 18:08 ` [PATCH 1/4] python/qemu: Move kvm_available() to its own module Wainer dos Santos Moschetta
2019-12-03 16:21 ` Alex Bennée
2019-11-15 18:08 ` [PATCH 2/4] python/qemu: accel: Add list_accel() method Wainer dos Santos Moschetta
2019-12-03 16:57 ` Alex Bennée
2019-11-15 18:08 ` [PATCH 3/4] python/qemu: accel: Strengthen kvm_available() checks Wainer dos Santos Moschetta
2019-12-03 16:58 ` Alex Bennée
2019-11-15 18:08 ` [PATCH 4/4] python/qemu: accel: Add tcg_available() method Wainer dos Santos Moschetta
2019-12-03 17:00 ` Alex Bennée
2019-12-03 17:25 ` Philippe Mathieu-Daudé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c3dabd1f-8e28-2a89-8c81-3fde07af5779@redhat.com \
--to=philmd@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=crosa@redhat.com \
--cc=ehabkost@redhat.com \
--cc=fam@euphon.net \
--cc=jsnow@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=wainersm@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).