From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, Fam Zheng <fam@euphon.net>,
Paolo Bonzini <pbonzini@redhat.com>,
Peter Maydell <peter.maydell@linaro.org>
Subject: Re: [PATCH] hw/scsi: Fix scsi_bus_init_named() docstring
Date: Wed, 15 Dec 2021 11:29:13 +0100 [thread overview]
Message-ID: <c411d129-cbb8-42e1-08fc-c10b081aae03@amsat.org> (raw)
In-Reply-To: <20211122104744.1051554-1-f4bug@amsat.org>
Hi Laurent,
This patch is reviewed, can it go via your trivial tree?
On 11/22/21 11:47, Philippe Mathieu-Daudé wrote:
> Commit 739e95f5741 ("scsi: Replace scsi_bus_new() with
> scsi_bus_init(), scsi_bus_init_named()") forgot to rename
> scsi_bus_init() in the function documentation string.
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> include/hw/scsi/scsi.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/hw/scsi/scsi.h b/include/hw/scsi/scsi.h
> index a567a5ed86b..2ef80af6dca 100644
> --- a/include/hw/scsi/scsi.h
> +++ b/include/hw/scsi/scsi.h
> @@ -158,7 +158,7 @@ struct SCSIBus {
> * provided by the caller. It is the caller's responsibility to make
> * sure that name does not clash with the name of any other bus in the
> * system. Unless you need the new bus to have a specific name, you
> - * should use scsi_bus_new() instead.
> + * should use scsi_bus_init() instead.
> */
> void scsi_bus_init_named(SCSIBus *bus, size_t bus_size, DeviceState *host,
> const SCSIBusInfo *info, const char *bus_name);
>
next prev parent reply other threads:[~2021-12-15 10:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-22 10:47 [PATCH] hw/scsi: Fix scsi_bus_init_named() docstring Philippe Mathieu-Daudé
2021-11-22 10:49 ` Peter Maydell
2021-12-15 10:29 ` Philippe Mathieu-Daudé [this message]
2021-12-17 9:20 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c411d129-cbb8-42e1-08fc-c10b081aae03@amsat.org \
--to=f4bug@amsat.org \
--cc=fam@euphon.net \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).