From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 641BBC432C0 for ; Thu, 21 Nov 2019 14:25:15 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 36960206CB for ; Thu, 21 Nov 2019 14:25:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 36960206CB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.ibm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:41226 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iXnOU-0008K8-7f for qemu-devel@archiver.kernel.org; Thu, 21 Nov 2019 09:25:14 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:39307) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iXnMm-00071v-MP for qemu-devel@nongnu.org; Thu, 21 Nov 2019 09:23:29 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iXnMl-00040Y-Bg for qemu-devel@nongnu.org; Thu, 21 Nov 2019 09:23:28 -0500 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:4840) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iXnMl-00040J-6n for qemu-devel@nongnu.org; Thu, 21 Nov 2019 09:23:27 -0500 Received: from pps.filterd (m0127361.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id xALEM707022069 for ; Thu, 21 Nov 2019 09:23:26 -0500 Received: from e06smtp01.uk.ibm.com (e06smtp01.uk.ibm.com [195.75.94.97]) by mx0a-001b2d01.pphosted.com with ESMTP id 2wact9hsm3-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 21 Nov 2019 09:23:25 -0500 Received: from localhost by e06smtp01.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 21 Nov 2019 14:23:15 -0000 Received: from b06avi18878370.portsmouth.uk.ibm.com (9.149.26.194) by e06smtp01.uk.ibm.com (192.168.101.131) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Thu, 21 Nov 2019 14:23:11 -0000 Received: from d06av26.portsmouth.uk.ibm.com (d06av26.portsmouth.uk.ibm.com [9.149.105.62]) by b06avi18878370.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id xALENAvA15270360 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 21 Nov 2019 14:23:10 GMT Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 263BDAE045; Thu, 21 Nov 2019 14:23:10 +0000 (GMT) Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id B5830AE051; Thu, 21 Nov 2019 14:23:09 +0000 (GMT) Received: from localhost.localdomain (unknown [9.145.70.129]) by d06av26.portsmouth.uk.ibm.com (Postfix) with ESMTP; Thu, 21 Nov 2019 14:23:09 +0000 (GMT) Subject: Re: [PATCH 07/15] s390x: protvirt: Handle diag 308 subcodes 0,1,3,4 To: Cornelia Huck References: <20191120114334.2287-1-frankja@linux.ibm.com> <20191120114334.2287-8-frankja@linux.ibm.com> <20191121145001.5e7a182d.cohuck@redhat.com> <2919845b-531d-8c79-fb16-36f67fa29789@linux.ibm.com> <20191121151737.58f9b513.cohuck@redhat.com> From: Janosch Frank Autocrypt: addr=frankja@linux.ibm.com; prefer-encrypt=mutual; keydata= mQINBFubpD4BEADX0uhkRhkj2AVn7kI4IuPY3A8xKat0ihuPDXbynUC77mNox7yvK3X5QBO6 qLqYr+qrG3buymJJRD9xkp4mqgasHdB5WR9MhXWKH08EvtvAMkEJLnqxgbqf8td3pCQ2cEpv 15mH49iKSmlTcJ+PvJpGZcq/jE42u9/0YFHhozm8GfQdb9SOI/wBSsOqcXcLTUeAvbdqSBZe zuMRBivJQQI1esD9HuADmxdE7c4AeMlap9MvxvUtWk4ZJ/1Z3swMVCGzZb2Xg/9jZpLsyQzb lDbbTlEeyBACeED7DYLZI3d0SFKeJZ1SUyMmSOcr9zeSh4S4h4w8xgDDGmeDVygBQZa1HaoL Esb8Y4avOYIgYDhgkCh0nol7XQ5i/yKLtnNThubAcxNyryw1xSstnKlxPRoxtqTsxMAiSekk 0m3WJwvwd1s878HrQNK0orWd8BzzlSswzjNfQYLF466JOjHPWFOok9pzRs+ucrs6MUwDJj0S cITWU9Rxb04XyigY4XmZ8dywaxwi2ZVTEg+MD+sPmRrTw+5F+sU83cUstuymF3w1GmyofgsU Z+/ldjToHnq21MNa1wx0lCEipCCyE/8K9B9bg9pUwy5lfx7yORP3JuAUfCYb8DVSHWBPHKNj HTOLb2g2UT65AjZEQE95U2AY9iYm5usMqaWD39pAHfhC09/7NQARAQABtCVKYW5vc2NoIEZy YW5rIDxmcmFua2phQGxpbnV4LmlibS5jb20+iQI3BBMBCAAhBQJbm6Q+AhsjBQsJCAcCBhUI CQoLAgQWAgMBAh4BAheAAAoJEONU5rjiOLn4p9gQALjkdj5euJVI2nNT3/IAxAhQSmRhPEt0 AmnCYnuTcHRWPujNr5kqgtyER9+EMQ0ZkX44JU2q7OWxTdSNSAN/5Z7qmOR9JySvDOf4d3mS bMB5zxL9d8SbnSs1uW96H9ZBTlTQnmLfsiM9TetAjSrR8nUmjGhe2YUhJLR1v1LguME+YseT eXnLzIzqqpu311/eYiiIGcmaOjPCE+vFjcXL5oLnGUE73qSYiujwhfPCCUK0850o1fUAYq5p CNBCoKT4OddZR+0itKc/cT6NwEDwdokeg0+rAhxb4Rv5oFO70lziBplEjOxu3dqgIKbHbjza EXTb+mr7VI9O4tTdqrwJo2q9zLqqOfDBi7NDvZFLzaCewhbdEpDYVu6/WxprAY94hY3F4trT rQMHJKQENtF6ZTQc9fcT5I3gAmP+OEvDE5hcTALpWm6Z6SzxO7gEYCnF+qGXqp8sJVrweMub UscyLqHoqdZC2UG4LQ1OJ97nzDpIRe0g6oJ9ZIYHKmfw5jjwH6rASTld5MFWajWdNsqK15k/ RZnHAGICKVIBOBsq26m4EsBlfCdt3b/6emuBjUXR1pyjHMz2awWzCq6/6OWs5eANZ0sdosNq dq2v0ULYTazJz2rlCXV89qRa7ukkNwdBSZNEwsD4eEMicj1LSrqWDZMAALw50L4jxaMD7lPL jJbauQINBFubpD4BEADAcUTRqXF/aY53OSH7IwIK9lFKxIm0IoFkOEh7LMfp7FGzaP7ANrZd cIzhZi38xyOkcaFY+npGEWvko7rlIAn0JpBO4x3hfhmhBD/WSY8LQIFQNNjEm3vzrMo7b9Jb JAqQxfbURY3Dql3GUzeWTG9uaJ00u+EEPlY8zcVShDltIl5PLih20e8xgTnNzx5c110lQSu0 iZv2lAE6DM+2bJQTsMSYiwKlwTuv9LI9Chnoo6+tsN55NqyMxYqJgElk3VzlTXSr3+rtSCwf tq2cinETbzxc1XuhIX6pu/aCGnNfuEkM34b7G1D6CPzDMqokNFbyoO6DQ1+fW6c5gctXg/lZ 602iEl4C4rgcr3+EpfoPUWzKeM8JXv5Kpq4YDxhvbitr8Dm8gr38+UKFZKlWLlwhQ56r/zAU v6LIsm11GmFs2/cmgD1bqBTNHHcTWwWtRTLgmnqJbVisMJuYJt4KNPqphTWsPY8SEtbufIlY HXOJ2lqUzOReTrie2u0qcSvGAbSfec9apTFl2Xko/ddqPcZMpKhBiXmY8tJzSPk3+G4tqur4 6TYAm5ouitJsgAR61Cu7s+PNuq/pTLDhK+6/Njmc94NGBcRA4qTuysEGE79vYWP2oIAU4Fv6 gqaWHZ4MEI2XTqH8wiwzPdCQPYsSE0fXWiYu7ObeErT6iLSTZGx4rQARAQABiQIfBBgBCAAJ BQJbm6Q+AhsMAAoJEONU5rjiOLn4DDEP/RuyckW65SZcPG4cMfNgWxZF8rVjeVl/9PBfy01K 8R0hajU40bWtXSMiby7j0/dMjz99jN6L+AJHJvrLz4qYRzn2Ys843W+RfXj62Zde4YNBE5SL jJweRCbMWKaJLj6499fctxTyeb9+AMLQS4yRSwHuAZLmAb5AyCW1gBcTWZb8ON5BmWnRqeGm IgC1EvCnHy++aBnHTn0m+zV89BhTLTUal35tcjUFwluBY39R2ux/HNlBO1GY3Z+WYXhBvq7q katThLjaQSmnOrMhzqYmdShP1leFTVbzXUUIYv/GbynO/YrL2gaQpaP1bEUEi8lUAfXJbEWG dnHFkciryi092E8/9j89DJg4mmZqOau7TtUxjRMlBcIliXkzSLUk+QvD4LK1kWievJse4mte FBdkWHfP4BH/+8DxapRcG1UAheSnSRQ5LiO50annOB7oXF+vgKIaie2TBfZxQNGAs3RQ+bga DchCqFm5adiSP5+OT4NjkKUeGpBe/aRyQSle/RropTgCi85pje/juYEn2P9UAgkfBJrOHvQ9 Z+2Sva8FRd61NJLkCJ4LFumRn9wQlX2icFbi8UDV3do0hXJRRYTWCxrHscMhkrFWLhYiPF4i phX7UNdOWBQ90qpHyAxHmDazdo27gEjfvsgYMdveKknEOTEb5phwxWgg7BcIDoJf9UMC Date: Thu, 21 Nov 2019 15:23:09 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 MIME-Version: 1.0 In-Reply-To: <20191121151737.58f9b513.cohuck@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="DwkXAcHC4EEbfq0V6Vt6UGeBavKtTqCnC" X-TM-AS-GCONF: 00 x-cbid: 19112114-4275-0000-0000-000003847253 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 19112114-4276-0000-0000-00003897EFEE Message-Id: X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.95,18.0.572 definitions=2019-11-21_03:2019-11-21,2019-11-21 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 priorityscore=1501 phishscore=0 mlxlogscore=831 suspectscore=0 adultscore=0 mlxscore=0 bulkscore=0 clxscore=1015 spamscore=0 malwarescore=0 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-1910280000 definitions=main-1911210131 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic] [fuzzy] X-Received-From: 148.163.158.5 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: thuth@redhat.com, pmorel@linux.ibm.com, david@redhat.com, qemu-devel@nongnu.org, borntraeger@de.ibm.com, qemu-s390x@nongnu.org, mihajlov@linux.ibm.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --DwkXAcHC4EEbfq0V6Vt6UGeBavKtTqCnC Content-Type: multipart/mixed; boundary="s5bVODSw1lIXkViLC3odQ8vhKVHEABLtS" --s5bVODSw1lIXkViLC3odQ8vhKVHEABLtS Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 11/21/19 3:17 PM, Cornelia Huck wrote: > On Thu, 21 Nov 2019 15:04:31 +0100 > Janosch Frank wrote: >=20 >> On 11/21/19 2:50 PM, Cornelia Huck wrote: >>> On Wed, 20 Nov 2019 06:43:26 -0500 >>> Janosch Frank wrote: =20 >> >>> =20 >>>> run_on_cpu(cs, s390_do_cpu_load_normal, RUN_ON_CPU_NULL); >>>> break; >>>> case S390_RESET_LOAD_NORMAL: /* Subcode 1*/ =20 >>> >>> missing blank before */ (introduced in a previous patch) >>> >>> =20 >>>> + subsystem_reset(); >>>> + s390_pv_prepare_reset(env); >>>> CPU_FOREACH(t) { >>>> if (t =3D=3D cs) { >>>> continue; >>>> } >>>> run_on_cpu(t, s390_do_cpu_reset, RUN_ON_CPU_NULL); >>>> } >>>> - subsystem_reset(); >>>> run_on_cpu(cs, s390_do_cpu_initial_reset, RUN_ON_CPU_NULL);= >>>> run_on_cpu(cs, s390_do_cpu_load_normal, RUN_ON_CPU_NULL); >>>> break; >>>> case S390_RESET_EXTERNAL: =20 >>> >>> Annotate this with the subcode as well? (in the patch introducing it)= =20 >> >> I think this has no diag 308 subcode and is triggered by qemu >=20 > -ENOCOFFE >=20 > But even more reason to annotate this with the fact that this is > triggered by QEMU :) >=20 You're too late with that idea :) I just split out the reordering and the annotation into a new commit: https://github.com/frankjaa/qemu/commit/8c53d5c8a6bbcc53496c7a2877c7cbffc= 435b708 --s5bVODSw1lIXkViLC3odQ8vhKVHEABLtS-- --DwkXAcHC4EEbfq0V6Vt6UGeBavKtTqCnC Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEwGNS88vfc9+v45Yq41TmuOI4ufgFAl3Wnc0ACgkQ41TmuOI4 ufgJhxAAggpbibBVAGKyEys3DkrASuJTLhomXmu+zd45DfYObRaducVeJHQl6Ekt 9BOarBTaP2FlS/KASK3hS51st+JV7Fl0LzOAsn/4LIJrPeFxGoRuzsapPjaCq/3M 6/JyACgdDfxjUaJ/15+GsDbQda2pNIVQBrQlOaWO9Gjjzk6G2tOmAIMSE8bIGcET Mmzrb6I4rSf0fyVOXVkfqAojC/5LgOkd+PkAxYCiuwXMh96bK/TWnKMHR0C5jIRN ZJ/rBM8aZf7YpFzkxrzqCAxSlkJRAUGCbS6n85dSa4ivRmwtj8IXiZcutl4i2BR3 HI1tc/8sgZ99RiLsO1XFGlvjVlsZLMJ4r+u2ORIFOZb6w8k/w/Hr0yassl73Lqyw Max3pe1sGdhfxWtL2ySnDls+V25BBb3hkfqbGNOXxPvhxMGPQOEj7+X+b/vPb2/S h/m0aHRPfP5Upn3af3FEUz9lfMj9ISTqnKRLnag+WOrMqI14h4xxRdDM9adHpgxS FT2+Sz3Xtz6pHV6HqzB3id5qQnytHDcZ+73+Bu7g577NunU7i2k8TcGJ9hR+kmeB pT6QjXVJRLudH1wLArJbka8+D0kEJCJ8fBfh2uBhg1e2va/sYmNBRDa/+UWpZbEw BBnDGGOLvFvAsgw206xrEF+/Y5hURyyIJvHLKGj4CyjApw8zZ78= =7DMQ -----END PGP SIGNATURE----- --DwkXAcHC4EEbfq0V6Vt6UGeBavKtTqCnC--