From: Paolo Bonzini <pbonzini@redhat.com>
To: "Markus Armbruster" <armbru@redhat.com>,
"Daniel P. Berrangé" <berrange@redhat.com>
Cc: "Michal Prívozník" <mprivozn@redhat.com>,
qemu-devel@nongnu.org, "Igor Mammedov" <imammedo@redhat.com>
Subject: Re: [PATCH] qmp: Stabilize preconfig
Date: Wed, 10 Nov 2021 22:56:23 +0100 [thread overview]
Message-ID: <c4ac9bcc-90ae-302f-d5d4-b95f1419a7a0@redhat.com> (raw)
In-Reply-To: <87zgqlzmxi.fsf@dusky.pond.sub.org>
> On 11/3/21 09:02, Markus Armbruster wrote:
>> I wonder whether we really have to step through three states
>>
>> x-exit-preconfig cont
>> preconfig ---> pre run ---> run
>>
>> and not two
>>
>> cont
>> pre run ---> run
Devices would be hotplugged between x-exit-preconfig and cont, and part
of the machine until x-exit-preconfig; so there is a need for something
like x-exit-preconfig.
In my prototype of a QMP-only binary, the idea would be that there
wouldn't be a single x-exit-preconfig command, but "cont",
"migrate-incoming", "finish-machine-init" (the stable replacement for
x-exit-preconfig) and "loadvm" would all complete the configuration of
the machine. "finish-machine-init" would do nothing else, the others
would continue with whatever they were supposed to do.
>> Which of the queries you need work only between x-exit-preconfig and -S?
>
> Well before x-exit-preconfig, QMP only permits a very small number
> of commands - QEMU has loosened that up a bit, but I don't think anyone
> has checked whether there's enough to cover libvirt's current usage yet.
Indeed I looked at the commands that operate on the backends, but not
that much at query commands.
Paolo
next prev parent reply other threads:[~2021-11-10 21:57 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-25 11:08 [PATCH] qmp: Stabilize preconfig Michal Privoznik
2021-10-25 12:19 ` Markus Armbruster
2021-10-25 17:01 ` Paolo Bonzini
2021-11-01 14:37 ` Michal Prívozník
2021-11-01 14:57 ` Daniel P. Berrangé
2021-11-03 8:02 ` Markus Armbruster
2021-11-03 9:27 ` Daniel P. Berrangé
2021-11-10 12:54 ` Michal Prívozník
2021-11-10 13:23 ` Damien Hedde
2021-11-10 21:56 ` Paolo Bonzini [this message]
2021-11-11 6:11 ` Markus Armbruster
2021-11-11 8:15 ` Paolo Bonzini
2021-11-11 14:37 ` Markus Armbruster
2021-11-11 19:22 ` Paolo Bonzini
2021-11-12 11:48 ` Markus Armbruster
2021-11-12 22:18 ` Paolo Bonzini
2021-11-13 7:52 ` Markus Armbruster
2021-11-15 12:37 ` Paolo Bonzini
2021-11-15 15:40 ` Markus Armbruster
2021-11-16 6:50 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c4ac9bcc-90ae-302f-d5d4-b95f1419a7a0@redhat.com \
--to=pbonzini@redhat.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=imammedo@redhat.com \
--cc=mprivozn@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).