From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7646C48BCF for ; Wed, 9 Jun 2021 12:18:39 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8068A61364 for ; Wed, 9 Jun 2021 12:18:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8068A61364 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:33246 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lqxAM-00010x-NQ for qemu-devel@archiver.kernel.org; Wed, 09 Jun 2021 08:18:38 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41116) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lqx9J-0006ye-3y for qemu-devel@nongnu.org; Wed, 09 Jun 2021 08:17:33 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:28997) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lqx9E-0000Ap-1v for qemu-devel@nongnu.org; Wed, 09 Jun 2021 08:17:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1623241046; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+5qTwneeYksEp0OTTvWXty3HzzO/mhZR9rzK7LRn9+U=; b=goqiiaVLm4JunPfjhAYFoSSM0+GI5hH3TYQyD1R3xHsMYeqhye9gw9YaxmW31+RAieBPm4 0Onz9wXpV7sOmJAAFMzfaj7FpBv9rzsPbaNf4cNLAAsrQaXvPUspHcYbNEo80xtL7+t5jG IbftGQUMHfMzz5HxXU4XESnS4ypZnpE= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-173-4MSyVPceNsuJDGTPCnyrmQ-1; Wed, 09 Jun 2021 08:17:25 -0400 X-MC-Unique: 4MSyVPceNsuJDGTPCnyrmQ-1 Received: by mail-wr1-f71.google.com with SMTP id z13-20020adfec8d0000b0290114cc6b21c4so10640967wrn.22 for ; Wed, 09 Jun 2021 05:17:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=+5qTwneeYksEp0OTTvWXty3HzzO/mhZR9rzK7LRn9+U=; b=VxnmYxkaouREt9HaDC3SpDq854+LzezmMeYOFCRr3bbHVPxLTcvsB5qtxwPdy14yWb X/9CXNpzeEs7lhy+nZebp8VbQxycLFrlD7WNpTMdYXpACE5EweupWJu6+efRjEVqXaVI mq2iI67UgNHEvg7/Exzs58RPrSiqwKm9Ve/TWJe3kAfjEFJ9GDvwKQbxLue8YI7u0yz9 fcBIx++kZW1PFM9TiDPJGIZ3ymOox30K1HZjlpoXzcqJYEWrGnXPg/j641at72lKUDhY 0fJoWa3UhmXza5tjHMm4LYkKVDECCMVt2ucQtFf7jXIkgznH+3O6hZuGKoJq6YNAVU6j hzbw== X-Gm-Message-State: AOAM5324WgKhShPVI0x+BFBkS4mqnBJbQegrYEWKTsA00MTl3Vk3bjTu HYi+xfCHLxKyclerx06axdtlg2DbvSFoogQWNuYLB2EE00K6yMJrDwJ97dAscv5as6/n6/Owrr8 TLqjFKe6vtmf7ib4= X-Received: by 2002:a7b:ce8a:: with SMTP id q10mr27587313wmj.184.1623241044624; Wed, 09 Jun 2021 05:17:24 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwAZNhq52SJV36buontqGscQCHbvpYZVpV+5htp294SHN9FBLsrz2ajKAaFDj1BQYLZ28+o9Q== X-Received: by 2002:a7b:ce8a:: with SMTP id q10mr27587293wmj.184.1623241044464; Wed, 09 Jun 2021 05:17:24 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id k36sm12033036wms.30.2021.06.09.05.17.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 09 Jun 2021 05:17:23 -0700 (PDT) Subject: Re: [PATCH v3 06/33] util/async: aio_co_schedule(): support reschedule in same ctx To: Vladimir Sementsov-Ogievskiy , qemu-block@nongnu.org References: <20210416080911.83197-1-vsementsov@virtuozzo.com> <20210416080911.83197-7-vsementsov@virtuozzo.com> <32f2b6f0-2c31-942d-cbe2-81eda2a43fc0@redhat.com> <19ff6e67-e548-14df-ac7e-8b0a3bf7a798@virtuozzo.com> <52ba34c5-1de8-21b3-a31c-bf51676c29af@virtuozzo.com> <154cff7e-3552-5cb1-4d96-8dae3c1607cb@redhat.com> <008cbc78-aebe-e2fa-8fb3-f8cbdc6daf31@virtuozzo.com> From: Paolo Bonzini Message-ID: Date: Wed, 9 Jun 2021 14:17:22 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <008cbc78-aebe-e2fa-8fb3-f8cbdc6daf31@virtuozzo.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=pbonzini@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=216.205.24.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -29 X-Spam_score: -3.0 X-Spam_bar: --- X-Spam_report: (-3.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.199, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kwolf@redhat.com, Fam Zheng , qemu-devel@nongnu.org, mreitz@redhat.com, rvkagan@yandex-team.ru, Stefan Hajnoczi , den@openvz.org, eblake@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 09/06/21 12:24, Vladimir Sementsov-Ogievskiy wrote: > Thanks, I'll base v4 of nbd patches on it. > > I now run make check. test-aio-multithread crashes on assertion: With the patch I've sent it doesn't, so hopefully you can go ahead. Paolo > (gdb) bt > #0  0x00007f4af8d839d5 in raise () from /lib64/libc.so.6 > #1  0x00007f4af8d6c8a4 in abort () from /lib64/libc.so.6 > #2  0x00007f4af8d6c789 in __assert_fail_base.cold () from /lib64/libc.so.6 > #3  0x00007f4af8d7c026 in __assert_fail () from /lib64/libc.so.6 > #4  0x000055daebfdab95 in aio_poll (ctx=0x7f4ae0000b60, blocking=true) > at ../util/aio-posix.c:567 > #5  0x000055daebea096c in iothread_run (opaque=0x55daed81bc90) at > ../tests/unit/iothread.c:91 > #6  0x000055daebfc6c4a in qemu_thread_start (args=0x55daed7d9940) at > ../util/qemu-thread-posix.c:521 > #7  0x00007f4af8f1a3f9 in start_thread () from /lib64/libpthread.so.0 > #8  0x00007f4af8e47b53 in clone () from /lib64/libc.so.6 > (gdb) fr 4 > #4  0x000055daebfdab95 in aio_poll (ctx=0x7f4ae0000b60, blocking=true) > at ../util/aio-posix.c:567 > 567         assert(in_aio_context_home_thread(ctx == > iohandler_get_aio_context() ? > (gdb) list > 562          * > 563          * aio_poll() may only be called in the AioContext's thread. > iohandler_ctx > 564          * is special in that it runs in the main thread, but that > thread's context > 565          * is qemu_aio_context. > 566          */ > 567         assert(in_aio_context_home_thread(ctx == > iohandler_get_aio_context() ? > 568                                           qemu_get_aio_context() : > ctx)); > 569 > 570         qemu_lockcnt_inc(&ctx->list_lock);