From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E066EC33C9E for ; Wed, 15 Jan 2020 03:12:16 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B736A24671 for ; Wed, 15 Jan 2020 03:12:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B736A24671 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:48690 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1irZ6N-0002Z4-Se for qemu-devel@archiver.kernel.org; Tue, 14 Jan 2020 22:12:15 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:35924) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1irZ5S-0001dL-Dp for qemu-devel@nongnu.org; Tue, 14 Jan 2020 22:11:19 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1irZ5O-0003u7-6q for qemu-devel@nongnu.org; Tue, 14 Jan 2020 22:11:16 -0500 Received: from szxga06-in.huawei.com ([45.249.212.32]:49562 helo=huawei.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1irZ5N-0003rn-S4 for qemu-devel@nongnu.org; Tue, 14 Jan 2020 22:11:14 -0500 Received: from DGGEMS407-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id 55286A9C8BA560A9119D; Wed, 15 Jan 2020 11:11:08 +0800 (CST) Received: from [10.184.39.213] (10.184.39.213) by smtp.huawei.com (10.3.19.207) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 15 Jan 2020 11:10:58 +0800 Subject: Re: [PATCH V2] vhost-user-test: fix a memory leak From: Pan Nengyuan To: Thomas Huth References: <1576805214-2508-1-git-send-email-pannengyuan@huawei.com> <072970b5-b7cc-ad71-d3e4-933e888b7093@redhat.com> <3312978e-2bff-091a-b618-d9183b8c7252@redhat.com> Message-ID: Date: Wed, 15 Jan 2020 11:10:58 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.184.39.213] X-CFilter-Loop: Reflected X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 45.249.212.32 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: lvivier@redhat.com, pbonzini@redhat.com, zhang.zhanghailiang@huawei.com, qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 1/13/2020 10:32 AM, Pan Nengyuan wrote: > > > On 1/12/2020 6:39 PM, Thomas Huth wrote: >> On 10/01/2020 15.07, Thomas Huth wrote: >>> On 20/12/2019 02.26, pannengyuan@huawei.com wrote: >>>> From: Pan Nengyuan >>>> >>>> Spotted by ASAN. >>>> >>>> Reported-by: Euler Robot >>>> Signed-off-by: Pan Nengyuan >>>> --- >>>> Changes V2 to V1: >>>> - use a "goto cleanup", instead of duplicating the "free" functions. >>>> - free "dest_cmdline" at the end. >>>> --- >>> >>> Reviewed-by: Thomas Huth >>> >>> ... and picked up to my qtest-next tree. >> >> ... and now I had to unqueue the patch again. It is reproducibly causing >> one of the gitlab CI pipelines to fail with a timeout, e.g.: >> >> https://gitlab.com/huth/qemu/-/jobs/400101552 >> >> Not sure what is going on here, though, there is no obvious error >> message in the output... this needs some more investigation... do you >> have a gitlab account and could have a look? >> > > OK, I will register a account and have a look. > I'm sorry, I build and test with the same params, but I can't reproduce it. Could you add "V=1 or V=2" params to get more information ? >> Thomas >> >> . >>