From: Auger Eric <eric.auger@redhat.com>
To: Michal Privoznik <mprivozn@redhat.com>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, alex.williamson@redhat.com
Subject: Re: [PATCH v2] Report stringified errno in VFIO related errors
Date: Fri, 14 Feb 2020 12:14:46 +0100 [thread overview]
Message-ID: <c569577c-fc05-78a5-21c6-c8c0b924a80d@redhat.com> (raw)
In-Reply-To: <4949c3ecf1a32189b8a4b5eb4b0fd04c1122501d.1581674006.git.mprivozn@redhat.com>
Hi Michal,
On 2/14/20 10:55 AM, Michal Privoznik wrote:
> In a few places we report errno formatted as a negative integer.
> This is not as user friendly as it can be. Use strerror() and/or
> error_setg_errno() instead.
>
> Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Eric Auger <eric.auger@redhat.com>
Thanks
Eric
> ---
>
> v1 posted here:
>
> https://lists.nongnu.org/archive/html/qemu-devel/2020-02/msg03623.html
>
> diff to v1:
> - Change error reporting in vfio_dma_unmap() too as I missed it in v1.
>
> hw/vfio/common.c | 4 ++--
> util/vfio-helpers.c | 6 +++---
> 2 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/hw/vfio/common.c b/hw/vfio/common.c
> index 5ca11488d6..0b3593b3c0 100644
> --- a/hw/vfio/common.c
> +++ b/hw/vfio/common.c
> @@ -319,7 +319,7 @@ static int vfio_dma_unmap(VFIOContainer *container,
> unmap.size -= 1ULL << ctz64(container->pgsizes);
> continue;
> }
> - error_report("VFIO_UNMAP_DMA: %d", -errno);
> + error_report("VFIO_UNMAP_DMA failed: %s", strerror(errno));
> return -errno;
> }
>
> @@ -352,7 +352,7 @@ static int vfio_dma_map(VFIOContainer *container, hwaddr iova,
> return 0;
> }
>
> - error_report("VFIO_MAP_DMA: %d", -errno);
> + error_report("VFIO_MAP_DMA failed: %s", strerror(errno));
> return -errno;
> }
>
> diff --git a/util/vfio-helpers.c b/util/vfio-helpers.c
> index 813f7ec564..ddd9a96e76 100644
> --- a/util/vfio-helpers.c
> +++ b/util/vfio-helpers.c
> @@ -545,7 +545,7 @@ static int qemu_vfio_do_mapping(QEMUVFIOState *s, void *host, size_t size,
> trace_qemu_vfio_do_mapping(s, host, size, iova);
>
> if (ioctl(s->container, VFIO_IOMMU_MAP_DMA, &dma_map)) {
> - error_report("VFIO_MAP_DMA: %d", -errno);
> + error_report("VFIO_MAP_DMA failed: %s", strerror(errno));
> return -errno;
> }
> return 0;
> @@ -570,7 +570,7 @@ static void qemu_vfio_undo_mapping(QEMUVFIOState *s, IOVAMapping *mapping,
> assert(QEMU_IS_ALIGNED(mapping->size, qemu_real_host_page_size));
> assert(index >= 0 && index < s->nr_mappings);
> if (ioctl(s->container, VFIO_IOMMU_UNMAP_DMA, &unmap)) {
> - error_setg(errp, "VFIO_UNMAP_DMA failed: %d", -errno);
> + error_setg_errno(errp, errno, "VFIO_UNMAP_DMA failed");
> }
> memmove(mapping, &s->mappings[index + 1],
> sizeof(s->mappings[0]) * (s->nr_mappings - index - 1));
> @@ -669,7 +669,7 @@ int qemu_vfio_dma_reset_temporary(QEMUVFIOState *s)
> trace_qemu_vfio_dma_reset_temporary(s);
> qemu_mutex_lock(&s->lock);
> if (ioctl(s->container, VFIO_IOMMU_UNMAP_DMA, &unmap)) {
> - error_report("VFIO_UNMAP_DMA: %d", -errno);
> + error_report("VFIO_UNMAP_DMA failed: %s", strerror(errno));
> qemu_mutex_unlock(&s->lock);
> return -errno;
> }
>
next prev parent reply other threads:[~2020-02-14 11:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-14 9:55 [PATCH v2] Report stringified errno in VFIO related errors Michal Privoznik
2020-02-14 10:04 ` Ján Tomko
2020-02-14 10:37 ` Cornelia Huck
2020-02-14 11:14 ` Auger Eric [this message]
2020-02-14 11:49 ` Philippe Mathieu-Daudé
2020-02-14 15:35 ` Alex Williamson
2020-02-14 16:50 ` Laurent Vivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c569577c-fc05-78a5-21c6-c8c0b924a80d@redhat.com \
--to=eric.auger@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=mprivozn@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).