From: Auger Eric <eric.auger@redhat.com>
To: Jean-Philippe Brucker <jean-philippe@linaro.org>,
alex.williamson@redhat.com
Cc: pbonzini@redhat.com, bbhushan2@marvell.com,
qemu-devel@nongnu.org, peterx@redhat.com, mst@redhat.com
Subject: Re: [PATCH v10 01/10] virtio-iommu: Fix virtio_iommu_mr()
Date: Fri, 16 Oct 2020 09:36:25 +0200 [thread overview]
Message-ID: <c60b6549-e6ce-79c7-1558-76f6cb882afb@redhat.com> (raw)
In-Reply-To: <20201008171558.410886-2-jean-philippe@linaro.org>
Hi Jean,
On 10/8/20 7:15 PM, Jean-Philippe Brucker wrote:
> Due to an invalid mask, virtio_iommu_mr() may return the wrong memory
> region. It hasn't been too problematic so far because the function was
> only used to test existence of an endpoint, but that is about to change.
>
> Fixes: cfb42188b24d ("virtio-iommu: Implement attach/detach command")
> Signed-off-by: Jean-Philippe Brucker <jean-philippe@linaro.org>
Maybe add
CC: QEMU Stable <qemu-stable@nongnu.org>
Acked-by: Eric Auger <eric.auger@redhat.com>
Thanks
Eric
> ---
> hw/virtio/virtio-iommu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/virtio/virtio-iommu.c b/hw/virtio/virtio-iommu.c
> index a91fa2f674c..543fbbb24fb 100644
> --- a/hw/virtio/virtio-iommu.c
> +++ b/hw/virtio/virtio-iommu.c
> @@ -101,7 +101,7 @@ static IOMMUMemoryRegion *virtio_iommu_mr(VirtIOIOMMU *s, uint32_t sid)
> bus_n = PCI_BUS_NUM(sid);
> iommu_pci_bus = iommu_find_iommu_pcibus(s, bus_n);
> if (iommu_pci_bus) {
> - devfn = sid & PCI_DEVFN_MAX;
> + devfn = sid & (PCI_DEVFN_MAX - 1);
> dev = iommu_pci_bus->pbdev[devfn];
> if (dev) {
> return &dev->iommu_mr;
>
next prev parent reply other threads:[~2020-10-16 7:38 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-08 17:15 [PATCH v10 00/10] virtio-iommu: VFIO integration Jean-Philippe Brucker
2020-10-08 17:15 ` [PATCH v10 01/10] virtio-iommu: Fix virtio_iommu_mr() Jean-Philippe Brucker
2020-10-16 7:36 ` Auger Eric [this message]
2020-10-19 21:36 ` Peter Xu
2020-10-08 17:15 ` [PATCH v10 02/10] virtio-iommu: Store memory region in endpoint struct Jean-Philippe Brucker
2020-10-16 7:37 ` Auger Eric
2020-10-08 17:15 ` [PATCH v10 03/10] virtio-iommu: Add memory notifiers for map/unmap Jean-Philippe Brucker
2020-10-16 7:58 ` Auger Eric
2020-10-22 16:41 ` Jean-Philippe Brucker
2020-10-08 17:15 ` [PATCH v10 04/10] virtio-iommu: Call memory notifiers in attach/detach Jean-Philippe Brucker
2020-10-16 8:05 ` Auger Eric
2020-10-08 17:15 ` [PATCH v10 05/10] virtio-iommu: Add replay() memory region callback Jean-Philippe Brucker
2020-10-16 9:12 ` Auger Eric
2020-10-22 16:42 ` Jean-Philippe Brucker
2020-10-08 17:15 ` [PATCH v10 06/10] virtio-iommu: Add notify_flag_changed() " Jean-Philippe Brucker
2020-10-16 8:18 ` Auger Eric
2020-10-08 17:15 ` [PATCH v10 07/10] memory: Add interface to set iommu page size mask Jean-Philippe Brucker
2020-10-16 9:24 ` Auger Eric
2020-10-22 16:43 ` Jean-Philippe Brucker
2020-10-19 21:36 ` Peter Xu
2020-10-08 17:15 ` [PATCH v10 08/10] vfio: Set IOMMU page size as per host supported page size Jean-Philippe Brucker
2020-10-08 21:22 ` Alex Williamson
2020-10-30 10:26 ` Michael S. Tsirkin
2020-10-30 15:19 ` Jean-Philippe Brucker
2020-10-16 9:25 ` Auger Eric
2020-10-08 17:15 ` [PATCH v10 09/10] virtio-iommu: Set supported page size mask Jean-Philippe Brucker
2020-10-16 13:08 ` Auger Eric
2020-10-22 16:43 ` Jean-Philippe Brucker
2020-10-19 21:35 ` Peter Xu
2020-10-22 16:39 ` Jean-Philippe Brucker
2020-10-22 20:56 ` Peter Xu
2020-10-23 7:48 ` Jean-Philippe Brucker
2020-10-23 16:47 ` Peter Xu
2020-10-27 17:38 ` Jean-Philippe Brucker
2020-10-30 10:24 ` Michael S. Tsirkin
2020-10-08 17:15 ` [PATCH v10 10/10] vfio: Don't issue full 2^64 unmap Jean-Philippe Brucker
2020-10-08 21:22 ` Alex Williamson
2020-10-30 10:25 ` Michael S. Tsirkin
2020-10-30 17:26 ` Alex Williamson
2020-10-30 18:19 ` Paolo Bonzini
2020-11-02 17:37 ` Alex Williamson
2020-11-02 17:44 ` Paolo Bonzini
2020-11-02 18:00 ` Alex Williamson
2020-10-16 9:47 ` Auger Eric
2020-10-16 13:13 ` [PATCH v10 00/10] virtio-iommu: VFIO integration Auger Eric
2020-10-30 10:27 ` Michael S. Tsirkin
2020-10-30 10:48 ` Jean-Philippe Brucker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c60b6549-e6ce-79c7-1558-76f6cb882afb@redhat.com \
--to=eric.auger@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=bbhushan2@marvell.com \
--cc=jean-philippe@linaro.org \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).