From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A126AC433E0 for ; Tue, 16 Mar 2021 18:30:26 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F2F3865139 for ; Tue, 16 Mar 2021 18:30:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F2F3865139 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:40852 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lMESW-0003zA-U7 for qemu-devel@archiver.kernel.org; Tue, 16 Mar 2021 14:30:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53772) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lMDza-00008j-3n for qemu-devel@nongnu.org; Tue, 16 Mar 2021 14:00:30 -0400 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:49089) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1lMDzV-0001pj-NK for qemu-devel@nongnu.org; Tue, 16 Mar 2021 14:00:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1615917622; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=H/aq40AbW+M8XRbGim5Lfa5I8urvhxjNhOkLiGDZN2s=; b=TsQH9Dor3bNQj+mynQikZevs4SNgI2gm2SGcKwZWjWaMXL9RDRwc/LEdjhHXeCiX5kAMB7 HWTvybxplRXxyRsA5eZAY7XsCM0MfMr2E4rw+QOsoCUq14q++imLQHw43VCRWUB9XWc8qy XN6RwjDNQvhXcdubzYWrGHKTf8HQ5Rw= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-508-1Jo4w-drMAm_z8JIJtSi4Q-1; Tue, 16 Mar 2021 14:00:18 -0400 X-MC-Unique: 1Jo4w-drMAm_z8JIJtSi4Q-1 Received: by mail-wr1-f69.google.com with SMTP id n16so15987941wro.1 for ; Tue, 16 Mar 2021 11:00:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=H/aq40AbW+M8XRbGim5Lfa5I8urvhxjNhOkLiGDZN2s=; b=p+dberYtYEWM3G1vJo8jMu0dcnAwNZr49OOypjqFMlqTlVcZZ/Z7VGk9xvaBC1N6mj jTKmqaH6vkH1z/yh8fgaWLV7xJH92OcsMSBIBOt10f9PbMzTR3AIoe9YbQRmBLaZI5Bz EDBCPrHWyU92j2lFu79zA57/Vr/S0VSAvaT4fPqCf3Ymq1zqHxz7pyKQu6/NdR5kN/Wv q0rDCBtO7J5oQ2mofQNZtrvj1aQjZ7IG6ezkhci7s5wvqe6rLFtR+l9N1T8ZHmCB+7zt OFoKeXKdlnwEO1Uz1c8r6dPdC3SohJVQAaHKLn6urOa1SQ7WWTxW+X3vqRuTpiGVAeDi KLzQ== X-Gm-Message-State: AOAM530Pl4+wvT3O9OhXJ+LbtAil/F2OiBi9dpWGIOrNsNKn6g4xV3Wf 4kUOJB3he2452tBi00wjOg4awQzlkgREl//V1EBhU6wUDs0o2pJocSkG9UcWWBd6lg1qGwXG6TI vXXAsYuNfCPtxmGA= X-Received: by 2002:a05:6000:118c:: with SMTP id g12mr197195wrx.353.1615917617703; Tue, 16 Mar 2021 11:00:17 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwcShq8UUHWLSbiLLETDYeOZPyQLOo2KXL89dgQChsvxJ43RRppTny8zwXZQ4/MTeQ7vI+ISw== X-Received: by 2002:a05:6000:118c:: with SMTP id g12mr197167wrx.353.1615917617509; Tue, 16 Mar 2021 11:00:17 -0700 (PDT) Received: from [192.168.1.36] (17.red-88-21-201.staticip.rima-tde.net. [88.21.201.17]) by smtp.gmail.com with ESMTPSA id u4sm24297120wrm.24.2021.03.16.11.00.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 16 Mar 2021 11:00:17 -0700 (PDT) Subject: Re: [PATCH v2 1/4] accel: Introduce 'query-accels' QMP command To: Eric Blake , qemu-devel@nongnu.org References: <20210316172449.3148634-1-philmd@redhat.com> <20210316172449.3148634-2-philmd@redhat.com> <6f87212e-d00f-751e-1a2c-1dd4950698dc@redhat.com> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Message-ID: Date: Tue, 16 Mar 2021 19:00:15 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <6f87212e-d00f-751e-1a2c-1dd4950698dc@redhat.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=63.128.21.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -29 X-Spam_score: -3.0 X-Spam_bar: --- X-Spam_report: (-3.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.25, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Laurent Vivier , Thomas Huth , Andrew Jones , Eduardo Habkost , "Michael S. Tsirkin" , =?UTF-8?Q?Daniel_P_=2e_Berrang=c3=a9?= , Richard Henderson , Markus Armbruster , qemu-arm@nongnu.org, Claudio Fontana , Igor Mammedov , Paolo Bonzini Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 3/16/21 6:29 PM, Eric Blake wrote: > On 3/16/21 12:24 PM, Philippe Mathieu-Daudé wrote: >> Introduce the 'query-accels' QMP command which returns a list >> of built-in accelerator names. >> >> - Accelerator is a QAPI enum of all existing accelerators, >> >> - AcceleratorInfo is a QAPI structure providing accelerator >> specific information. Currently the common structure base >> provides the name of the accelerator, while the specific >> part is empty, but each accelerator can expand it. >> > >> Signed-off-by: Philippe Mathieu-Daudé >> --- >> Since v1: 'type' -> 'name' in comments >> --- >> qapi/machine.json | 55 +++++++++++++++++++++++++++++++++++++++++++++++ >> accel/accel-qmp.c | 49 +++++++++++++++++++++++++++++++++++++++++ >> accel/meson.build | 2 +- >> 3 files changed, 105 insertions(+), 1 deletion(-) >> create mode 100644 accel/accel-qmp.c >> >> diff --git a/qapi/machine.json b/qapi/machine.json >> index 330189efe3d..610252fc25c 100644 >> --- a/qapi/machine.json >> +++ b/qapi/machine.json >> @@ -1471,3 +1471,58 @@ >> ## >> { 'event': 'MEM_UNPLUG_ERROR', >> 'data': { 'device': 'str', 'msg': 'str' } } >> + >> +## >> +# @Accelerator: >> +# >> +# An enumeration of accelerator names. >> +# >> +# Since: 6.0 >> +## >> +{ 'enum': 'Accelerator', >> + 'data': [ { 'name': 'qtest' }, >> + { 'name': 'tcg' }, >> + { 'name': 'kvm' }, >> + { 'name': 'hax' }, >> + { 'name': 'hvf' }, >> + { 'name': 'whpx' }, >> + { 'name': 'xen' } ] } > > Shorter, but semantically equivalent: > { 'enum': 'Accelerator', 'data': [ 'qtest', 'tcg', ... ] } > > I'd mention in the commit message body that we can't make the enum > values or union branches conditional because of target-specific > poisoning. Good idea. > With that, > > Reviewed-by: Eric Blake > > If we're trying to get it into 6.0, it is a new feature, and so we > should get it in a pull request before feature freeze today. Otherwise > we'll have to s/6.0/6.1/ There is no rush for this, I posted it to scratch it from my today's TODO list and be able to focus on the next task. I'll wait for other review and repost with 6.1 (except if someone judge it is useful to get this for 6.0). Thanks for your review! Phil.