* [Qemu-devel] [PATCH RFC] checkpatch: do not warn for multiline parenthesized returned value
@ 2019-06-21 11:28 Paolo Bonzini
2019-06-21 13:47 ` Eric Blake
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Paolo Bonzini @ 2019-06-21 11:28 UTC (permalink / raw)
To: qemu-devel; +Cc: armbru
While indeed we do not want to have
return (a);
it is less clear that this applies to
return (a &&
b);
Some editors indent more nicely if you have parentheses, and some people's
eyes may appreciate that as well.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
scripts/checkpatch.pl | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index c2aaf42..2f81371 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -2296,7 +2296,8 @@ sub process {
$value =~ s/\([^\(\)]*\)/1/) {
}
#print "value<$value>\n";
- if ($value =~ /^\s*(?:$Ident|-?$Constant)\s*$/) {
+ if ($value =~ /^\s*(?:$Ident|-?$Constant)\s*$/ &&
+ $line =~ /;$/) {
ERROR("return is not a function, parentheses are not required\n" . $herecurr);
} elsif ($spacing !~ /\s+/) {
--
1.8.3.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH RFC] checkpatch: do not warn for multiline parenthesized returned value
2019-06-21 11:28 [Qemu-devel] [PATCH RFC] checkpatch: do not warn for multiline parenthesized returned value Paolo Bonzini
@ 2019-06-21 13:47 ` Eric Blake
2019-06-24 9:00 ` Markus Armbruster
2019-06-25 15:12 ` Richard Henderson
2 siblings, 0 replies; 4+ messages in thread
From: Eric Blake @ 2019-06-21 13:47 UTC (permalink / raw)
To: Paolo Bonzini, qemu-devel; +Cc: armbru
[-- Attachment #1.1: Type: text/plain, Size: 1319 bytes --]
On 6/21/19 6:28 AM, Paolo Bonzini wrote:
> While indeed we do not want to have
>
> return (a);
>
> it is less clear that this applies to
>
> return (a &&
> b);
>
> Some editors indent more nicely if you have parentheses, and some people's
> eyes may appreciate that as well.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> scripts/checkpatch.pl | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
I'm certainly in favor of this (as I've been known to use this style).
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index c2aaf42..2f81371 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -2296,7 +2296,8 @@ sub process {
> $value =~ s/\([^\(\)]*\)/1/) {
> }
> #print "value<$value>\n";
> - if ($value =~ /^\s*(?:$Ident|-?$Constant)\s*$/) {
> + if ($value =~ /^\s*(?:$Ident|-?$Constant)\s*$/ &&
> + $line =~ /;$/) {
So the diagnosis now checks for a trailing ';' as its witness of whether
this is a one-liner return statement, leaving multi-liners undiagnosed.
Easy enough to understand.
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH RFC] checkpatch: do not warn for multiline parenthesized returned value
2019-06-21 11:28 [Qemu-devel] [PATCH RFC] checkpatch: do not warn for multiline parenthesized returned value Paolo Bonzini
2019-06-21 13:47 ` Eric Blake
@ 2019-06-24 9:00 ` Markus Armbruster
2019-06-25 15:12 ` Richard Henderson
2 siblings, 0 replies; 4+ messages in thread
From: Markus Armbruster @ 2019-06-24 9:00 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: qemu-devel
Paolo Bonzini <pbonzini@redhat.com> writes:
> While indeed we do not want to have
>
> return (a);
>
> it is less clear that this applies to
>
> return (a &&
> b);
>
> Some editors indent more nicely if you have parentheses, and some people's
> eyes may appreciate that as well.
No objection.
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> scripts/checkpatch.pl | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index c2aaf42..2f81371 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -2296,7 +2296,8 @@ sub process {
> $value =~ s/\([^\(\)]*\)/1/) {
> }
> #print "value<$value>\n";
> - if ($value =~ /^\s*(?:$Ident|-?$Constant)\s*$/) {
> + if ($value =~ /^\s*(?:$Ident|-?$Constant)\s*$/ &&
> + $line =~ /;$/) {
> ERROR("return is not a function, parentheses are not required\n" . $herecurr);
>
> } elsif ($spacing !~ /\s+/) {
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH RFC] checkpatch: do not warn for multiline parenthesized returned value
2019-06-21 11:28 [Qemu-devel] [PATCH RFC] checkpatch: do not warn for multiline parenthesized returned value Paolo Bonzini
2019-06-21 13:47 ` Eric Blake
2019-06-24 9:00 ` Markus Armbruster
@ 2019-06-25 15:12 ` Richard Henderson
2 siblings, 0 replies; 4+ messages in thread
From: Richard Henderson @ 2019-06-25 15:12 UTC (permalink / raw)
To: Paolo Bonzini, qemu-devel; +Cc: armbru
On 6/21/19 1:28 PM, Paolo Bonzini wrote:
> While indeed we do not want to have
>
> return (a);
>
> it is less clear that this applies to
>
> return (a &&
> b);
>
> Some editors indent more nicely if you have parentheses, and some people's
> eyes may appreciate that as well.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> scripts/checkpatch.pl | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Thanks, I do this semi-regularly.
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-06-25 15:19 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-21 11:28 [Qemu-devel] [PATCH RFC] checkpatch: do not warn for multiline parenthesized returned value Paolo Bonzini
2019-06-21 13:47 ` Eric Blake
2019-06-24 9:00 ` Markus Armbruster
2019-06-25 15:12 ` Richard Henderson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).