From: Richard Henderson <richard.henderson@linaro.org>
To: Ilya Leoshkevich <iii@linux.ibm.com>,
Paolo Bonzini <pbonzini@redhat.com>
Cc: Christian Borntraeger <borntraeger@de.ibm.com>,
Cornelia Huck <cohuck@redhat.com>,
qemu-devel@nongnu.org, David Hildenbrand <david@redhat.com>
Subject: Re: [PATCH] accel/tcg: Fix translation exception on invalid instruction
Date: Tue, 13 Apr 2021 08:29:13 -0700 [thread overview]
Message-ID: <c89ee64c-6aaa-c0e3-5044-f1c507151497@linaro.org> (raw)
In-Reply-To: <20210413132349.20520-1-iii@linux.ibm.com>
On 4/13/21 6:23 AM, Ilya Leoshkevich wrote:
> * When tb_gen_code() is called on that page, tb->size ends up being 0
This is the bug, in target/s390x. Perhaps we need to add an assert that size
!= 0 after translation...
> Fix by special-casing tb->size == 0: since there is no useful code, we
> don't need to link pages in this case.
Yes we do, because we need to link to the page to notice when changes to that
page occur.
While this won't happen in the specific case of uretprobe, it affects every
other instance of a TB which begins with an illegal instruction.
r~
prev parent reply other threads:[~2021-04-13 15:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-13 13:23 [PATCH] accel/tcg: Fix translation exception on invalid instruction Ilya Leoshkevich
2021-04-13 15:29 ` Richard Henderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c89ee64c-6aaa-c0e3-5044-f1c507151497@linaro.org \
--to=richard.henderson@linaro.org \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=iii@linux.ibm.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).